This issue can be closed when the necessary files to reproduce the results of the coupled exercises are added to the repo.
Those files should include:

• Moltres input files
• Geometry files
• .csv files necessary for obtaining plots and results
• Necessary functions for carrying out the post-processing

By @gwenchee suggestion, I am opening this issue.
The organization of the different files in the repo is messy.
This issue can be closed with a PR that organizes the files in the repo.

An analysis of different models of the mass flow distribution in the fuel assembly is desired.
This issue can be closed when a PR merges those files.

Add the input files of the fuel column thermal-fluids model, including geometry, moltres input files, and post-processors.
This issue can be closed when a PR adds those files.

This issue can be closed when the necessary files for obtaining the full-core results are added to the repo, including:

• Moltres input files
• .csv with the results of those input files
• Geometry files to generate the mesh used in the input files
• python script to create cross-section files readable by Moltres
• post-processors to reproduce the results

This issue can be closed when a Serpent model of a standard fuel column of the MHTGR350 has been added to the repo.

This issue can be closed when the fullcore input adds lines that define flux detectors.

This issue can be closed when the input files for the fuel column and the full core add the lines to produce the group constants at different operational temperatures.

This issue can be closed when a basic input file in Moltres thermal-fluids model is added to the repo and its results are compared to an analytical solution.

The MHTGR-350 uses two types of fuel elements: a standard fuel assembly and a fuel assembly with a reserve shutdown channel (RSC fuel assembly). This issue can be closed when a serpent input file with the model of such fuel assemblies is added to the repo.

A preliminary study was conducted to compare Moltres results to Serpent results.
This study is based on the mhtgr-350 fuel column.
This issue can be closed when Moltres input files are added to the repo.

The fuel-column model in Serpent is missing the python functions that produce the figures with the axial flux.
This issue can be closed when those functions are added to the repo.

The thermal-fluid analyses are missing the full fuel assembly mesh convergence analysis.
This issue can be closed when a PR adds the following files:

• Moltres input file
• Respective .geo file
• python script to plot the results

The current input files use an old definition of the geometry.
The same happens with the material compositions.
This issue can be closed when a PR fixes the geometries and the material compositions.

The verification analysis is missing the files necessary to plot the results.
This issue can be closed when a PR adds those files.

This issue can be closed when the necessary files to reproduce the results are added to the repo.
Those files should include:

• Moltres input files
• Geometry files
• .csv files necessary for obtaining plots and results
• Necessary functions for carrying out the post-processing

This issue can be closed when a PR adds the input files that model the GT-MHR unit cell to the repo.

PR #20 had a version of 'auxiliary.py' that had the wrong path of some figures and was missing one function.
This issue can be closed when a PR fixes these issues.

This issue can be closed when the necessary files to reproduce the results are added to the repo.
Those files should include:

• Moltres input files
• Geometry files
• .csv files necessary for obtaining plots and results
• Necessary functions for carrying out the post-processing

This issue can be closed when axial flux detectors have a larger volume (to achieve better statistics) and radial detectors are defined.

This issue can be closed when the README has been updated with information about the different models it contains.

The accuracy of the results from Moltres simulation depends on the chosen energy group structure for the group constants.
This issue can be closed when a PR includes the following files to the repo:

• .csv files with the results of the simulations
• python script to produce the cross-sections
• python script to produce the images with the results

I'm submitting a ...

• feature request

Expected Behavior

There should be a LICENSE file that covers the entire repository.

Actual Behavior

It looks like this repository is still being put together, but from the issues it appears that you're going to be developing code here. This is most aptly covered by BSD-3, unless this is a Moose, moltres, or squirrel derivative (which expressly requires some form of GPL or LGPL). There's a grey area around additions to these programs, where it doesn't have to be covered under some form of GPL or LGPL.

How can this issue be closed?

First, a determination has to be made about the type of License under which to cover this repository.
Second, that License should then be added through a pull request to this repository.

For your convenience, I've attempted to attach a BSD-3-Clause (which I believe will be the most appropriate for this repository, but I'm not entirely sure of).

BSD-3-Clause.zip

In the file postprocessing.py there are magic numbers in the TFCL and TCCL functions for the radial dimensions.
This may lead to future headaches because you changed one of the values but not the others.

This issue can be closed when the code "does not repeat" itself.

Examples:

data = {'R1': 1.24, 'R2': 0.02}


def TCCL(t, data=data):

    Rf = data['R1']
    Rc = data['R2']
    [...]

    return tcl

This issue can be closed when the full core model is capable of generating the cross-sections to use in Moltres.

The full-core model in Serpent is missing the python functions that:

• add legends to the model figure
• add location of the detectors to the model figure
• produce the results, including axial flux, radial flux, and radial power distribution

This issue can be closed when those functions are added to the repo.

This issue can be closed when a PR adds a serpent input file that describes the full core of the MHTGR-350.

Currently, there are multiple files in the repository called postprocessing.py and auxiliary.py. They have some different functions but serve the same role of processing data into plots and the needed helper functions.

This issue can be closed when there is a single file called auxiliary.py and postprocessing.py at the top level of the directory.

Why? Each of the sub-directories fuel-column, full-core, isotope-distribution, and problem-setup contain data that is easier to access from the top level of the directory than the other way around -- removing the need for pathmagic.py or sys.path.insert(). If, in the future, this repository is used to publish results, it will be easier for others to clone the repo and process the data if they don't have to edit the path variables first.

Auxiliary.py is missing a function that plots the location of the detectors on a full-core figure.
This issue can be closed when a PR adds that function to auxiliary.py

The MHTGR-350 uses TRISO particles embedded in a graphite compact. This issue can be closed when a model in serpent of such fuel compact is added to the repo.

The fuel column analysis is missing Moltres files.
This issue can be closed when a PR adds these files to the repo:

• input files: this includes input files for the cases with no burnable poison (noLBP), and with burnable poisons (LBP) at 600 and 1200K.
• .csv files with the results
• .geo with the fuel column geometry

Currently, several Python scripts in this repo don't have any associated tests.
This issue can be closed when tests are added to the repo.

Hi @robfairh . Is this repository still in use? I have been seeing MHTGR350 benchmark updates from you over the course of these 5 months, but it seems nothing is ending up in this repository. This can be closed when a pull request brings this repository up to date with current work.

The repo counts only with the post-processors for obtaining the figures for the fuel-column results from Serpent.
This issue can be closed when the post-processors for obtaining the figures of the results from Moltres is added to the repo.