arewm / designsec Goto Github PK

If we have a multi-select box, use jQuery to get the object we are acting on and dynamically create an add button/modal

At least the tooltips on delete modals, but probably others. Tooltips do not need to be on delete modals anyway.

When a stacked modal is hidden, the covered modal does not scroll

Do we want to provide this custom functionality for when a modal is closed/a modal operation is successful?

This will help to reduce effort. If a copied field needs to be unique, you can append with

(copy)

Some recommendations might be duplicated within the same classification since we are not enforcing a 1:1 relationship.

• Check to see if this is really an issue (does it happen anywhere, is there an easy way to prevent it?)
• If it does happen, make sure to select/deselect all instances of the recommendation when one is clicked.

When creating the delete modals, the multi-select boxes are not readonly. Does this really matter? Can we do anything about it?

We can delete the object regardless, so this is probably fine unless it will be confusing.

The editor shows up when deleting an object with pk=0.

These lists use the string representation of the models. We need to figure out a better representation.

At a minimum, we need to create admin users

Do we want to require authentication to view project recommendations?
Maybe we can provide it as an option for sensitive projects?

• Education and perspective
• Security architecture
• Auditing and compliance
• Incidence response
• Guidance for government certifications

Keep track of the number of views and the last view
Should we prevent logged-in admins from triggering view counts?

Admin users are the only people that should perform admin actions

Really, the most important thing is to preserve the page/order/sorting from before deletion. Is it possible to just remember the last sort view? (currently, it would have to be passed to Django)

We should be able to delete these rows without refreshing the page.

In the modal forms, when adding a new entry to a multi-select box, we do not reset the form when hiding the modal. This should be an easy fix.

We should be able to figure out some information from the context (i.e. parent from current context)

• category of a classification

modal_generator.js - we always reload on a successful response. This is likely not always what we want to do.

If there is more than one classification, present an error to be more specific and tailor it to one classification.

This is an imported todo. It may not need to be done, but check before closing. This was mostly for when we were displaying all of the categories that a recommendation belongs to. I do not think we want to do this anymore.

Click on the source button when in a modal. The HTML cannot be edited

This is currently not possible anywhere. Where is the best place to have it? We can certainly have it on the admin list page. We can also have the add button anywhere that we have to pick the contacts.

I do not know where we will put a delete button because we have no contact management page.

We are always returning a JSON message. Are we using this where we need to?

Sometimes, we also add a message to the request. Is this done everywhere we want it done? Do we want to do it at all?

All of these should be investigated. Complete if/when done

functionality:

• views.py: generate_recommendation_by_category
• views.py: generate_admin_recommendation_by_category
• views.py: generate_admin_project_view

documentation:

• views.py: save_recommendations
• views.py: get_admin_recommendation_by_category