aredotna / chrome-extension Goto Github PK

navigating to the URL of a hosted .pdf in which chrome renders the pdf directly, it would be nice to use the same method for saving. not 100% sure how to do this though, seems like chrome gives the pdf an html frame but have to look into this further.

errors out here

Anything else that should be addressed before pushing this to the Chrome Store?

Believe we want to replace removeNode with removeChild. Currently getting the following error:
document.body.removeNode is not a function
relevant lines here

When trying to sign in in the chome extension in Brave browser (https://brave.com/) I end up in a permanent loop of auth (ie being redirected to the login screen on signin).

Brave is a Chromium based browser so can run chome extensions...
same thing happening in the bookmarlet in case that's relevant.

Thanks for the great work on Are.na, it's a great product with huge potential 👌🏼

Edit: would be happy to make a PR if someone could point me in the right direction...
EditEdit: logs out error Unchecked runtime.lastError: The message port closed before a response was received.

i'm assuming that this is also the code for the firefox extension since it's a webextension.

when first installing this extension, you have to log in to are.na. this is done over an insecure http connection -- firefox even warns you of this when you focus on the password field.

Clicking the icon raises this error window in Chrome 65.0. Possibly an AdBlock conflict, not sure. Background console shows no network activity or log info.

github.com is an example

This may be tricky to handle since we start to get into page-specific security protocols. Maybe we can start dropping examples here so we can see what kind of edge cases we encounter. Improvements here may port over to the bookmarklet implementation as well depending on the fix.

Could be nice to have the option to add/edit the following:

• block title
• block description
• block comment?