ardoq / ardoq-csharp-client Goto Github PK

A bug was reported regarding these two functions, and it seems like they filter search results by different criteria!

GetAllTemplates filters by m.UseAsTemplate == true, while GetTemplateByName skips this check. Results in weird scenarios where you won't find templates when getting "all" templates, but still find templates when you add a name!

See:

This issue is mainly about identifying which of the two lines must be updated. An issue reported by a user suggests we may simply need to remove the UseAsTemplate-check from GetAllTemplates.

The Model.CreatedBy field is of type DateTime?. The API seemingly started returning an ID, which to me sounds more correct. However, it causes an exception when trying to deserialize this ID into a nullable DateTime.

Anyone up to the task, for updating the package?
.net 5
refil > v6 (Right now v 3.1)
Newtonsoft.json > v.13 or move to System.Text.Json (If going .net 5)
nunit > v.3.13 or move to xunit (Like MS and .net)

etc?

https://app.ardoq.com/api/workspace/search?name=Ardoq

Causes client to throw an exception when getting all fields. (when there is a SelectMultipleList among them)

The convenience function "GetTemplateByName" should be deprecated and phased out, as it sets false expectations for the data model.

There can be multiple models and templates with the same name, but this helper function only returns the first element or an exception. Should be changed to return a list!

Probably something we should do once global componentTypes and refTypes are out.

1075195061 [worker-3] WARN ardoq.api.crud-api - Bad request: ("Value "2015-01-04T19:40:24+01:00", at path [:last-updated], did not match predicate 'ardoq.utils.validation/date-time-pred'." "Value "2015-01-04T19:40:24+01:00", at path [:created], did not match predicate 'ardoq.utils.validation/date-time-pred'.")

Would be nice if you created a netstandard2.0 version of this client, to enable safe cross-platform use in .NET Core applications.