architector1324 / picocoin Goto Github PK

Hello,
I looked at your project because I wanted to learn about cryptocurrencies and thought that simple or starting projects are good way to learn. So as I am beginner I am not sure if those are really issues, so feel free to correct me.

First thing is that I noticed that you are talking about h_diff as byte, but in examples you are showing that it is half byte. In case that it is half byte, then your tables where you except 64 levels of h_diff are right (as 464=256). But in your code you are behaving like it is byte (864=512). (Two hex letters represent one byte.) So if I am not wrong, then I would probably recommend that you switch to SHA3-512.

Second thing I noticed is that you are claiming that it is hard to do factorization parallelly. But I think that it would be easy to split the search to equally sized ranges and distribute them between multiple cores or even computers, atleast for basic bruteforce algorithm. But I am not much familiar with all that math about primenumbers, so if there is some not so well parallelizable way, but very fast, then please send me some link about it.