arcctgx / lfmedit Goto Github PK

This would require getting old scrobble data from source other than Last.fm API. The most reasonable thing to do would be to require full diff as input data (not just the new scrobble data).

In its current form failed.log is not very useful, because it doesn't store the cause of failure. This should be a short status string like HTTPxxx, CASEONLY, NOCHANGE or BADAARTIST.

Sometimes HTTP status codes other than the ones being explicitly handled are reported, and they don't always mean edit failures. These should rather be logged as warnings to a dedicated file, warnings.log. These should also be printed to the console. WRN error severity should be reintroduced.

Finally, consider if attempts to edit scrobbles without reliable timestamps should be treated and logged as errors, or not.

Just got 36 false positives. Seems like the verification step doesn't really help, it only slows down the editing process.

It's not possible to keep auth_tokens.sh as a sample template where changes are tracked, and at the same time ignore it when real tokens are set.

Authentication tokens should be read from file placed in XDG_CONFIG_HOME. This repository should only contain a sample template file.

After making about 40-50 edits all subsequest requests fail with HTTP 406 error.

This looks like a case when the album field is set, but album artist field is not set on Last.fm side.

INF: applyChangesFrom(): editing scrobble 388 of 408
INF: requestScrobbleEdit(): This is the edit that will be applied:
-1291342475	[untitled]	William Basinski	Melancholia	
+1291342475	Melancholia VII	William Basinski	Melancholia	William Basinski
ERR: requestScrobbleEdit(): HTTP error 500: check edit parameters (wrong original album artist?)