Giter Club home page Giter Club logo

java-velocypack-module-scala's Issues

Option deserialization does not operate according to expectations

According to VPackScalaDeserializers :

  val OPTION = new VPackDeserializerParameterizedType[Option[Any]] {
    ...
    ...
    ...
    def deserialize(parent: VPackSlice, vpack: VPackSlice, context: VPackDeserializationContext, t: ParameterizedType): Option[Any] = {
      val value = context.deserialize(vpack, t.getActualTypeArguments()(0).asInstanceOf[Class[Any]])
      value match {
        case null => None
        case _    => Some(value)
      }
    }
  }

However, it seems null are ignored during deserialization, so this method never executes, resulting in null where None was expected

MapLike serialized incorrectly

Maps obtained by calling Map.mapValues(...) or Map.filterKeys(...) etc serialized as plain objects ({f: {}} and {p: {}} respectively)

StackOverflowError when serializing Scala enum 

object TestEnum extends Enumeration {
  type TestEnum = Value
  val Foo: TestEnum = Value("foo")
  val Bar: TestEnum = Value("bar")
}

new VPack.Builder()
  .registerModule(new VPackScalaModule)
  .build()
  .serialize(TestEnum.Foo)

produces

java.lang.StackOverflowError
	at java.util.ArrayList.grow(ArrayList.java:260)
	at java.util.ArrayList.ensureExplicitCapacity(ArrayList.java:241)
	at java.util.ArrayList.ensureCapacityInternal(ArrayList.java:233)
	at java.util.ArrayList.add(ArrayList.java:464)
	at com.arangodb.velocypack.VPackBuilder.reportAdd(VPackBuilder.java:872)
	at com.arangodb.velocypack.VPackBuilder.addInternal(VPackBuilder.java:647)
	at com.arangodb.velocypack.VPackBuilder.addInternal(VPackBuilder.java:632)
	at com.arangodb.velocypack.VPackBuilder.add(VPackBuilder.java:413)
	at com.arangodb.velocypack.internal.VPackSerializers$1.serialize(VPackSerializers.java:55)
	at com.arangodb.velocypack.internal.VPackSerializers$1.serialize(VPackSerializers.java:48)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:858)
	at com.arangodb.velocypack.VPack.serializeField(VPack.java:839)
	at com.arangodb.velocypack.VPack.serializeFields(VPack.java:816)
	at com.arangodb.velocypack.VPack.serializeObject(VPack.java:803)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:882)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:879)
	at com.arangodb.velocypack.VPack.serializeField(VPack.java:839)
	at com.arangodb.velocypack.VPack.serializeFields(VPack.java:816)
	at com.arangodb.velocypack.VPack.serializeObject(VPack.java:803)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:882)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:879)
	at com.arangodb.velocypack.VPack.serializeField(VPack.java:839)
	at com.arangodb.velocypack.VPack.serializeFields(VPack.java:816)
	at com.arangodb.velocypack.VPack.serializeObject(VPack.java:803)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:882)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:879)
	at com.arangodb.velocypack.VPack.serializeField(VPack.java:839)
	at com.arangodb.velocypack.VPack.serializeFields(VPack.java:816)
	at com.arangodb.velocypack.VPack.serializeObject(VPack.java:803)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:882)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:879)
	at com.arangodb.velocypack.VPack.serializeField(VPack.java:839)
	at com.arangodb.velocypack.VPack.serializeFields(VPack.java:816)
	at com.arangodb.velocypack.VPack.serializeObject(VPack.java:803)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:882)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:879)
	at com.arangodb.velocypack.VPack.serializeField(VPack.java:839)
	at com.arangodb.velocypack.VPack.serializeFields(VPack.java:816)
	at com.arangodb.velocypack.VPack.serializeObject(VPack.java:803)
	at com.arangodb.velocypack.VPack.addValue(VPack.java:882)
        ...

Scala maps support

Currently velocypack-module-scala only supports immutable Map up to the size of 4.
Basically only the types EmptyMap, Map1, Map2, Map3 and Map4 are serialized correctly.
Other maps (e.g. HashMap, TrieMap, TreeMap, ListMap etc) aren't supported.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.