aragajaga / panitent Goto Github PK

The following accessibility issue needs investigation.

App: panitent

Element path: поле со списком 'Preset'

Issue Details: The given element is expected to have the following structure: ComboBox and CountChildren(Button) == 1 and CountChildren(Edit) <= 1 and CountChildren(List) <= 1 and AllChildren(not(IsControlElement) or (Button or Edit or List)). WCAG 1.3.1

How To Fix: The given element is expected to have the following structure: ComboBox and CountChildren(Button) == 1 and CountChildren(Edit) <= 1 and CountChildren(List) <= 1 and AllChildren(not(IsControlElement) or (Button or Edit or List)).

This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.

In WinAPI, there is already a function called InflateRect for resizing a RECT.

Incorrect type cast in the 4th argument. Expected WPARAM.

hello.

https://github.com/Aragajaga/panitent/blob/70b1018278a1967ba97524f8cc7299ff550682fa/src/smartptr.h#L4-L7
i think it'd be better to create concrete structure or pointer-to-structure for smart pointer.
especially since you create a concrete structure in the implementation anyway:
https://github.com/Aragajaga/panitent/blob/70b1018278a1967ba97524f8cc7299ff550682fa/src/smartptr.c#L4-L8

2. name smartptr doesn't reflect the smartness of the pointer.
   since you implemented reference counter pointer, you can name it refcnt_ptr. what is much clearer than just smart_ptr.