Giter Club home page Giter Club logo

design-system's People

Contributors

akash-codemonk avatar albinappsmith avatar ankitakinger avatar aswathkk avatar ayushpahwa avatar berzerkeer avatar chandanbalajibp avatar dependabot[bot] avatar dhruvikn avatar eco-monk avatar github-actions[bot] avatar hetunandu avatar iamakulov avatar iamanubhavsaini avatar keyurparalkar avatar marks0351 avatar mohanarpit avatar nilanshbansal avatar parthvi12 avatar prsidhu avatar ravikp7 avatar rimildeyjsr avatar rohitagarwal88 avatar sbalaji1192 avatar sharat87 avatar tanvibhakta avatar vaibhavchobisa avatar vasanthappsmith avatar yaldram avatar yatinappsmith avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

design-system's Issues

[Bug]: ADS is applying styles on blueprint icon globally

Is there an existing issue for this?

  • I have searched the existing issues

Description

cleanshot_2023-07-07_at_13 01 48

Steps To Reproduce

I found it when I was making a new Wds button widget v2. I had to add custom css to override the styles but ideally the use of important in css should be avoided.

Public Sample App

No response

Version

1.9.26

[Bug]: Multi-select component is not very intuitive by the UI

Is there an existing issue for this?

  • I have searched the existing issues

Description

Multi-select component is not very intuitive by the UI. The options selected and the hover state have very minimal differentiation. Neither do we have checkboxes alongside options, like we did in the old DS component implementation. We could also think of adding a check or cross icon to the options that are selected:
Ref: https://demo.mobiscroll.com/select/multiple-select

Steps To Reproduce

  1. Go to Multi-select component on storybook
  2. Notice when you open the dropdown its not intuitive that its a multi-select dropdown till you actually interact with the dropdown
  3. On the other hand, once you select options, notice that the selected option bg color and the hover state of any option is not much distinctive.

Public Sample App

No response

Version

Self Hosted - latest

[Task]: Remove react-dnd from the codebase

Is there an existing issue for this?

  • I have searched the existing issues

SubTasks

We have multiple drag and drop libraries in the package.json file in the main codebase. react-dnd is actually no longer necessary in the main codebase, so I was hoping to remove this throughout our codebases.

There are 3 other alternatives which we can consider

  • react-beautiful-dnd (included in the main codebase)
  • react-use-gesture (can be upgraded to @use-gesture/react)
  • uppy (this is probably lazy loaded for the filepicker widget, and may not be one of the options)

Spacing Token - Enhancement

POD Level designs are undertaken by individual designers and reviewed., There appears to be no requirement for new container variants. However, our focus lies in contemplating potential enhancements to the design spacing. Designs are here

As the next step, a Notion document has been prepared to explain the structure of spacing tokens and the various controls available for improving the spacing between elements. The Notion document outlining the spacing review can be found here.

[Bug]: SearchInput not updating if parent's data changes more than once

Is there an existing issue for this?

  • I have searched the existing issues

Description

This came up when I was working on ticket, where we want filters and search input to clear on landing the templates page again after the first time.

This is occurring because, the SearchInput is not rendering again in :
https://github.com/appsmithorg/design-system/blob/release/packages/design-system/src/SearchInput/SearchInput.tsx

And can be fixed by adding this to SearchInput:

useEffect(() => {
      setValue(props.value || "");
    }, [props.value]);

Not sure if this is the case with other types of inputs as well

Steps To Reproduce

I noticed that was not picking values from props once it got rendered. Flow on my UI was like this:

  1. I went to /templates page, entered a search query
  2. From the filtered list of templates clicked on one of them, reached template detail page.
  3. from here I click back(& expect the RESET_TEMPLATE_FILTER action to run on mount)
  4. It does, but just before that, store already had previously entered search query
    a. with this value the input rendered itself
    b. after my action ran, it emptied the query from store
    c. but input did not clear it

Public Sample App

No response

Version

Appsmith v1.9.22-SNAPSHOT

[Epic]: Migrate existing design system component

Objective

Migrate existing design system components from appsmith & appsmith-ee

Success Metrics

Goal Metric
Migrate design system component appsmith & appsmith-ee should work as working before migration

Requirements

Requirement User Story
Migrate components All design system components to be migrated to design-system repo & change it import in appsmith & appsmith-ee
Enable tree-shaking the components that are consumed by consumers ie appsmith & appsmith-ee should have js/css/html of consumed components only
Storybook integration All engineers should be able to refer to component documentation on storybook
Merge duplicate component Same component having multiple occurrence should be merged into single component without changing the API or impacting the components/container where it is used

Documentation

Assumptions

  • ADS should work for Appsmith only, not supporting any developer outside Appsmith for a year.
  • Release in chunks ie one component at a time.
  • All duplicate components will be merged into a single component

Checklist/Process for releasing migrated component

  1. Notify in #tech-team, #general, and #design system channel, when the component is picked for migration for the week.
  2. Add label Design System Pod
  3. Create branch name: feature/migrate-{component-name} in both design-system, appsmith & appsmith-ee repo.
  4. PR title → Feature: Migration {component name} in both design-system appsmith & appsmith-ee repo.
  5. Check migrated components are working appsmith & appsmith-ee
  6. Github repo locally before releasing the design-system NPM version.
  7. Create a storybook for component
  8. QA sign-off in design-system Github repo.
  9. Create release notes in design-system Github repo
  10. Release the new NPM version.
  11. Update the design-system npm version in appsmith & appsmith-ee Github repo in feature/migrate-{component-name} branch
  12. Change migrated component import in appsmith & appsmith-ee repo.
  13. Remove migrated component code from appsmith & appsmith-ee repo.
  14. Raise PR & create DP for review in appsmith & appsmith-ee repo.
  15. QA sign off

List of all components in existing design system

Out of Scope

  • Community user support
  • Extending any component functionality
  • Fixing any known issue present in appsmith & appsmith-ee repo.

Developer Handoff Document in Figma

No response

RACI matrix

| ------------- | ------------- |
| Responsible | @albinAppsmith |
| Accountable | @albinAppsmith |
| Consulted | @rohitagarwal88, @jsartisan , @keyurparalkar , @yaldram |
| Informed | @rohitagarwal88 |

Spacing Guideline

To create an extensive guideline for the designers on how to use the Container component with examples.

[Task]: Basic setup for Design System repository

Is there an existing issue for this?

  • I have searched the existing issues

SubTasks

  • Rollup set up
  • NPM packaging set up
  • ESlint configurations
  • Yarn workspace configuration
  • Babel configurations
  • NPM account set up

[Feature]: Component builder for designers and developers

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Hi,

I saw one of the feature that appsmith is that it lacks tooling to build components (A design system builder part of appsmith). I wanted to share a demo how it can be done, however I'm not able to find directions for frontend build. could you please direct me.

Alternatively I think isolating frontend from the backend will allow for more collaboration from contributors. For local development it is not necessary that appsmith needs backend, its a UI tool, use client side for persistence.

Why should this be worked on?

Appsmith has a good grip since it already has user base and developers use it. In the road map or the final place the vision could be is in the direction of design to code. There are huge solutions available for design to code, but most of them lacks the code readability of the generated content from the designs, very hard to grasp.
An alternative approach is to build a lite version of design tool, with code generation based on component architecture. A catch is that, component philosophy mentioned here scales to generate code targeting any framework that supports component based development.

Targeted user base - Designers, frontend developers

[EPIC] Typography Updates & Guidelines

Objectives

  • Make typography consistent across the app using semantic tokens
  • Make it easier for designers and developer to pick the right type styles
  • Reduce the overall font size of the app to make better use of available screen space

[Bug]: TreeDropdown component doesn't support dynamic options

Is there an existing issue for this?

  • I have searched the existing issues

Description

If we change the options passed to the TreeDropdown, the updated options are not getting reflected in the component.

Steps To Reproduce

  1. Pass the options prop, and try to update it using another state.
  2. The changes won't get reflected.

Public Sample App

No response

Version

1.8.16

Complimentry Colors

Scope:
Colours - Audit and update semantic Tokens for the complimentary colours.

Primary: Orange aka Premium
Warning: Yellow
Information: Blue
Success: Green
Purple: Special

We need to decide if we should use a different shade of orange for our premium brand and keep it separate from the regular brand.

Update the Token Studio with new colors and make sure all other components dependent on these colors are also updated. This includes callouts, toast, input errors, and button, Link "Primary".

[Feature]: Json viewer component

Is there an existing issue for this?

  • I have searched the existing issues

Summary

image

Scope out places where this is being already used and consider all use cases.
Add required style configurations

Why should this be worked on?

We're working on Peek overlay for appsmith entities.
And we want to use this component there.

[Task]: Update Dependencies, remove resolutions if possible

Is there an existing issue for this?

  • I have searched the existing issues

SubTasks

  • Update storybook to the latest version.
  • Update rollup to the latest version.
  • Update the rollup plugins to the latest version.
  • Update other build dependencies to the latest version.
  • Remove all the resolutions if possible.

[Bug]: Button widget issues (design-system-old)

Is there an existing issue for this?

  • I have searched the existing issues

Description

  • disabled state doesn't prevent click
  • disabled state shows cursor pointer for some areas of the button
  • height and width property accept size in different format ("100", "100px")

Steps To Reproduce

Get started page issue
appsmithorg/appsmith#13093

For now, we've added temporary fix. (only to prevent click event)
appsmithorg/appsmith#21183

Public Sample App

No response

Version

Cloud

Specify app exploration

To see if the process can be simplified by a specify app.
Book a demo with the team to know more about the process

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.