app-generator / ecommerce-fastapi-stripe Goto Github PK

Hello @barreraalexander

On the products index page, the links provided by the featured product are dead links

Note: Please mirror all features from Flask. In theory, if the user starts the Flask or FastAPI version using Docker, the behaviour should be identical.

Ty for taking a look.

The index of products should use a route with / at the end.

@router.get("/products", status_code=status.HTTP_200_OK) 
 ...

Hello @barreraalexander

All env variables are optional with defaults:

• Debug = True
• SECRET_KEY = random 16 chars
• Stripe secrets = None (Null)
• SERVER_HOST - localhost:8000 (default uvicorn PORT)

Also, when the stripe secrets are not provided the UI shows the product but informs the user using an alert.

Flask version has all these evolutions

Hello @barreraalexander,

Regarding Docker, two files are provided:

• docker-compose.yaml -> OK
• docker-compose copy.yaml -> Not ok

Please rename the 2nd docker-compose YAML with a suggestive name.
Also might help to specify on README what exactly does compared to the simple set up.

Ty!

Hello @barreraalexander

Please document the set up flow for OAuth Stripe using this document.

• docs

Just the minimal steps and please specify also the required configuration on the Stripe platform.

Ty!

Hello @barreraalexander

The Stripe Flow is not implemented.
The following routes are required in order to have an usable product:

• /config - this should return the Stripe PUBLIC_KEY
• /success this endpoint is hit when the payment is successful
• /cancelled - callback route for rejected payments
• /create-checkout-session/<path>/ handles the payment flow

Please start the Flask sample using the following test keys for Stripe:

STRIPE_PUBLISHABLE_KEY=pk_test_51HlWtGGLLd1X07VUPujufXrN8JHjn76lzLOZ16zjo895ffZCC4JwcAAipINEC0CVFxjFGmHr1YxRf96JbhPiUeVU00uhxqX2uL
STRIPE_SECRET_KEY=sk_test_51HlWtGGLLd1X07VUIwU3iPZAK9mGdR8GtwSUAAkkyoOl3KpE4BWyIU3BX4mAcofaRrTFQIh4jFPSJHHk1njpwKMC00q3tPjAe7

Let me know if you have questions.

Ty!

hello @barreraalexander

All pages linked in the navigation bar should work.

Please take a look. Ty!

Hello @barreraalexander

On a fresh clone, the docker-compose up --build command is not successful:

The Docker setup should copy env.sample -> ENV or set the secrets in ENV

Note: take a look at the Flask version

Ty!

$ docker-compose up --build 

ERROR: Couldn't find env file: D:\work\repo-samples\sample-fastapi-stripe\.env

Hello @barreraalexander

The /products index shows the featured product but the rest of the cards are missing:

Please take a look. For quick comparison exec the Flask sample in Docker:

$ docker-compose up --build -> http://localhost:5085

FastAPI Layout

Flask Layout