apipie / apypie Goto Github PK

See scan.coverity.com

I think this could be done with a fixture:

@pytest.fixture
def temporary_environ():
  old_environ = os.environ.copy()
  yield
  os.environ = old_environ

Then on the test:

@pytest.mark.usefixtures("temporary_environ")
def test_init_with_existing_cachedir(fixture_dir, requests_mock, tmpdir):

I think you can even stack it:

@pytest.fixture
def temporary_xdg_cache_home(tmpdir):
    old_environ = os.environ.copy()
    os.environ['XDG_CACHE_HOME'] = tmpdir.strpath
    yield
    os.environ = old_environ

_Originally posted by @ekohl in #58

Include license file for those, who consume the release from PyPI.
apypie dependencies do it:

$ find ~/.virtualenvs/apypie/ -type f -name "*LICENSE*" 
/home/ogajduse/.virtualenvs/apypie/lib/python3.7/site-packages/wheel-0.34.2.dist-info/LICENSE.txt
/home/ogajduse/.virtualenvs/apypie/lib/python3.7/site-packages/setuptools-46.1.3.dist-info/LICENSE
/home/ogajduse/.virtualenvs/apypie/lib/python3.7/site-packages/urllib3-1.25.8.dist-info/LICENSE.txt
/home/ogajduse/.virtualenvs/apypie/lib/python3.7/site-packages/pip-20.0.2.dist-info/LICENSE.txt
/home/ogajduse/.virtualenvs/apypie/lib/python3.7/site-packages/certifi-2020.4.5.dist-info/LICENSE
/home/ogajduse/.virtualenvs/apypie/lib/python3.7/site-packages/idna-2.9.dist-info/LICENSE.rst
/home/ogajduse/.virtualenvs/apypie/lib/python3.7/site-packages/requests-2.23.0.dist-info/LICENSE

e.g. when the user tries to access an undefined resource, we only throw a KeyError, we could add a message saying "foo not found, you can only use bar and bax".

see theforeman/foreman-ansible-modules#261

Let's expose the validations so we can use them in Ansible. One problem is that the validator field just contains a human description, we could parse it, but it would be nice if we didn't have to.

See more at theforeman/foreman-ansible-modules#296 (comment)

We currently ignore the hash, thats good for FAM tests, but means we never notice if the file changes on the server

this should save a bit of traffic in requests.

FAM will need to use VCR with decode_compressed_response to have the tapes uncompressed and readable

We should set the user agent header

Since move to GH it's not properly updated anymore