Giter Club home page Giter Club logo

goiban-service's People

Contributors

cgrieger avatar fourcube avatar jaltek avatar jeffreyvdb avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

goiban-service's Issues

Run service as a non-root user in Docker

Currently the service runs as root. I'm currently packaging OpenIBAN as a Helm chart at https://github.com/helm/charts . I could tighten security on the package a lot if i could disallow running as root by means of a PodSecurityPolicy. This is not possible yet for OpenIBAN. I'm unsure wether this project is still maintained, but rest assured that it's still very much in use, so although the service has been shut down, it would be said to see this project die completely. Could a user be added to the Docker image, and started as that user?

Inconsistent BIC format

A Belgian BIC comes out as: 'KRED BE BB', while Dutch BICs look like: 'RABONL2U'.
AFAIK, a BIC shouldn't include spaces.

Replace -p with -port on start-page

Hello.

You tell people that they should start the stand-alone-binary with -p 8080 but your binary says that it should be -port 8080.

Sincerely,
DaB.

P.S: Quite a shame that you stopped your webpage :-(

Update BIC Database

Good afternoon,

Could you please update your BIC database? The BIC 'BUNQDE82XXX' is currently not present, and therefor IBAN's belonging to this BIC are marked as 'invalid' when validating it via your service.

certificate chain issue in firefox for openiban.com

openiban.com is secured by an SSL/TLS certificate. This certificate has an incomplete certification chain. This lets firefox popup a certification warning and you have to manually add an exception. Chrome handles this issue just fine.
Another problem: When doing JavaScript CORS to openiban.com firefox refuses to connect due to the certificate error.

Tested with firefox 41.0.2

privacy concerns

  • You write:
Private
No data is stored. No request logs are written. Everything works in memory.

But in the same way you provide statistics... I think this can't work...

  • And you write:
Secure
You can use the HTTPS version of this service.

Don't you want to automatically redirect HTTP to HTTPS?

Missing CORS header in response

Hi,

Unable to validate IBAN through an AJAX query. Missing header : Access-Control-Allow-Origin

Blocage d’une requête multiorigines (Cross-Origin Request) : la politique « Same Origin » ne permet pas de consulter la ressource distante située sur https://openiban.com/validate/BE30063934505311?validateBankCode=false&getBIC=true. Raison : l’en-tête CORS « Access-Control-Allow-Origin » est manquant.

Response header (260 o) |  

Date | Thu, 25 Jan 2018 11:58:34 GMT
Front-End-Https | on
Vary | Origin, Access-Control-Request…ccess-Control-Request-Headers

Having to manually accept the certificate

Hi,

I just switched to try and use the https connection for openiban, but I'm getting this error:

javax.net.ssl.SSLHandshakeException: sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

Does this mean that I'll have to manually add the openiban certificate to the list of trusted certs? Or am I missing something else?

IBAN rule exception for the Commerzbank is not implemented

Hi,

according to the IBAN ruleset from the German Bundesbank there is an exception regarding the IBAN validation for IBANs from the Commerzbank. In this case goiban has to return the BIC "COBADEFFXXX" instead of "COBADEHHXXX" for example.

References:

https://www.willuhn.de/bugzilla/show_bug.cgi?id=1709
https://www.bankleitzahlen.ws/20040000

The ruleset itself is only avaible in the Extranet from the German Bundesbank (or Google for "iban regeln" :))

IBAN Calculation

Do you still want to implement the IBAN calculation out of "Bankleihzahl"? I think this would be usefull, even if BLZs will be obsolete soon ™️

Nice way to start the service on reboot

Hey,

is there already a nice way to start the service on reboot or do you just do a crontab

@reboot /path/to/goiban/goiban-service -dataPath ./data -staticPath ./static -port 8080 -w

Andi

IT IBAN false positive

Hi thanks for the great work!

I have a false positive for the IT IBAN IT96370400440532013000: open Iban get this response
{
"valid": true,
"messages": [],
"iban": "IT96370400440532013000",
"bankData": {
"bankCode": "",
"name": ""
},
"checkResults": {}
}
but the code isn't valid because Italy IBAN must have a length of 27 chars.

Ciao.

Create Iban: Issue creating check code

Hello,

if checkcode less then ten, the leading zero digit will be lost in the calculated result.
e.g.: IBAN: DE 03 BANKCODE
Calculater result: DE3BANKCODE

Best regards

HTTP 204 No Content

Hi,

I have a problem when I'm calling OpenIBAN from my server.

$.ajax Query, no method specified (API default is GET) :

https://openiban.com/validate/BExxxxxxxxxxxxxx?validateBankCode=false&getBIC=true

Request

Host: openiban.com
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0
Accept: /
Accept-Language: fr,fr-FR;q=0.8,en-US;q=0.5,en;q=0.3
Accept-Encoding: gzip, deflate, br
Access-Control-Request-Method: GET
Access-Control-Request-Headers: jquery_context,jquery_request
Referer: https://my-server.be:9443/portail/MPER/bourse.do?tkRfhId=1575963241630jqX09
Origin: https://my-server.be:9443
Connection: keep-alive

Response

HTTP/2.0 204 No Content
date: Tue, 10 Dec 2019 08:35:05 GMT
set-cookie: __cfduid=d9e24e54fa11de99346a207b4d29ed16b1575966905; expires=Thu, 09-Jan-20 08:35:05 GMT; path=/; domain=.openiban.com; HttpOnly
access-control-allow-methods: GET, POST, OPTIONS
access-control-max-age: 1728000
access-control-allow-origin: *
cf-cache-status: DYNAMIC
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
server: cloudflare
cf-ray: 542de228efa9bdd7-AMS
X-Firefox-Spdy: h2

Thanks

Create Iban: leading zeros on account numbers

Hello,

the REST Service Accepts German Account Numbers with less then ten digits. It would be nice to enlarge the account number with leading zeros.

Alternative return valid:false

Best regards

Support for multiple BICs for a single IBAN

Sometimes, the webservice returns the wrong BIC-code for accounts of the Deutsche Bank.

See, the following case for example: http://www.ibancalculator.com/validate/NL42DEUT0466964617

BIC: please check which one of these BICs is the correct one:
------
§  found in directory: DEUTNL2A   BIC into the clipboard
§  found in directory: DEUTNL2N

With the OpenIBAN-service, only one (DEUTNL2A) is returned, while in this case DEUTNL2N is the right one.

Can you please fix this by returning 2 BIC codes? We have contacted the Deutsche Bank and, unfortunately, human interaction is needed to pick the right one. (They have to look at the account statement to assess which BIC is correct.)

Feature Request: Listen only on localhost

Hi,

just a small FR: It would be nice if the service gets an option for only listening on localhost (127.0.0.1:8080) instead of listening on all available interfaces by default.

Cheers,
Jan

go build seems to fail

Hi,

I'm getting the following "issue" when trying to go build the service:

$ go build
# github.com/armon/go-metrics
../../armon/go-metrics/inmem_endpoint.go:72: undefined: sort.Slice
../../armon/go-metrics/inmem_endpoint.go:86: undefined: sort.Slice
../../armon/go-metrics/inmem_endpoint.go:113: undefined: sort.Slice
$ echo $?
2

(Exit code 2)
Maybe an upstream issue?

$ go version
go version go1.6.2 linux/amd64

Update BIC Malta

Hi,

Could you please update your BIC database for Malta IBAN ?

this is what i got as message (validate : Malta IBAN)

"messages": [
"Cannot validate bank code length. No information available.",
"Cannot get BIC. No information available."
],

Regards

Update IBAN

Hi, could you update the rule of IBAN verification for Costa Rica (CR)?
What I use is an IBAN with 22 characters (which is verified), but got this:
"valid": false,
"messages": [
"Cannot parse as IBAN: IBAN length invalid. Expected length for CR is 21."

How to get this service supporting more countries?

Congrats to this service; it's just damn useful and using is a piece of cake!

Just wondering, if it will be extended to provide further information about IBAN's of other countries?
Basically I just want to retrieve the bank name of an IBAN number - ideally for every country.
But to start with, Switzerland would do it ;)

What do you need in order to extend the database to support additional countries and banking institutes?

Provide actual version as Docker tag

Only 'lastest' is available on Docker hub. Could it be possible to provide an actual version as well? It's for the Helm chart that's upcoming.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.