apexad / node-aladdin-connect-garage-door Goto Github PK

request is deprecated

Currently it is assumed that the supplied username and password is the 'main'/master account user.

Shared users has been un-tested and I believe will not currently work. This is something that I would like to fix for the sake of security.

ISC!? Let's go MIT!

I know the App is able to report that there is an obstruction preventing the garage door from being closed. Need to investigate further on how to get this value from the API.

My guess is the fault value or a different state number for door_status (maybe 7).

Hi, I work for Overhead Door Corporation, which owns Genie (Aladdin Connect). Your current implementation issues a login request for every API call, which is causing a very large number of active sessions for users of HomeBridge. We follow the OAuth2.0 specification, and the access token you receive is valid for 24 hours.

As a quick fix for this, could you do the following?

1. Cache the access token somehow and use it until it expires
2. When it expires, logout by sending a POST request to https://app.apps.st1.gdocntl.net/api/v1/session/logout with the Authorization header set to the bearer token (e.g. "Authorization": "Bearer 12345")

At the very least, could you issue the logout request after every API request? This way we will not end up with so many orphaned user sessions.

getStatus function should take an array of objects with device and door numbers and return status for all doors

Can you offer any insight? I'd gladly pay to get this plugin working for me, it's the last piece of my homebridge puzzle. See below for error in terminal.

[6/25/2019, 11:17:09 AM] [Garage Door] Error: Command failed: node C:/Users/Chambers/AppData/Roaming/npm/node_modules/garage-control/state.js
C:\Users\Chambers\AppData\Roaming\npm\node_modules\node-aladdin-connect-garage-door-master\example\node_modules\node-aladdin-connect-garage-door\index.js:36
modules.export = (user, password, action, callback, deviceNumber = 0, doorNumber = 1) {
^

SyntaxError: Unexpected token {
at Module._compile (internal/modules/cjs/loader.js:718:23)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)
at Module.load (internal/modules/cjs/loader.js:641:32)
at Function.Module._load (internal/modules/cjs/loader.js:556:12)
at Module.require (internal/modules/cjs/loader.js:681:19)
at require (internal/modules/cjs/helpers.js:16:16)
at Object. (C:\Users\Chambers\AppData\Roaming\npm\node_modules\node-aladdin-connect-garage-door-master\example\state.js:1:25)
at Module._compile (internal/modules/cjs/loader.js:774:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:785:10)
at Module.load (internal/modules/cjs/loader.js:641:32)

at ChildProcess.exithandler (child_process.js:290:12)
at ChildProcess.emit (events.js:200:13)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5) {

killed: false,
code: 1,
signal: null,
cmd: 'node ' +
'C:/Users/Chambers/AppData/Roaming/npm/node_modules/garage-control/state.js'
}

Will return NaN in current code if it is not available (meaning it is a garage door with Aladdin built in not using a tilt sensor)

Do you have any instructions on how/where I implement this code/package to work with the garagedoor-command plugin? Didn't see any install instructions.

A get doors request will return all available doors rather than the user having to be aware of which devices/doors exist

Hey there! Thanks for getting this module going, may be something I'd be looking to use. ✨

Right now I'd say a few things could probably use a bit of cleaning up (param signature in the main function, errbacks, async support, etc.), I'm wondering how amenable you are to PRs? (Especially the variety that introduce breaking changes?)

Thanks!

The API has to return this information, so it should be added as something to fetch via this script.