Giter Club home page Giter Club logo

Comments (1)

dosubot avatar dosubot commented on June 29, 2024 2

Hey @jensrotne! I'm here to help you with any issues, bugs, or questions you have about the project. I can also assist you in becoming a contributor. Let me know how I can assist you!

To address the issue of allowing a PUT request with an empty Id field in the PUT /api/plugins/circleci/{connection_id}/scopes endpoint, you can add a validation check in the PutScopes function. Here is an example of how you can modify the PutScopes function to include this validation:

func PutScopes(input *plugin.ApiResourceInput) (*plugin.ApiResourceOutput, errors.Error) {
    var reqBody PutScopesReqBody
    if err := json.Unmarshal(input.Body, &reqBody); err != nil {
        return nil, errors.BadInput.Wrap(err, "failed to parse request body")
    }

    // Check if the Id field is empty
    for _, project := range reqBody.Projects {
        if project.Id == "" {
            return nil, errors.BadInput.New("Id field cannot be empty")
        }
    }

    return dsHelper.ScopeApi.PutMultiple(input)
}

In this code snippet, the PutScopes function first unmarshals the request body into a PutScopesReqBody struct. It then iterates over the projects in the request body and checks if the Id field is empty. If any Id field is found to be empty, it returns a BadInput error with a message indicating that the Id field cannot be empty [1][2][3].

Additionally, you can extend the existing unit tests to cover this new validation logic. Here is an example of how you can modify the test to include a case where the Id field is empty:

func TestScopeApiHelper_Put(t *testing.T) {
	apiHelper := createMockScopeHelper[TestFakeGithubRepo]("GithubId")
	// create a mock input, scopes, and connection
	input := &plugin.ApiResourceInput{Params: map[string]string{"connectionId": "123"}, Body: map[string]interface{}{
		"data": []map[string]interface{}{
			{
				"HTMLUrl":       "string",
				"githubId":      1,
				"cloneUrl":      "string",
				"connectionId":  1,
				"createdAt":     "string",
				"createdDate":   "string",
				"description":   "string",
				"language":      "string",
				"name":          "string",
				"owner":         "string",
				"scopeConfigId": 0,
				"updatedAt":     "string",
				"updatedDate":   "string",
			},
			{
				"HTMLUrl":       "11",
				"githubId":      2,
				"cloneUrl":      "string",
				"connectionId":  1,
				"createdAt":     "string",
				"createdDate":   "string",
				"description":   "string",
				"language":      "string",
				"name":          "string",
				"owner":         "string",
				"scopeConfigId": 0,
				"updatedAt":     "string",
				"updatedDate":   "string",
			},
			{
				"HTMLUrl":       "string",
				"githubId":      "", // Invalid Id
				"cloneUrl":      "string",
				"connectionId":  1,
				"createdAt":     "string",
				"createdDate":   "string",
				"description":   "string",
				"language":      "string",
				"name":          "string",
				"owner":         "string",
				"scopeConfigId": 0,
				"updatedAt":     "string",
				"updatedDate":   "string",
			}}}}
	// test a successful call to Put
	_, err := apiHelper.Put(input)
	assert.NoError(t, err)

	// test a call to Put with invalid Id
	input.Body["data"].([]map[string]interface{})[2]["githubId"] = ""
	_, err = apiHelper.Put(input)
	assert.Error(t, err)
}

This modification adds a new test case where the githubId is set to an empty string, which should trigger the validation logic for empty Id fields and result in an error [4].

To continue talking to Dosu, mention @dosu.

from incubator-devlake.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.