apache / cordova-mobile-spec Goto Github PK

Apache Cordova mobile-spec

License: Apache License 2.0

Java 5.33% Objective-C 1.52% JavaScript 59.37% C++ 1.43% Batchfile 0.49% Shell 0.50% HTML 29.15% CSS 2.21%

cordova csharp cplusplus library objective-c java nodejs javascript mobile

cordova-mobile-spec's Introduction

Cordova Mobile Spec Suite

This cordova-mobile-spec repository can be used to create a Cordova app that provides a set of manual tests to verify Cordova core functionality. It is currently used in the release processes of platforms, plugins and tools.

It also provides access to manual and automated tests of the installed plugins (via cordova-plugin-test-framework).

(History: A very long time ago this repository also included all the manual and automated plugin tests before those were extracted and moved into the plugins themselves.)

Overview

This repository has 3 parts:

This main folder is a Cordova app "template" (config.xml and www) that includes implementations of various functionalities that Cordova supports (battery, events, keyboard, lazyloadjs, splashscreens, sql, storage, misc) that can manually be tested, some benchmarks, and a link to the automated and manual tests installed plugins offer (cdvtests/index.html).
There are 4 plugins as well: cordova-plugin-echo ("plugin implementation of the Echo function to test the bridge"), cordova-plugin-mobilespec-tests ("Cordova Non Plugin Auto Tests"), cordova-plugin-thirdparty-tests ("Tests for popular third-party plugins") and cordova-plugin-whitelist (TODO).
The createmobilespec folder contains a script/CLI to create a Cordova app
1. using the locally installed Cordova CLI, the currently up to date (published on npm) platforms and plugins (including their tests!), and the 4 local plugins from 2) (mode --global) or
2. using local checkouts (via cordova-coho) of all these (CLI, tools, platforms, plugins...) or
3. with several other modes (to e.g. use plugman and /bin/create instead of the CLI)

The end result is a folder ../mobilespec with a Cordova app that can be installed on devices. It can be used for some manual testing with the functionality offered by 1) or run the tests additionally provided by the plugins via cordova-plugin-test-framework.

Usage

See the README.md in /createmobilespec for usage instruction on how to create the "mobilespec" app.

Cordova Plugin File-Transfer Tests

Tests of Cordova Plugin File-Transfer require a test server. Follow these instructions to install and run the server and configure the plugin.

cordova-mobile-spec's People

Contributors

Stargazers

Watchers

Forkers

cmarcelk becka11y mwoghiren deancs mbillau bownux bennmapes lholmquist jamesjong charbs09 wildabeast devgeeks jeffheifetz spideroak monaca jonasaa85 clelland dumparun rixrix awogit ejzn blackberry josher19 ganinaleksei pdstefan ldeluca csantanapr automationconsultant einstein-github mobilipia jbondc cesine shingotoda alaatek touchit sgrebnov onlinesen abdamawi2009 vincerafale muthhus ibratoev majornista martincgg 007slm jsoref lmnbeyond stacic hazems jonasei kuguobing purplecabbage bdacode puneetgkaur jpuerto icenium softroots feedhenry eymorale corimf zaspire ollie314 dilipdmnmighty fujunwei ktop theelrood justadropofwater agrieve adityaputra tonyliudalian sunmoon321 peterbastian raventrouble jsoncaizh modulexcite fth-ship selimg lelou13 pkdevboxy tripodsan novice79 srcclrapache1 infil00p filmaj vzeeroo halton audreyso fuse-mars brodybits erisu breautek cordova-develop gedasga sreenivasarajiv riahtu fb64 streammaine xirdigh hixio-mh isabella232 codeunit12

cordova-mobile-spec's Issues

Investigate cordova-plugin-whitelist

Why same name as normal plugin cordova-plugin-whitelist?
Where is this actually used and why?

createmobilespec.js should check if folder it will create the app already exists and quit

Right now the user has to check if the directory where the script will create the app is empty, otherwise the script can have unexpected behavior. It would be much better if the script could just output something like "Folder mobilespec already exists and contains files. Please remove them before creating a new mobilespec project."

mobile-spec project creation fails with error "Cannot find module 'cordova-common'"

mobile-spec project creation fails with the error "Error: Cannot find module 'cordova-common'" when trying to execute the command - "node ./cordova-mobile-spec/createmobilespec/createmobilespec.js --android --forceplugins"

If I try adding cordova-common module in mobile-spec project manually and try executing the platform add command using - "root_folder\cordova-cli\bin\cordova.cmd platform add "root_folder\cordova-android" --verbose" , platform addition is successfully.

Not sure how to bring in cordova-common module installed as dependency while creating mobile-spec project

Use eslint

I think it would be good to use eslint to help keep the JavaScript as consistent as possible with the rest of Cordova. A major example is the use of double-quotes while most of our other modules use single-quotes.

Reintroduce 3rd party plugin testing

#179 removed 3rd party plugin testing. This is a useful thing in general, should be investigated if and how this can be included again.

Note: Does not have to be in this project or any existing project, maybe it makes sense to start something new for that.

createmobilespec.js fails with a git error

Bug Report

Problem

What is expected to happen?

A command like this from the documentation should just work after following the prerequisites:

node ./cordova-mobile-spec/createmobilespec/createmobilespec.js --android

What does actually happen?

failed with a git error, like this:

brodybits@brodybits-mini-macbook cordova-testing % ./cordova-mobile-spec/createmobilespec/createmobilespec.js --android           
### Creating project from local git repos. If you have any errors, it may be from missing repositories.
To clone repositories:
  ./cordova-coho/coho repo-clone -r mobile-spec -r plugin-test-framework -r cli -r lib -r plugman -r android -r js -r plugins
  mkdir cordova-cli/node_modules
  (cd cordova-lib && npm install)
  (cd cordova-plugman/ && npm install)
  mkdir cordova-cli/node_modules
  ln -s ../../cordova-lib cordova-cli/node_modules
  (cd cordova-cli && npm install)
To update all repositories:
  ./cordova-coho/coho repo-update
Checking if you are using master branch of tools (js, lib, plugman, cli)
$ git symbolic-ref HEAD
refs/heads/master
$ git symbolic-ref HEAD
refs/heads/master
$ git symbolic-ref HEAD
refs/heads/master
$ git symbolic-ref HEAD
refs/heads/master
You are on master branch of tools, checking npm links
npm links are OK
### Creating project mobilespec...
$ /Users/brodybits/dev/cordova-testing/cordova-cli/bin/cordova create mobilespec org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec/www
Warning: using prerelease version 10.0.0-dev ([email protected])
Creating a new cordova project.
Error: npm: Command failed with exit code 1 Error output:
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t ssh://[email protected]/cordova-mobile-spec/www.git
npm ERR! 
npm ERR! ERROR: Repository not found.
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR! 
npm ERR! exited with error code: 128

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/brodybits/.npm/_logs/2020-06-24T17_16_23_896Z-debug.log
    at ChildProcess.whenDone (/Users/brodybits/dev/cordova-testing/cordova-common/src/superspawn.js:136:25)
    at ChildProcess.emit (events.js:315:20)
    at maybeClose (internal/child_process.js:1021:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5) {
  stderr: 'npm ERR! Error while executing:\n' +
    'npm ERR! /usr/bin/git ls-remote -h -t ssh://[email protected]/cordova-mobile-spec/www.git\n' +
    'npm ERR! \n' +
    'npm ERR! ERROR: Repository not found.\n' +
    'npm ERR! fatal: Could not read from remote repository.\n' +
    'npm ERR! \n' +
    'npm ERR! Please make sure you have the correct access rights\n' +
    'npm ERR! and the repository exists.\n' +
    'npm ERR! \n' +
    'npm ERR! exited with error code: 128\n' +
    '\n' +
    'npm ERR! A complete log of this run can be found in:\n' +
    'npm ERR!     /Users/brodybits/.npm/_logs/2020-06-24T17_16_23_896Z-debug.log\n',
  code: 1
}

possible fix

The following change seemed to resolve this issue:

diff --git a/createmobilespec/createmobilespec.js b/createmobilespec/createmobilespec.js
index 1e0bf85..21cf96b 100755
--- a/createmobilespec/createmobilespec.js
+++ b/createmobilespec/createmobilespec.js
@@ -420,7 +420,7 @@ if (argv.plugman) {
     // Create the project using "cordova create"
     myDelete(cli_project_dir);
     console.log("### Creating project mobilespec...");
-    executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template cordova-mobile-spec" + path.sep + "www");
+    executeShellCommand(cli + " create " + projectDirName + " org.apache.cordova.mobilespec MobileSpec_Tests --template ./cordova-mobile-spec" + path.sep + "www");
     shelljs.cp("-f", path.join(mobile_spec_git_dir, 'config.xml'), path.join(projectDirName, 'config.xml'));
 
     // Config.json file ---> linked to local libraries

Information

see above

Command or Code

see above

Environment, Platform, Device

see above & below

Version information

host: macOS Catalina

Checklist

I searched for existing GitHub issues
I updated all Cordova tooling to most recent version
I included all the necessary information above

createmobilespec.js should fail if subcommand fails

#159 (comment) shows createmobilespec.js returning an error on cordova platform add .... But instead of stopping and throwing an error, it just continues and the following commands also fail - making it much harder to understand what is going on.

It may be required to uninstall the `cordova-plugin-compat` plugin due to multiple "BuildHelper" classes defined in dex files

(https://stackoverflow.com/questions/46562289/multiple-dex-files-define-lorg-apache-cordova-buildhelper/46562523#46562523)

(Issues title taken from this commit: e4b0a23)

Could you elaborate this quirk please @brodybits? Could not reproduce.

Consistent failures on Android

file.spec.147 - consistently fails on Android
cordova-plugin-file-transfer-tests.tests - multiple failures, consistently on Android
cordova-plugin-media-tests - multiple failures, consistently on my Samsung Galaxy S6 device (seemed to work in the past)

Drop deprecated cordova-plugin-file-transfer testing

(which consistently gives me failures on Android)

this would invalidate apache/cordova-labs#16 - Move cordova-filetransfer branch to cordova-plugin-file-transfer repo

commands do not look right in ./createmobilespec/README.md

Bug Report

Problem

What is expected to happen?

It should be possible to paste the commands into the shell.

What does actually happen?

Commands in preparation do not work in macOS or Linux shell due to single ampersand - fix is proposed in PR #204
Some commands under usage do not work since they do not include platforms

Information

see above

Command or Code

see commands in https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/README.md

Environment, Platform, Device

see below

Version information

host: macOS Catalina

Checklist

I searched for existing GitHub issues
I updated all Cordova tooling to most recent version
I included all the necessary information above

First it pops up an alert:
"Some prereq XHR stuff to get license content failed mang"

Then a lot of these alerts:
"There was a problem during XHR file read!"

The other manual tests under Benchmarks ran fine.

Cleanup or remove testing with third-party plugins

cordova-mobile-spec/createmobilespec/createmobilespec.js

Lines 151 to 193 in 8f8304f

 // List generated based on download counts on registry. 

 var CORDOVA_REGISTRY_PLUGINS = [ 

 'com.ionic.keyboard', 

 'com.google.playservices', 

 'de.appplant.cordova.plugin.local-notification', 

 'com.phonegap.plugins.barcodescanner', 

 'com.cranberrygame.phonegap.plugin.ad.admob', 

 // 'com.google.cordova.admob', // these two conflict. Use the most popular one. 

 // 'com.google.admob', 

 // Currently need an git version of this to fix a bug in published version. 

 // It's a dep of plugin.google.maps 

 'https://github.com/wf9a5m75/phonegap-http-request.git', 

 'plugin.google.maps', 

 'com.rjfun.cordova.extension', 

 'net.yoik.cordova.plugins.screenorientation', 

 'de.appplant.cordova.plugin.email-composer', 

 'com.msopentech.azure-mobile-services', 

 // 'com.phonegap.plugins.pushplugin', // This one bundles play services, causing duplicate symbols 

 'com.phonegap.plugins.facebookconnect', 

 'com.danielcwilson.plugins.googleanalytics' 

 ]; 

 // Commented out plugins are popular, but duplicate those in CPR. 

 var TELERIK_VERIFIED_PLUGINS = [ 

 'https://github.com/Telerik-Verified-Plugins/Flashlight', 

 'https://github.com/Telerik-Verified-Plugins/SocialSharing', 

 'https://github.com/Telerik-Verified-Plugins/ActionSheet', 

 'https://github.com/Telerik-Verified-Plugins/Calendar', 

 // 'https://github.com/Telerik-Verified-Plugins/EmailComposer', 

 'https://github.com/Telerik-Verified-Plugins/NativePageTransitions', 

 'https://github.com/Telerik-Verified-Plugins/Toast', 

 // 'https://github.com/Telerik-Verified-Plugins/BarcodeScanner', 

 'https://github.com/Telerik-Verified-Plugins/Keychain', 

 // 'https://github.com/Telerik-Verified-Plugins/Keyboard', 

 'https://github.com/Telerik-Verified-Plugins/NFC', 

 'https://github.com/Telerik-Verified-Plugins/AppVersion', 

 'https://github.com/Telerik-Verified-Plugins/PrivacyScreen' 

 ]; 

 var PLUGREG_PLUGINS = [ 

 'https://github.com/brodysoft/Cordova-SQLitePlugin.git', 

 // 'https://github.com/wildabeast/BarcodeScanner.git', 

 // 'https://github.com/phonegap-build/PushPlugin.git', 

 ];

Some things I can think of right now:

plugins commented out would likely be outdated
CORDOVA_REGISTRY_PLUGINS looks like it comes from an old registry
TELERIK_VERIFIED_PLUGINS may have some outdated plugins
PLUGREG_PLUGINS has a single plugin by myself that is definitely outdated

P.S. According to the comment in https://github.com/apache/cordova-mobile-spec/pull/153/files#r236861171, things are broken with third-party plugins in https://github.com/apache/cordova-mobile-spec/blob/master/createmobilespec/createmobilespec.js#L143-L147

I would now favor remove testing with third-party plugins, as discussed below.

A problem occurred evaluating project ':app'. > ...\mobilespec\platforms\android\app\android-debug-key.properties (The system cannot find the file specified)

Files are actually one level up.

Probably caused by the change of folder structure of cordova-android 7.x.

`npm install` inside `cordova-js` is needed to resolve a local grunt issue

(Issues title taken from this commit: e4b0a23)

Could you elaborate this quirk please @brodybits? Could not reproduce.

Extract whitelist tests

This repo contains tests for cordova-plugin-whitelist:
https://github.com/apache/cordova-mobile-spec/tree/master/cordova-plugin-whitelist
https://github.com/apache/cordova-mobile-spec/blob/master/cordova-plugin-mobilespec-tests/tests/whitelist.tests.js

If these still work in any way, it might be worth to extract them to https://github.com/apache/cordova-plugin-whitelist

npm audit warning in createmobilespec

brodybits@brodybits-mini-macbook cordova-mobile-spec % cd createmobilespec 
brodybits@brodybits-mini-macbook createmobilespec % npm audit
                                                                                
                       === npm audit security report ===                        
                                                                                
┌──────────────────────────────────────────────────────────────────────────────┐
│                                Manual Review                                 │
│            Some vulnerabilities require your attention to resolve            │
│                                                                              │
│         Visit https://go.npm.me/audit-guide for additional guidance          │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low           │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ minimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in    │ >=0.2.1 <1.0.0 || >=1.2.3                                    │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ optimist                                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ optimist > minimist                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1179                            │
└───────────────┴──────────────────────────────────────────────────────────────┘
found 1 low severity vulnerability in 154 scanned packages
  1 vulnerability requires manual review. See the full report for details.

[Windows] Tests with external URLs fail because of `http://`

Migrated from https://issues.apache.org/jira/browse/CB-13905:

Creating a mobile-spec project for Windows with:

./cordova-mobile-spec/createmobilespec/createmobilespec.js --windows --forceplugins

shows lots of errors like these during creation:


Access rules must begin with "https://", the following rule will be ignored: http://audio.ibeat.org
Access rules must begin with "https://", the following rule will be ignored: http://whatheaders.com
Access rules must begin with "https://", the following rule will be ignored: http://*.apache.org
Access rules must begin with "https://", the following rule will be ignored: http://www.google.com
Access rules must begin with "https://", the following rule will be ignored: http://google.co.uk
Access rules must begin with "https://", the following rule will be ignored: http://techslides.com
Access rules must begin with "https://", the following rule will be ignored: httpssss://example.com
The following navigation rule had an invalid URI scheme and will be ignored: "httpssss://example.com".
The following navigation rule had an invalid URI scheme and will be ignored: "cdvfile:*".
The following navigation rule had an invalid URI scheme and will be ignored: "data:*".
Access rules must begin with "https://", the following rule will be ignored: http://audio.ibeat.org
Access rules must begin with "https://", the following rule will be ignored: http://whatheaders.com
Access rules must begin with "https://", the following rule will be ignored: http://*.apache.org
Access rules must begin with "https://", the following rule will be ignored: http://www.google.com
Access rules must begin with "https://", the following rule will be ignored: http://google.co.uk
Access rules must begin with "https://", the following rule will be ignored: http://techslides.com
Access rules must begin with "https://", the following rule will be ignored: httpssss://example.com

Those also repeat when running the created project with cordova run windows --archs=x86:

Access rules must begin with "https://", the following rule will be ignored: http://audio.ibeat.org
Access rules must begin with "https://", the following rule will be ignored: http://whatheaders.com
Access rules must begin with "https://", the following rule will be ignored: http://*.apache.org
Access rules must begin with "https://", the following rule will be ignored: http://www.google.com
Access rules must begin with "https://", the following rule will be ignored: http://google.co.uk
Access rules must begin with "https://", the following rule will be ignored: http://techslides.com
Access rules must begin with "https://", the following rule will be ignored: httpssss://example.com
The following navigation rule had an invalid URI scheme and will be ignored: "httpssss://example.com".
The following navigation rule had an invalid URI scheme and will be ignored: "cdvfile:*".
The following navigation rule had an invalid URI scheme and will be ignored: "data:*".
Access rules must begin with "https://", the following rule will be ignored: http://audio.ibeat.org
Access rules must begin with "https://", the following rule will be ignored: http://whatheaders.com
Access rules must begin with "https://", the following rule will be ignored: http://*.apache.org
Access rules must begin with "https://", the following rule will be ignored: http://www.google.com
Access rules must begin with "https://", the following rule will be ignored: http://google.co.uk
Access rules must begin with "https://", the following rule will be ignored: http://techslides.com
Access rules must begin with "https://", the following rule will be ignored: httpssss://example.com
Tests will use the following file transfer server address: http://rwswbpiopr.localtunnel.me

And as a result the automates tests using those URLs also fail:

Troubles with iOS

I got a linker error due to multiple definitions of CDVLogger. When I tried removing cordova-plugin-logger it would build and run on iOS, then crash near the beginning of the automatic tests.

	// List generated based on download counts on registry.
	var CORDOVA_REGISTRY_PLUGINS = [
	'com.ionic.keyboard',
	'com.google.playservices',
	'de.appplant.cordova.plugin.local-notification',
	'com.phonegap.plugins.barcodescanner',
	'com.cranberrygame.phonegap.plugin.ad.admob',
	// 'com.google.cordova.admob', // these two conflict. Use the most popular one.
	// 'com.google.admob',
	// Currently need an git version of this to fix a bug in published version.
	// It's a dep of plugin.google.maps
	'https://github.com/wf9a5m75/phonegap-http-request.git',
	'plugin.google.maps',
	'com.rjfun.cordova.extension',
	'net.yoik.cordova.plugins.screenorientation',
	'de.appplant.cordova.plugin.email-composer',
	'com.msopentech.azure-mobile-services',
	// 'com.phonegap.plugins.pushplugin', // This one bundles play services, causing duplicate symbols
	'com.phonegap.plugins.facebookconnect',
	'com.danielcwilson.plugins.googleanalytics'
	];
	// Commented out plugins are popular, but duplicate those in CPR.
	var TELERIK_VERIFIED_PLUGINS = [
	'https://github.com/Telerik-Verified-Plugins/Flashlight',
	'https://github.com/Telerik-Verified-Plugins/SocialSharing',
	'https://github.com/Telerik-Verified-Plugins/ActionSheet',
	'https://github.com/Telerik-Verified-Plugins/Calendar',
	// 'https://github.com/Telerik-Verified-Plugins/EmailComposer',
	'https://github.com/Telerik-Verified-Plugins/NativePageTransitions',
	'https://github.com/Telerik-Verified-Plugins/Toast',
	// 'https://github.com/Telerik-Verified-Plugins/BarcodeScanner',
	'https://github.com/Telerik-Verified-Plugins/Keychain',
	// 'https://github.com/Telerik-Verified-Plugins/Keyboard',
	'https://github.com/Telerik-Verified-Plugins/NFC',
	'https://github.com/Telerik-Verified-Plugins/AppVersion',
	'https://github.com/Telerik-Verified-Plugins/PrivacyScreen'
	];

	var PLUGREG_PLUGINS = [
	'https://github.com/brodysoft/Cordova-SQLitePlugin.git',
	// 'https://github.com/wildabeast/BarcodeScanner.git',
	// 'https://github.com/phonegap-build/PushPlugin.git',
	];

apache / cordova-mobile-spec Goto Github PK

cordova-mobile-spec's Introduction

Cordova Mobile Spec Suite

Overview

Usage

Cordova Plugin File-Transfer Tests

cordova-mobile-spec's People

Contributors

Stargazers

Watchers

Forkers

cordova-mobile-spec's Issues

Bug Report

Problem

What is expected to happen?

What does actually happen?

possible fix

Information

Command or Code

Environment, Platform, Device

Version information

Checklist

Bug Report

Problem

What is expected to happen?

What does actually happen?

Information

Command or Code

Environment, Platform, Device

Version information

Checklist

Recommend Projects

Recommend Topics

Recommend Org