anytarseir67 / asciipy Goto Github PK

as the available options for the converter classes increase, i've found that it's common to leave most settings at the default, resulting in needlessly long constructors (e.g. asciipy.ImageConverter(80, None, None, None, True))

the initial design decision was that any argument taken by BaseConverter would be a positional argument, with extra arguments for subclasses being keyword arguments; and although i like the separation of BaseConverter and its subclasses, it makes reading any code with multiple converters a pain in the ass.

i am currently considering:

• moving everything to kwargs
• using configuration classes, (I.e. a dataclass that stores the config) similar to what is currently used for the background system.

kwarg example:

converter = asciipy.ImageConverter(width=80, transparent=True)

config class example:

conf = asciipy.Config(width=80, transparent=True)
converter = asciipy.ImageConverter(conf)

or

conf = asciipy.Config()
conf.width = 80
conf.transparent = True
converter = asciipy.ImageConverter(conf)

any feedback would be greatly appreciated!