Out of Index Error not handled while getting score from 'description' tag in 'develop' branch. In case there is one active match. It returns out of index error.
https://github.com/neo1691/scorer.py/blob/develop/scorer.py#L17-L18

It's better to have fetching data from proxy server if cric info is blocked.

One of the todo mentions, usage of argparse. It can also have an argument which takes time in seconds, which specifies how often script should check for new results.

I am already doing these in OS X version.

• for proxy link, you can use this: http://anonymouse.org/cgi-bin/anon-www.cgi/http://static.cricinfo.com/rss/livescores.xml
• for argparse usage example, Line 17-25

The current version of latest score gets a lot of hardcoding. The code currently breaks when there is no international match going on live.

The hardcoding in the json is the culprit.

I have fixed the code partially, will release the stable version alongwith the proper code structure according to python standards.

Hello, so i came a cross the mentioned error on
fetch_scores.py", line 86, in getLastestScore titleToDisplay = battingTeamName + " vs " + bowlingTeamName TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

i did a little debugging and notice lets take the game Andhra 321/9 * v Bengal 300/10, playingTeams value returns {'1592': None, '1623': None} which means battingTeamName = None and titleToDisplay = battingTeamName + " vs " + bowlingTeamName will cause the error above.

So even if a proper formating is done, lets say titleToDisplay = "{} vs {}".format(battingTeamName, bowlingTeamName), it will solve the error but displayed end result (in this case title:None vs None) will be useless.

NOTE:i am currently running the script on windows machine using some work arounds(also planning to share the ported code(to be discussed :)}

Shailesh Gupta has given me an interesting peice of information over email.

Her says that we catn get the matchid from the description tag in the xml and use an url like this:
http://www.espncricinfo.com/netstorage/656493.json to get a json with complete information about the match.

We can then add other important stats to the notification.

Anyone willing to give a look at it?

Code breakes if I choose any choice other than displayed one.

need to handle Out of Index Eror in https://github.com/neo1691/scorer.py/blob/master/scorer.py#L36-L38

With the latest merge from @asdofindia this bug has been introduced in the code base.

I will add logging to the code to see what's happening in the code.

Would like to use command line arguments to pass to the script:
The options could be the following:

--delay No of seconds to delay before notifications
--config-file Path to config file
--debug Debug flag
--log-file Path to log file
--pushbullet Would you like to use pushbullet API
--api-key If yes what's your API key?
--score-change Only get notified when there is a change in the score or a wicket falls?

--boundaries Only get notified when a boundary is hit?
--sixes Get notified when sixes are hit.
Can be more options. Please comment if you find any new options.

I have built an OS X version, shall I send a PR which mentions the same in README.MD?

@neo1691 I think we need to add the exception catching at the function level of findMatchesAvailable in fetch_scores.py as sometime the URL might not be reachable or under maintenance

Traceback (most recent call last):
File "scorer.py", line 44, in
r = requests.get(url)
File "/usr/lib/python2.7/dist-packages/requests/api.py", line 55, in get
return request('get', url, *_kwargs)
File "/usr/lib/python2.7/dist-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, *_kwargs)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 455, in request
resp = self.send(prep, *_send_kwargs)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 558, in send
r = adapter.send(request, *_kwargs)
File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 378, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='static.cricinfo.com', port=80): Max retries exceeded with url: /rss/livescores.xml (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)

HI,

I am new to Python and Github as well.:P

Request you to put up a flow of events(interactions) as I am planning to implement the functionality using JS and understand the present code in this project.

P.S.: I am unsure if i can put such requests in issues and found this a way to put up this request. EXCUSE ME for this.

As @neo1691 suggested that we should add command line options to the script. It is a good idea but I think we should mention all default values in a config file located at the app dir or /etc/ something.

We can write a sample file like below.

/***** /etc/scorer/config *****/
[config]
config_file = "/path/to/config/file"

[log]
log_file = "/path/to/log/file"
log_level = "debug"

[app]
delay = 5

[secret]
api_key = 'xxxxxxxxx'
access_token = "xxxxxxxxxxx"

This way it not only makes code cleaner but also makes it easy to change the default values (using ConfigParser) through command line options or code itself.

What do you guys think about the config file option?

I have no experience with either rst or sphinx, but if someone can write documentation for all the modules and their functions then it would be great for the future developers to contribute back to the project.

Also I would like to add in the developer guidelines wiki that future contributions need to be submitted with proper documentation.

The pynotify library can be installed directly during setup.

Running python app.py :

Traceback (most recent call last):
File "app.py", line 2, in
from scorer.system import exitApp
ImportError: No module named scorer.system

Hi had a very interesting scenario on an ubuntu box where somehow the notification daemon was disabled. even notify-send was not working. The code failed with the following error:

Traceback (most recent call last):
File "/usr/local/bin/scorer", line 9, in
load_entry_point('scorer==0.1', 'console_scripts', 'scorer')()
File "/usr/local/lib/python2.7/dist-packages/scorer-0.1-py2.7.egg/scorer/app.py", line 38, in main
notify.popUpMessage(title, score)
File "/usr/local/lib/python2.7/dist-packages/scorer-0.1-py2.7.egg/scorer/notification.py", line 8, in popUpMessage
pynotify.Notification(title, message, "dialog-information").show()
gio.Error: Could not connect: Connection refused

Need to handle this error better!

Also find alternatives to pynotify that works crossplatform on windows, linux and mac.

I have made some changes to the structureCode branch and now I have added a setup.py to it.

Doing python setup.py build build's the project and creates a build directory in the project root folder and sudo python setup.py install installs the project somewhere in the path of the system.

But I have no idea how to run the app from anywhere else after installing.

Someone with prior experience with setuptools might be able to help me out here.

Thank you.

Getting the mention error.
I ran the script when no matches were available. That's all i think might be the cause for this.

Fetching matches..
INFO:root:Sending requests
INFO:urllib3.connectionpool:Starting new HTTP connection (1): static.cricinfo.com
DEBUG:urllib3.connectionpool:Setting read timeout to None
DEBUG:urllib3.connectionpool:"GET /rss/livescores.xml HTTP/1.1" 200 2657
INFO:urllib3.connectionpool:Starting new HTTP connection (1): www.espncricinfo.com
DEBUG:urllib3.connectionpool:Setting read timeout to None
DEBUG:urllib3.connectionpool:"GET /netstorage/656493.json HTTP/1.1" 302 0
DEBUG:urllib3.connectionpool:Setting read timeout to None
DEBUG:urllib3.connectionpool:"GET /ci/engine/match/656493.json?view=live;wrappertype=live;zakamai=1 HTTP/1.1" 200 21863
Traceback (most recent call last):
File "scorer.py", line 77, in
parsingJson = json.loads(dataFromJSONUrl.text)
File "/usr/lib/python2.7/json/init.py", line 338, in loads
return _default_decoder.decode(s)
File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded

I need to write wiki pages describing the use of this project.
One page to describe how to install this script (After packaging it with pip)
One page to layout developer guidelines.
One page for command line flags. (After the implementation of optparse/argvparse etc)

And more.