antevens / cerlet Goto Github PK

Perhaps I've missed some initial configuration but here are the issues I've found so far trying to run execute cerlet manually.

I'm executing as:
$ cerlet --config-dir=/home/vagrant/tmp --work-dir=/home/vagrant/tmp --logs-dir=/home/vagrant/tmp

• CERTMONGER_REQ_HOSTNAME is a required key but it isn't tested for. Not being set results in a NotImplementedError being raised
• File "/home/vagrant/Revisions/cerlet/cerlet/init.py", line 236, in init
  for key, path in paths.iteritems():
  AttributeError: 'dict' object has no attribute 'iteritems'
  I fixed by importing six and calling six.iteritems(paths)
• PATHS overrides --config-dir, --work-dir and --logs-dir
• valid_operations always passes cls as the argument but identify takes no arguments resulting in:
  TypeError: identify() takes 0 positional arguments but 1 was given
  Perhaps not make it a static method?
• testing with
  File "/home/vagrant/Revisions/cerlet/cerlet/init.py", line 469, in get_ca_root_certs
  nickname = ' '.join(x[1] for x in cert.get_subject().get_components())
  TypeError: sequence item 0: expected str instance, bytes found

Will continue testing and update as needed.