Giter Club home page Giter Club logo

pe's People

Contributors

anonymxtrix avatar

Watchers

 avatar

pe's Issues

Incorrect non-functional requirement for Java version in DG

Expected Documentation

The PE requirements states that the software should work on a computer that has version 11 of Java.

Actual Documentation

Your documentation states that the software "should work on any mainstream OS as long as it has Java 11 or above installed".

Screenshots

image.png

image.png

Hourly Salary not optional even though documentation says otherwise

Documentation

image.png
image.png

Steps to reproduce

  1. Copy the following into a .csv file
Name,Contact Number,Residential Address,Email,Role,Leave Balance,Salary,Hours Worked,Overtime,Tags
John Doe,98765432,"311, Clementi Ave 2, #02-25",[email protected],Admin Assistant,0,,,,
  1. Place the .csv file into the same directory as your .jar

  2. Run the import command to import the .csv file.

  3. You should see the following error

Error occurred while importing the file.
Invalid Input in Row 1: Hourly Salary should only contain non-negative numbers with two or less decimal places, with a value between 0 to 1000, and it should not be blank.

Expected Behaviour

Documentation says that the file should be able to be imported without specifying hourly salary.

Actual Behaviour

An error message pops up to disallow import because hourly salary is not specified.

Screenshots

image.png

Wrong error message for addition parameters

Steps to reproduce

  1. Enter the following command
add n/John Doe p/98765432 e/[email protected] a/John street, block 123, #01-01 r/Admin Assistant l/14 s/9.50 hw/40 o/0 asd/???
  1. The following error message should be seen
Overtime should only contain an integer value between 0 and 744 (both inclusive), and it should not be blank.

Expected Behaviour

The application should show some error message telling me that format is invalid or parameter asd does not exist.

Actual Behaviour

The application shows me the error message that I passed the wrong value into overtime

Screenshots

image.png

Typo in documentation test case for import

Expected Behaviour

Using the command import /toBeImported.csv as specified in the DG results in a successful import when there is a toBeImported.csv file in the same directory as the .jar file.

Expected Behaviour

Using the command import /toBeImported.csv as specified in the DG will not work as expected. I suspect there is a typo here and it should have been import ./toBeImported.csv.

Screenshots

image.png

Additional Remarks

Severerity here is medium because there was a similar case in the PE preparation quiz where demo was misspelt in the UG.

Inconsistent error message in edit command

Steps to reproduce:

  1. Enter the following command into the command panel input. (Assuming list of 7 employees)

    edit 8 n/John Wee

  2. Error message is

    The person index provided is invalid

  3. Enter the following command into the command panel input.

    edit 0 n/John Wee

  4. Error message is

    Invalid command format! ...

Expected Behaviour

Both the error messages should be similar due to the fact that they are both a result of invalid INDEX.

Actual Behaviour

Both the error messages are different.

Screenshots

image.png

image.png

Error message even when add command entered should be correct

Steps to reproduce:

  1. Copy and paste the following command into the command panel input bar and press the enter key.

    add n/� ы 拢 Ӹ Ћ ډ؊ p/98765432 e/[email protected] a/John street, block 123, #01-01r/Admin Assistant l/14 s/9.50 hw/40 o/0

  2. An Invalid command format! error should be displayed. (Which is correct)

  3. Copy and paste the following command into the command panel input bar.

    add n/John Doe p/98765432 e/[email protected] a/John street, block 123, #01-01 r/Admin Assistant l/14 s/9.50 hw/40 o/0

  4. Press the enter key.

Expected

An employee should be successfully added to HeRon.

Actual

The following text is the response displayed in the command panel:

Invalid command format! 
add: Adds an employee to HeRon. Parameters: n/NAME p/PHONE e/EMAIL a/ADDRESS r/ROLE l/LEAVES s/SALARY hw/HOURS_WORKED o/OVERTIME [t/TAG]...

Additional Information

The command was copied from the UG here.

image.png

Leave balance is not optional during import when documentation says otherwise

Documentation

image.png

Steps to reproduce

  1. Copy the following into a .csv file
Name,Contact Number,Residential Address,Email,Role,Leave Balance,Salary,Hours Worked,Overtime,Tags
John Doe,98765432,"311, Clementi Ave 2, #02-25",[email protected],Admin Assistant,,,,,
  1. Place the .csv file into the same directory as your .jar

  2. Run the import command to import the .csv file.

  3. You should see the following error

Error occurred while importing the file.
Invalid Input in Row 1: Leave Balance should only contain an integer value between 0 and 365 (both inclusive), and it should not be blank.

Expected Behaviour

Documentation says that the file should be able to be imported without specifying leave balance.

Actual Behaviour

An error message pops up to disallow import because leave balance is not specified.

Screenshots

image.png

Missing steps in delete an employee use case

Expected Behaviour

Use case 2a should match what happens in the application. It says that when the user enters a delete command when the list is empty, nothing should happen.

Actual Behaviour

Application displays an error message "The person index provided is invalid".

Screenshots

image.png

image.png

Hours worked not optional during import unlike documentation

Documentation

image.png
image.png

Steps to reproduce

  1. Copy the following into a .csv file
Name,Contact Number,Residential Address,Email,Role,Leave Balance,Salary,Hours Worked,Overtime,Tags
John Doe,98765432,"311, Clementi Ave 2, #02-25",[email protected],Admin Assistant,0,0,,,
  1. Place the .csv file into the same directory as your .jar

  2. Run the import command to import the .csv file.

  3. You should see the following error

Error occurred while importing the file.
Invalid Input in Row 1: Hours Worked should only contain an integer value between 0 and 744 (both inclusive), and it should not be blank.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.