Giter Club home page Giter Club logo

anmol-node's People

Contributors

aelesbao avatar herou avatar justin-ciq avatar justinfrevert avatar korzewski avatar nblogist avatar vedhavyas avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

anmol-node's Issues

Configure CI/CD

Configure Github Actions to run tests and trigger Docker Hub to build and publish the node Docker image. The destination image name should be anmolnetwork/node.

Save NFT result on-chain

When off-chain worker finishes a job, then a result has to be send on-chain

  1. Send a signed transaction
  2. Remove NFT from pending queue

Node does not buil/run on mac M1/silicon

Description

I tried to run the node locally but I not possible, already reported here but the fix is not included in this repo: substrate-developer-hub/substrate-node-template#179

Steps to Reproduce

Pull this repo and execute: cargo check

Expected vs. Actual Behavior

What did you expect to happen after you followed the steps you described in the last section? What
actually happened?

Environment

Describe the environment in which you encountered this bug. Use the list below as a starting point
and add additional information if you think it's relevant.

  • Operating system: Mac OS, M1/silicon
  • Anmol Parachain version/tag:
  • Rust version (run rustup show):

Logs, Errors or Screenshots
Everything is included here: substrate-developer-hub/substrate-node-template#179

Use off-chain storage

We can use off-chain indexing to save NFT's pending queue in off-chain storage

  1. Replace on-chain NftPendingQueue with off-chain storage
  2. Add mutex lock's to avoid duplicates

NFT pending queue

Off-chain workers initialisation

  1. New NFT would be added to pending queue
  2. Off-chain worker checks pending queue and if any then starts a worker (simple console log)

Configure rustfmt according to the coding guideline

Motivation

Rust provides a code linting and formating tool to keep the code style consistent. Although it's configured (to some extent) according to our coding guidelines, the files in the project are not formated using it, which causes a huge diff if a developer wants to run it.

Suggested Solution

We should confirm if the current configuration is enough or if there is any update required, and reformat all files in the project.

  • Update .rustfmt.toml according to the code guidelines
  • Reformat project files
  • Add a linting step to the Github Actions

Status?

Question

Hello, what is the development stage of this project? is it still active?

About Nft percentage

Question
Hello,
I saw in your NFT pallet that you're using the type u8 for percentage. How would you deal with percentages of 12.3% for example?
or another case: when the minter (owns 100%) wants to distribute the NFT's fractions to the buyers, based on their contributions (let's say 50.2% and 49.8%): How do you prevent the buyers to get the same percentage, while one contributed more than the other? shouldn't you use the type f32 instead?
Sorry if my question is "dumb", but I'm a rust beginner.
Thanks in advance for your answer.

Kazu

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.