ankitsultana / chaplin Goto Github PK

I had the issue above on my blog which is using Chaplin.

I fixed the issues (I think – let's wait and see what happens when I add a new post :P) but I'm not clear which part of my fix is the important one here (or if they're both important!).

1: Use a unique url for disqus config url in each post

From the docs on the url config var, their samples uses a full page url. One artifact I noticed from using just site.url is that in the disqus discussion dashboard, new discussions were not created for each page I installed disqus comments on – there was just one with my site's base url (e.g. http://example.com). Now a new discussion is created each time I publish a new post.

Furthermore, at this faq, they mention, Identifier conflict can be resolved by verifying that a unique URL is being set and then assigning a unique identifier. So both unique url and unique identifier (which seems... redundant, to me).

2: Don't display disqus comments in development mode

The faq also mentions same comments can appear from previewing pages before publishing. As I mentioned in 1, I started to observe new published pages would immediately generate a discussion on my disqus dashboard. I believe If you do this during development mode, each unique post url you create in development will appear as a comment on your disqus overview, which is not what you want.

Pull request inbound...

btw, I skimmed your other template, accent, and I think it might suffer from the same issue.