ankitrox / share-cart Goto Github PK

My AdBlocker "AdGuard" has a social media filter that hides the sharing icons for Facebook, Twitter and WhatsApp. This may result in an ugly display like this (only Facebook and Twitter activated):

This could be easily solved if Facebook, Twitter and Whatsapp would be at the end of the list. In this case, the window would automatically collapse like this:

Hi,
since I've updated from 1.0.8 to 2.0.1, other parts of the website get changed by css that is part of the share-cart-plugin.
The additional css comes from:

/wp-content/plugins/woo-save-and-share-cart/assets/js/build/scss/_nav.scss
/wp-content/plugins/woo-save-and-share-cart/assets/js/build/scss/_reboot.scss
/wp-content/plugins/woo-save-and-share-cart/assets/js/build/scss/_root.scss
/wp-content/plugins/woo-save-and-share-cart/assets/js/build/scss/_type.scss
/wp-content/plugins/woo-save-and-share-cart/assets/js/build/scss/vendor/_rfs.scss

Should the scope of the css not be limited to the plugin?

Let the user choose which icon to appear in which order.

Introduce reordering functionality for the social/email icons.

I'm working at localization and while most phrases can be translated as expected, I have trouble with some. I've made screenshots of them. Please have a look if I made a mistake or if there is something missing in the plugin.

More important:

Less important, but nice to have:


(By the way, I would prefer a cart-like icon instead of a pin. Maybe it's just a little change while you're at it ;-) )

Unimportant:

When I click the button to share a cart, a window pops up "We love humans" and closes while the button disappears.
In Chrome dev console, I get the following errors:

react-dom.production.min.js:209 Error: Missing required parameters: sitekey
    at new th (recaptcha__de.js:377)
    at ae.<anonymous> (recaptcha__de.js:240)
    at new ae (recaptcha__de.js:531)
    at Array.<anonymous> (recaptcha__de.js:344)
    at r.o.explicitRender (recaptcha.js:81)
    at r.o.componentDidUpdate (recaptcha.js:108)
    at ou (react-dom.production.min.js:212)
    at pl (react-dom.production.min.js:255)
    at t.unstable_runWithPriority (scheduler.production.min.js:19)
    at Bi (react-dom.production.min.js:122)
eu @ 2.0de91c6d.chunk.js:2
recaptcha__de.js:377 Uncaught (in promise) Error: Missing required parameters: sitekey
    at new th (recaptcha__de.js:377)
    at ae.<anonymous> (recaptcha__de.js:240)
    at new ae (recaptcha__de.js:531)
    at Array.<anonymous> (recaptcha__de.js:344)
    at r.o.explicitRender (recaptcha.js:81)
    at r.o.componentDidUpdate (recaptcha.js:108)
    at ou (react-dom.production.min.js:212)
    at pl (react-dom.production.min.js:255)
    at t.unstable_runWithPriority (scheduler.production.min.js:19)
    at Bi (react-dom.production.min.js:122)

I have no "Captcha Key" set and I do not want any (yet...). I'm currently not sure if Google Recaptcha complies with General Data Protection Regulation GDPR. May be this can be optional?

What's the effect of the "Enter name for saved cart label" setting? I expected to see the value here, but that's not the case:

I noticed an additional request to use.fontawesome.com when on cart page or saved cart page. This is problematic for me, because in this case the customers IP will be exposed to a company outside of the EU. Because of the EU General Data Protection Regulation, I would need to inform customers about this.

Also this request is not always necessary. In my case, all fonts I use are within the child themes font directory, and fontawesome is one of them. Other plugins like WPForo have an option to disable their own Font Awesome integration and the styles are automatically using the sidewide existing one. So I'd like to have an option to disable loading of an additional fontawesome integration.