ankane / setup-mariadb Goto Github PK

Ideas

• Add database and user inputs

The readme might do with some pros and cons compared the docker ways of doing this. Some thoughts:

• speed (my tests show this one slightly slower at around 40 seconds compared to 25)
• client tools. This approach installs the proper mariadb client executable accessible to the tests
• avoid collisions. This approach uninstalls mysql which is already installed in github actions.
• socket connections available (haven't tested yet as to whether that will help with speed or reliability)

It's in the title :)

Example: https://github.com/r-dbi/RMariaDB/runs/1795874124?check_suite_focus=true#step:12:60. Any ideas?

Hello, it's me again :) 10.10 is the current stable release now

https://github.com/r-dbi/RMariaDB/runs/1483985818?check_suite_focus=true#step:14:89

 Non-standard file/directory found at top level:
    'mariadb.msi'

I can add to .Rbuildignore for now.

Thanks for providing these actions, they save a ton of time!

The download from mariadb sometimes fails and takes about 6 seconds.
The downloaded file could be cached (by using actions/cache inside the setup-mariadb action).

2024-03-10T14:19:47.1780788Z curl -Ls -o mariadb.msi https://downloads.mariadb.com/MariaDB/mariadb-10.11.6/winx64-packages/mariadb-10.11.6-winx64.msi
2024-03-10T14:19:53.8303235Z msiexec /i mariadb.msi SERVICENAME=MariaDB /qn
2024-03-10T14:20:29.1565456Z

https://github.com/r-dbi/RMariaDB/pull/185/checks?check_run_id=1484154324#step:13:160

On Linux I'm seeing with RMariaDB:

Error: Failed to connect: Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)

I wonder why mysql commands work, wouldn't they also use the socket by default? Is the socket in a different location?

Per https://mariadb.com/kb/en/missing-mysqldsock-file/#comment_165, do we need

ln -s /tmp/mysql.sock /var/run/mysqld/mysqld.sock

?

      with:
        mariadb-version: 11.0

gave me: Invalid MariaDB version: 11 : https://github.com/r-dbi/RMariaDB/actions/runs/5262998831/jobs/9512728749?pr=299#step:7:100

This seems to work:

      with:
        mariadb-version: "11.0"

In one of my builds on Windows, I'm now seeing a failure at the step

curl -Ls -o mariadb.msi https://downloads.mariadb.com/MariaDB/mariadb-11.1.2/winx64-packages/mariadb-11.1.2-winx64.msi

I checked which curl and manually executing the command (via SSH), works fine.

It's interesting that only the "R release" build fails, the others succeed.

https://github.com/r-dbi/RMariaDB/actions/runs/8507877707/job/23300514745?pr=325#step:5:132

Any idea what might be going on here or how to debug?