anisg / fillit_checker Goto Github PK
View Code? Open in Web Editor NEWverificateur pour fillit
verificateur pour fillit
il voit pas le fichier auteur et il le met dans "extern file"
Adding a no-color option would be great !
CHECKING RULE: re
-> Failing rule: It should have compiled again the binary named 'fillit' (inode unchanged)
Erreur heuristique il y a bien recompilation du binaire mais il affiche une erreur.
Merci
##..$
##..$
....$
....
Failed project on moulinette. This one should display "error"
Mon programme passe tous les tests du file checker, pourtant il considère comme juste un fichier qui contient un tetriminos dans cette configuration :
. . . .
##.#
. . .#
. . . .
Actuellement non teste: Le cas ou l'on a un seul tetriminos et que sur la 4eme ligne juste apres le 4eme point nous avons enleve le retour a la ligne de la maniere suivante
####$
. . . . $
. . . . $
. . . . %
"No forbidden functions found" with strcmp in my file. Moulinette failed me.
Deux tests qui complètent ceux du 42FC :
#... .... #... ### ..## ...# #... ##..Ces deux tetris trompent les parsers qui se basent uniquement sur le nombre de liens entre les blocs d'un tetrimino (qui est soit de 6, soit de 8 pour être valide).
Le premier "faux tetri" comporte 6 liens. Le deuxième 8. Pourtant aucun d'eux n'est valide.
si pour le fillit il y a utilisation du fichier externe extern_file.txt , il n'est pas copié en meme temps que l'executable dans le dossier de test , en résulte une erreur systématique.
L'executable fillit est supprimé avant d'etre testé dans le test "Check all!"
@@ -1,3 +1,2 @@$
-AA.$
-AA.$
-...$
+AA$
+AA$
Diff KO :(
no check for minimum tetramino size.
When I run fillet_checker, I get too many lines:
"awk: can't open file (file)
source line number 1"
mon fillit est considéré comme faux par le script mais si je l'execute moi meme avec les fichiers valides il me sors le bon résultat
j'ai changé la ligne 34 dans test.sh
var=$((${MYPATH}/./fillit ${LOCALPATH}/$2$i) 2>&-)
par
var=$((${MYPATH}/./fillit ${LOCALPATH}/$2$i) 2>&1)
sans vraiment comprendre ce que je faisais et le résultat est correct.
Mais sinon merci pour ce time savior!
(aussi le fichier valid_8 ne l'est pas).
Bonsoir, notre fillit vient de fail car on affiche "error" sans \n et on s'est fies au 42FileChecker...
Il faudrait fix l'erreur pour les prochains en verifiant que le message est bon.
En tout cas merci pour tout le boulot !
Salut !
J'ai remarqué que parmi tes tests, il n'y en a pas qui teste un fichier vide.
Ca peut etre une source facile de segfault si le cas n'est pas géré donc je me dis que ca serait intéressant de l'ajouter !
Hello!
Firstly I'd like to thank you for your wok. The 42FILECHECKER and the FILLIT_CHECKER are great. But nothing is perfect in this world and we had faced some serious kind of bug.
It seems that there are no test contaiting one Tetrimino in FILLIT_CHECKER. Our fillit project has passed all the tests in 42FILECHECKER (and even all the test in Moulinette (!) by the way) but one of the evaluators found two bugs in our project. The size of field was incorrect for any file with 1 Tetrimino and it crashed in case with straight vertical line. Could you please include at least 2 tests for 1 ttr: the first one with any ttr and the second - with straight vertical line.
There is a guideline to check such case for students in correction form so it is very-very strange that there are no such cases in automatic testing (Moulinette) so we are going to inform our pedagogic team about that in order to add cases with 1 ttr.
Thanks again.
Best regards,
mbiliaie
Hello,
first of all thank you for your work on 42FileChecker.
Maybe you already had this feedback but fyi I was surprised that my program got the line
6 -> Fillit_checker (https://github.com/anisg/fillit_checker) All tests passed (48 tests)
appearing in green when actually it did not pass the bonus test of only one tetri ;(
I realized it only after the first correction, since then I corrected the code (which did not work properly for only one tetri) and the line appears exactly the same way, the only difference being when opening more info, the correct output is displayed instead of error (cf both screenshot).
Maybe it would be easier to read if the total indicated
all tests passed : 48/48 bonus failed : 0/1
or something like along those lines.
Hope this is clear enough, if you have any question do not hesitate to contact me ([email protected]). My partner for this project is @anyashuka.
Code does not account for "error\n" and only checks for "error"
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.