anidevtwitter / animeopenings Goto Github PK

https://webtorrent.io/

hello
how to use subtitle.js ass with videojs
that would be good if there an example ?

thanks

It's not a big issue either and a little hard to explain but I try.

Image 1 :
https://gyazo.com/d5ec0aca127d348b1837b39de3ab864d

Image 2 :
https://gyazo.com/1c2cbf8ba13a7e9bb3e4d953a2a32b1e

Image 1 is taken from AnimeOpenings, image 2 with mpv.

This karaoke can't be linked due to a bug (when there are two or more songs with the same name, no matter what you link, it's always the first one that's displayed, we'll create an issue later for that) but this one displays the same behavior :

https://live.karaokes.moe/?video=%20Opening%20-ANG%20-%20ACCA%2013-ku%20Kansatsuka%20

When a word is of a different color, than the rest of the line, its first syllabe stays in the original line's color.

On ACCA the behavior is even weirder, see : https://gyazo.com/8b309983027cb5ce56a3f863bf4d88d4 the word "story" is suppoed to be in yellow.

You can find video and ASS files for ACCA here :
http://mugen.karaokes.moe/en/karas/6696c027-7bb2-4bc5-a973-0e034569d50c.html

The first karaoke I showed was Tutu Ballerina which you can find files for here :
http://mugen.karaokes.moe/fr/karas/e58ff527-7f84-4f86-a4ba-7381f7efd2ff.html

Hope this can help :)

Uncaught TypeError: list[Symbol.iterator] is not a function list.js:9
Uncaught TypeError: list[Symbol.iterator] is not a function list.js:96

the offending line

for (var series of list) series.id = series.childNodes[0].nodeValue;

https://github.com/Arnavion/libjass

We have this particular ASS (http://mugen.karaokes.moe/lyricsfiles/INT%20-%20Pokemon%20-%20OP%20-%20Gotta%20catch'em%20all.ass) with \N t ags inside to go to new lines.

When used with AO, the browser JS console reports an error :

Exception: TypeError
spans[0] is undefined
mainLoop@http://ryoko/JS/subtitles.js:2093:13

It seems to be on the code that manages how lines are split on multiple lines.

If we remove the \N from the .ass file, everything works fine.

Not a big issue as we can work around it just fine :)

Hello.

I installed AnimeOpenings on my server with a karaoke database we run. Setting it up was pretty easy and we generated a names.php from our database just fine. Thank you lots for making this.

I have several little issues though related to subtitles, I'll post them and this is the first one.

On videos where there is supposed to be several subtitles lines at the same time (the lyrics are quite fast) lyrics are overlapping each other. Would it be possible to handle multiple lines when one isn't completed yet?

Sample video : http://live.karaokes.moe/?video=%20Opening%20-JAP%20-%20DuckTales%20%282017%29%20

Here's the ASS file :
https://lab.shelter.moe/karaokemugen/karaokebase/blob/master/lyrics/JAP%20-%20DuckTales%20(2017)%20-%20OP%20-%20DuckTales.ass

Thanks for reading this :)

Hello :)

This has been tested with a version pulled from this repo on Apr 28th 2019.

This is visible on this karaoke :
https://live.karaokes.moe/?video=69d2440d-7dcb-42e4-aad1-2361136a6ed3

In the ASS style, vertical margin is defined at 75.

Here's how it's displayed in AnimeOpenings :

Here's how it's displayed in mpv :

As you can see, the vertical margin is only applied to the first line in mpv, whereas in AO it's applied to all lines, making the subs quite spaced out on screen when you have multiple lines.

Could this possibly be fixed sometime?

Thanks in advance :)

Is there a way to address database inconsistencies?

For example:

Ending 1a From Basilisk: Kouga Ninpouchou
Song: "Hime Murasaki" by Nana Mizuki

Has the video corresponding to:

Ending 1b From Basilisk: Kouga Ninpouchou
Song: "Wild Eyes" by Nana Mizuki

Thanks

Hello again :)

This is a very minor issue, but since #297 was fixed (thank you again) Chrome seems to put too much spacing between lines.

Here's a screencap from firefox :

And about the same one from chrome :

(don't mind the color change, it's from me using Stylus on FF)

That'd be nice if it could be fixed sometime, thanks :)

When a new video starts playing, its title could be displayed in some popup or on-screen text display for a few seconds. Doesn't need to be fancy, just the text you can see in the menu.

Before getting a new video it checks if the video is currently playing, then pauses it. After loading the new video it restores the original paused state. When a new video is loaded due to autoplay however, the video will always be in a paused state because it just ended.

Issue brought up in IRC by Yaroslavnur and bard.

The HMStoS function does s * 60 + m instead of m * 60 + s. Same goes for the hh:mm:ss conversion.

Also there's another error that i can't figure out since i can't python.

> ./encode.py -i orig.mkv -o opening.webm -e 01:30

Openings.moe 4.2 comfy encoder!

Input file: "orig.mkv"
Output file: "opening.webm"

Checking volume levels ...
Traceback (most recent call last):
  File "encode.py", line 167, in <module>
    volume = str(calcVolumeAdjustment())
  File "encode.py", line 86, in calcVolumeAdjustment
    subprocess.call(args, stdin=None, stdout=f, stderr=f)
  File "/usr/lib/python3.5/subprocess.py", line 560, in call
    with Popen(*popenargs, **kwargs) as p:
  File "/usr/lib/python3.5/subprocess.py", line 950, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.5/subprocess.py", line 1483, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: Can't convert 'float' object to str implicitly

Only happens if you use -s and/or -t.

Instead of using GET parameters (?video=) hashbangs (#!video=) could be used. Ideally while also modifying the browsing history so that the browser's back button would work.

This allows to:

1. quickly sharing the current video (it's already in the locationbar)
2. resume watching the same video when closing the browser and opening it again on the same page (seems to be saved in a cookie currently?)
3. use the back button to watch the previous video (seems to work already although I don't see why)

Hi everyone,

I tried to clone the project, but I get some error when loading the page.

Here is what I get in my Chrome console (same thing happens in firefox) :

main.js:25 Uncaught TypeError: Cannot read property 'src' of undefined
    at filename (main.js:25)
    at window.onload (main.js:75)

I tried to look into the code and it seems that videos are looped with foreach ($video['mime'] as $mime) in index.php, but the $video doesn't seem to have mime in it.

Thank you

I can't quite explain it, but some karaokes don't display at all on my end.

https://lab.shelter.moe/karaokemugen/karaokebase/blob/master/lyrics/JAP%20-%20Mugen%20no%20Ryvius%20-%20OP%20-%20Dis.ass

I thought at first it was the \fad effect but it seems to be supported according to the wiki page (or am I mistaken?)

Is this something I can fix on my end in my .ass file ? Or something you need to implement ?

It would be nice if looking up the hotkeys didn't take me to a different page but would be displayed on top of the video, which can then continue playing. Like a bootstrap modal.

Out of curiosity, is the JS code in the progress of being converted from jQuery to vanilla?

I can't help but notice that both are being used and in a number of areas, it seems to me it would be better (in terms of consistency and cleanliness) that jQuery is used. If it is in the progress of being converted into vanilla (ES6 I assume) then that would make sense to me.

Hello :)

Might be related to #299 but we found something interesting today.

Some of our ASS files had a Default style, but the Dialogue lines referenced another style that did not exist.

In a player like mpv this has never been a problem so we never noticed it : I suppose it defaults back to the "Default" style or the first style it finds perhaps.

We're in the process of trying to fix our files, but do you think it could be possible to implement such a case when trying to display a subtitle line?

I realize this might not be a good idea to workaround mistakes made by users, so I'd understand if you didn't want to fix this, I think though that it could help some users.

I have the subtitles option enabled, but no subtitles appear. There are certainly sources of the openings that have subtitles, so why doesn't this work .-.

I'd like for a search button in the top right that opens the video list
this way I can save a full click! And that's vitally important you know

Hello :)

In our video database, we have various resolutions... well, a lot of them actually. On all of our mp4/h264 videos there are about 40 different heights.

As a result, most of our ass files for karaoke do not have a PlayResX/PlayResY metadata, mainly because we're still in the process of replacing low-quality videos by h264, HD versions whenever we can (on about 5800 videos, this takes some time)

We use mpv to display karaoke videos in our app (http://mugen.karaokes.moe/en) and it works just fine with PlayResX/PlayResY at 0. However, on AnimeOpenings, such ASS files make the subs appear really small.

Would there be a way to either handle 0*0 resolutions so text appears bigger? Or have it as something configurable, even, please?

That'd really be neat :)

As the screenshot shows, the first syllabe on many subs (not all of them) doesn't get colorized during a karaoke.

On some ASS files this problem never occurs for some reason.

Example :

https://live.karaokes.moe/?video=%20PV%20-JAP%20-%20Penguin%20Highway%20

The line gets correctly colirzed when it reaches its end though, for some reason.

We have some fairly long video names in our database due to our own format. Is there a way to fix this?

Example :

http://live.karaokes.moe/?video=%20Opening%20-JAP%20-%20Uta%20no%20Prince-sama%20Sweet%20Senerade%20

If you click on the first series it suggests and then opening 1, it fails and 404s.

The video is not removed from the playlist array when we click remove. And the function "Edit Playlist" is not capable of fetching videos.

Kinda relevant to #297

Hello there! :)

We recently upgraded http://live.karaokes.moe to the latest AO code, and here's our issue. When subs are on more than two lines (like, there are 3 lines, even 4 at the same time) they overlap each other on screen.

Example here :

https://live.karaokes.moe/?video=c466a38c-95a4-4f40-83d4-d2e780b01be1

Some pics here :

You'll find all files here : http://kara.moe/base/kara/c466a38c-95a4-4f40-83d4-d2e780b01be1

Hello :)

We recently added a new karaoke on our fork of AnimeOpenings at http://live.karaokes.moe

https://live.karaokes.moe/?video=1e445b6a-e919-4d80-8cec-00422a405ecc

As you can see, this is some heavy weight ASS fun, and I honestly doubt you can do anything about it on your end to display it better but I'm creating an issue anyway just in case you want to look into it.

The "die" word in particular should disappear and appear way better. I invite you to check out the video + ass (which are downloadable from the menu) and see for yourself in vlc/mpv/mpc

Even though \kf seems to work fine according to the docs, I found a use case when it does not :

http://live.karaokes.moe/?video=%20Opening%20-FR%20-%20Il%20etait%20une%20fois%20la%20Vie%20

On this particular video we have sometimes \k or \kf and not all the letters are getting colored (on Firefox at least)

Here's the ASS :

https://lab.shelter.moe/karaokemugen/karaokebase/blob/master/lyrics/FR%20-%20Il%20etait%20une%20fois%20la%20Vie%20-%20OP%20-%20Hymne%20a%20la%20Vie.ass

It might be a side-effect of the fixes applied for #300, but when watching a 4:3 video, subs aren't quite aligned properly :

Note that I use Stylus to replace CSS on sites since I'm visually impaired (light blinds me a lot). When I enable it, it feels like the subtitle layer is off compared to the video :

Here's the ASS file in question :

https://lab.shelter.moe/karaokemugen/karaokebase/blob/master/lyrics/FR%20-%20Freakazoid%20-%20OP.ass

And the video :

https://www.dropbox.com/s/7hzoy2g2zw7qp3s/FR%20-%20Freakazoid%20-%20OP.mp4?dl=0

Sorry for creating so many issues, we have a lot of edge cases ^^

Steps to reproduce:

1. Set the Show Video Types in the Saved Settings menu to only allow Inserts
2. Play Songs

Is anyone making native version of this project for android?
If no one, I will start. Or just join to existing development, if there is any.

Also, please, update API documentation. Mention, that developers can get link to video stream by adding http://openings.moe/video/ to it's filename.

Hi,

When a line contains: {\K90}{\K42}yami {\K20}no {\K42}hou {\K27}ga {\k48}SU{\k46}TE{\k38}KI
It work,

When a line contains: {\k56}{\K41}hai{\K35}yori{\K31}masu{\K17}ka {\K48}sei {\K17}no {\K21}u{\K18}ne{\K34}ri
It does not work.

So using \K followed by \k works but not conversely.

for example : http://betav2.karaokes.moe/?video=Haiyore!Nyaruko-sanW-Opening and http://betav2.karaokes.moe/?video=Haiyore!Nyaruko-san-Opening

In reference to the code line below:

echo "\n\t\t" . '<meta property="og:video:type" content="' . $mime . '">';

When visiting the opening for Hidamari Sketch, the nested content value corrupts the HTML tag.

<meta property="og:video:type" content="video/webm;codecs="vp9,opus"">

I think a button to manage the sound of the video directly in the browser would be very practical =)

Hello there.

I have no idea if this is possible or not, but if it could it'd be great.

For Karaoke Mugen we analyze and collect all videos' audio gain values with ffmpeg with the following command line :

ffmpeg -i <file> -vn -af replaygain -f null -

It outputs info about the media file and also calculates its replay gain in decibels.

As we use mpv to play files on the desktop app, it allows us to pass the replay gain as a parameter. It makes for a smoother experience as all videos aren't on the same sound volume, so mpv adjusts the sound volume automatically with the audio gain we collected. (-6 dB, +2.7 dB, etc.)

We were wondering if the same thing was possible with AO's video player, if volume can be adjusted automatically if a audio gain is provided. I'm not even sure if it's possible but who knows ?

Hello, it's been a while :)

We have had a small issue for a while with AO and I just remembered to post about it now.

When we use mpv to display subtitles for karaoke, we get a single line in the ASS :

On AO, it appears cut in two lines :

Note that it seems to happen on Firefox but not on Chrome Mobile for some reason (on Chrome Mobile the line isn't cut)

EDIT: To clarify, the problems appear on both Firefox & Chrome desktop, but not on Chrome mobile

Here's a link to the song/ASS in question on Karaoke Mugen Live :

http://live.karaokes.moe/?video=92ba6883-3d3a-4664-900f-19c12b86e755

Is there a way to fix this, either on AO's side or in the ASS maybe ?

Thanks in advance.

I may be misremembering, but I think that in the past, if you went to a ?video= page then openings.moe would always loop the video, rather than continuing to a random one when it finishes.

However, currently, this isn't the case, and it remembers whatever you last had it set to on the site, rather than overriding it. So if I go to https://openings.moe/?video=Opening1-MahouShoujoLyricalNanohaAs for example, when the video completes, it continues to a random video.

suggested on the IRC channel
related videos == videos from the same series

Fix:
index.php {
remove the include_once "eggs.php";
add $eggs = [];
change $videos=$names + $eggs; to $videos=$names.$eggs;
}
api/list.php {
remove the include_once "../eggs.php";
add $eggs = [];
}

When there is a '!' character in a style name inside a .ass file, fontsizes[font] seem to not initialise correctly, and throw a "F undefined" error at line "F = F[S.toFixed(2)];" of "updateAlignment function. The lines seem to appear outside of the screen in this case.

Here is a file to show this behaviour :
exclamation_mark.txt
(note that this file doesn't have a "Default" style, that may be part of the problem).

Right now to change the page title and description, you have to edit index.php (which can be problematic if you're trying to keep yourself updated with the git version)

Could it be possible to move these to a config file? And any other customizable item you might think of, as well :)

Thanks in advance.

I would like to help with anything, or with what i have the power to do??

Making AnimeOpening better, one issue at a time :)

Here's the Love Hina opening (in french, yes.)

https://live.karaokes.moe/?video=0ababbb9-e0dd-4c8c-bf46-315eadfe9dfd

As you can see once the lyrics appear, they're too long for the width of the displayed video.

I suppose you could either implement some sort of word wrap or perhaps draw subs outside of the video? Not sure if this would work well, all things considered...

Similarly to #215, sliding the list in from the side (like a sidebar) would allow the video to continue playing while a video is selected.

Ideally, However, it should also be possible to open the list in a separate tab when middleclicking the link.

This isn't a big problem but still worth mentionning.

When \kf is used (not \k) the syllabe is filled after it's been sung, instead of during, shifting the whole karaoke as a result.

\k is more commonly used because of how romanji is separated pretty easily, but when we have songs in other languages, it feels more natural to use \kf.

I'll post an example as soon as I can get one from the person who told me about this issue

Kinda related to #305

Having strings in the app translatable could be nice. I wouldn't mind offering a french translation for instance, but right now everything seems hardcoded.

For having internaitonalized my own app Karaoke Mugen and its website, I know this is a real pain and takes a lot of time, so please don't consider this issue a priority at all. I'm opening it because it could be a good idea.

It'd be really nice if we could have embeds with basic information of the opening/anime in popular apps such as Twitter, Skype, Discord, Rabb.it.
EDIT: The current meta tags don't give enough information on certain services. It'd be nice to implement the OpenGraph and Twitter card protocol in the meta tags, for better compatibility across services.

It'd also be nice if we could click a link and go to a MAL description of the anime or something! @Yay295 More specifically, if you could have users add in a link to MAL manually, it'd be much nicer.

If you enable subs then do the konami code, the subs will stay behind the video and not rotate. http://s.savikin.me/scr/chrome_2016-03-19_21-57-52.png