Giter Club home page Giter Club logo

django-adzone's People

Contributors

andrewebdev avatar andrewsmedina avatar cwilhelm avatar cypressbit avatar jacquesdev avatar klice avatar melinath avatar mirzadelic avatar rad avatar saurav543 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

django-adzone's Issues

Im having problem adding banners

Hi guys, im having problem with adding new banners, and i just got the error message: Please correct the following error

without any more data, i cant see where and why happen this error

Thanks

Specify custom queryset for AdImpressions and AdClicks to streamline select_related

Currently, AdImpressions and AdClicks have an fk in their admin list view, which triggers select_related without any limits. That means that all related models and model fields (to an unlimited depth) will be selected - even though all that's being used is the ad name!

I'd suggest the following querysets:

AdImpression.objects.select_related('ad').only('ad__title', 'impression_date', 'source_ip')
AdClick.objects.select_related('ad').only('ad__title', 'click_date', 'source_ip')

adzone.tests.ClickTestCase fails

......F.....

FAIL: testClickOnAds (adzone.tests.ClickTestCase)

Traceback (most recent call last):
File "/home/fadeev/askbot-devel/adzone/tests.py", line 185, in testClickOnAds
self.assertEquals(len(AdClick.objects.all()), 2)
AssertionError: 1 != 2


Ran 12 tests in 1.745s

Missing migrations

The database has been modified, but the migrations to let it be brought back in line are missing.

Allow random_ad manager to look up ads using only zones.

I needed the template tag to only look up random ads based on their zone, as a bunch of ads were in different categories. So I modified the random_ad manager with a really simple if/else check for the category slug.

It's hackish, and now you have to send a blank string in place of the category slug with the template tag, but it works.

See diff here: http://gist.github.com/582724

AdClick admin search_fields error

In django-adzone/admin.py:

  • Class 'AdClickAdmin'
  • parameter search_fields = ['ad' , 'source_ip' ] needs to be changed to search_fields = ['ad__title', 'source_ip ] , since you can't directly search on foreign key ( i'm using Django 1.8 )

Adzone should not force contrib.sites on project

Having a adzone depend on sites is not really ideal. This situation comes up with projects that don't really require multi site support (which is probably most projects tbh). Authors may not even include the sites package at all, but will be forced to do so, just so that they can run this app.

I feel that if a client/dev wants site support, they should add this relation to the child models that inherits from Adbase.

Deleting an ad zone or category removes all ad impression data from that zone/category

If a website is redesigned and the zones change, right now, all ads that were in the zone will be deleted - and by association, all ad impressions from ads in that zone will be deleted. Which would make ad impression data irrecoverably deleted.

I think there are a couple of potential solutions here.

  1. Set ad category/zone foreign keys to NULL on delete instead of cascading.
  2. Record advertisers on AdImpressions instead of/in addition to ads. Slash set the AdImpression -> Ad foreign key to NULL on delete instead of cascading.

"Models aren't loaded yet" on new installation.

Hi, I just installed adzone and followed the documentation. I am running django 1.7 on a python 3.4 virtualenv. I added adzone tomy installed apps and get the following error when starting the development server:

File "/home/xzased/.virtualenvs/app/lib/python3.4/site-packages/django/apps/registry.py", line 131, in check_models_ready raise AppRegistryNotReady("Models aren't loaded yet.")

Add ability to set ads to auto-publish and auto-unpublish

It would be nice to have the option of setting an ad to, say, start being chosen at midnight on a certain day, and stop being chosen on some other day at midnight - without having to actually stay up until midnight either day.

django.db.models.fields.URLField.verify_exists fully deprecated as of 1.5

The error is occurring here:

File ".../src/django-adzone/src/adzone/models.py", line 19, in Advertiser 
website = models.URLField(verify_exists=True)

Producing the following error:

TypeError: __init__() got an unexpected keyword argument 'verify_exists'

As per Django depreciation timeline:

"django.db.models.fields.URLField.verify_exists will be removed. The feature was deprecated in 1.3.1 due to intractable security and performance issues and will follow a slightly accelerated deprecation timeframe."

https://docs.djangoproject.com/en/1.5/internals/deprecation/

Make category a non-required field.

It is possible to run an entire site on {% random_zone_ad %} - but you would still need to specify a Category for every ad you create. Would it be possible to make Categories optional?

Adds not rendering on page

Hi,
i am using your django-adzone
my django version == 1.7.4
and django-adzone == 0.2
python == 2.7.4

i add app in install app
add url in mauin urls
and done migrations after i add category ans zone
after that i add banner and textads and add template tag of django_adzone in template
i follow all your instruction from doc but still not render any add in page

Thanks in advance!!!

Simplify tree structure.

Most django projects I've seen have a simple repository file structure, with the source folder at the root of the repository. I'd propose that django-adzone switch to this structure; the src/ folder doesn't seem to serve any purpose.

Disallow duplicate advertisers

Right now, it's possible to have duplicate advertisers. For example, I could have two advertisers called BECU, each with the company website http://becu.org/.

It seems like it would make sense to require at least one of those fields to be unique. Maybe even both? Thoughts?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.