Giter Club home page Giter Club logo

Comments (5)

andrew-gresyk avatar andrew-gresyk commented on July 3, 2024 1

There are several reasons why I prefer the return on failure to be nullptr:
0. it's a standard failing return value

  1. checking against 0 is the fastest check, typically implemented with test eax, eax without the use of any other registers or values
  2. I'd rather the program crashed on error, than silently producing invalid output
  3. if it did return "\0", checking for it required a pointer dereference, most likely a cache miss

from hfsm2.

andrew-gresyk avatar andrew-gresyk commented on July 3, 2024

Thanks for reporting, Alexis, I'll look into it.

from hfsm2.

andrew-gresyk avatar andrew-gresyk commented on July 3, 2024

Should be fixed in 1.2.2

from hfsm2.

AlexisTM avatar AlexisTM commented on July 3, 2024

I don't think it should return nullptr as examples of the logger stream the output to std::cout with no nullptr check on the data.

from hfsm2.

AlexisTM avatar AlexisTM commented on July 3, 2024

In the meantime, this freeze should not happen as all methods are caught. :)

from hfsm2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.