andresmichel / one-dark-theme Goto Github PK

Any plans to create a Cmder theme? Would be awesome to get both Sublime and Cmder using the same theme.

I have installed a package to show icons. But now it is not showing.

As for the title, I want to report the bad styling happening on dev release 3154 released on 11th November.

Just install the version 3154 and open the command palette.

Thanks

Hello!
Is there any possibility to get dark sidebar for this theme?

Hello! Thank you very much for this theme. I am really like it.

I found a bug:

Reproduce:
Add a few projects. Open some file with code. Press Shift+Alt+p

I have installed the theme in Sublime Text 3.1.1 Build 2176, on Ubuntu 16.04

Almost all of the component (e.g TabBar, StatusBar, Package Menu) has changed based on the One Dark theme except the editor.

Would you mind uploading the theme to https://colorsublime.github.io so it's available for installation from there?

Thanks so much!

Please make A File Icon compatable with theme
and please also add same color scheme

I'm not sure however if it's your theme or the new version of Sublime Text itself which has troubles there.

Hi @andresmichel
Great theme!
Do you have any plans on porting also the light version?

Hi,

I was wondering, when will you release a new version of this package? Do you need help with any tasks that lead to a new release, such as testing?

Cheers

Is there some way or option to increase padding in tabs?

Hello,

I use and love your theme but I prefer another colour theme for my code. I've got Oceanic Next Italic.

This is the render:

However, as you can see, the tab isn't the same colour that the background of the editor. How could I change that?

Thanks.

On your screenshot, it's quite clear but on my screen, it's not so easy to see if a file is unsaved or not.

The Pug language has two types of comments: buffered and unbuffered.

A buffered comment is one that will get parsed to the output HTML as <!-- -->:

// I am a comment that will be parsed to output
body
  h1 This is a title
  p This is a paragraph

An unbuffered comment is one that will not get parsed to the output HTML as <!-- -->:

//- I am a comment that will *not* be parsed to output
body
  h1 This is a title
  p This is a paragraph

1. The default "comment" key binding in Sublime Text is for an unbuffered comment

   • One Dark correctly highlights those comments:
     

2. If I override that, and/or manually change every comment to be the buffered type

   • One Dark does not correctly highlight those comments:
     

I'm thinking that One Dark should somehow recognize that those buffered comments should be highlighted like the unbuffered ones.

I peeked at One Dark.tmTheme (not sure if this applies to Sublime Text or not), and found this bit of code:

<dict>
  <key>name</key>
  <string>Comments</string>
  <key>scope</key>
  <string>comment, punctuation.definition.comment</string>
  <key>settings</key>
  <dict>
    <key>foreground</key>
    <string>#5f697a</string>
    <key>fontStyle</key>
    <string> italic</string>
  </dict>

Maybe this could be modified somehow to recognize Pug's string.comment.buffered.block.pug, shown here:

<dict>
    <key>begin</key>
    <string>^(\s*)//</string>
    <key>comment</key>
    <string>Buffered (html) comments.</string>
    <key>end</key>
    <string>^(?!(\1\s)|\s*$)</string>
    <key>name</key>
    <string>string.comment.buffered.block.pug</string>

¯\_(ツ)_/¯

With hightlight_line: true in sublime settings, some invalid code is rendered in a color that is very difficult to see:

Example with deleted opening parentesis:

Example with incomplete boolean typed:

BTW, congratulations for the awesome theme. I'm using it for a few days and I'm loving it!

Oh, I'm using Windows 10 64 bits, Sublime Text Build 3126

Nice work. Its really cool

• I noticed the build panel has no background color

The close button is not crisp like the find bar items. Looking at the assets folder it looks like it is missing the @2x files for the close button. Not sure how you created them and if you have vector files for the pngs. Also, thank you for creating this theme!

Prerequisites

• [Y] Did you perform a cursory search to see if your bug or enhancement is already reported?

Description

In Ubuntu 16.04 with Xfce4.12 as my DE, I am unable to see the current line highlighted on the minimap even with "highlight_line": true in my Preferences.sublime-settings file. I am unsure if this issue also exists on Windows, but I believe even on Ubuntu with the default theme I can see the current line highlighted on the minimap which leads me to believe this is an issue with this theme. This is a pretty important feature in my opinion, plus Atom's minimap also has this feature.

Steps to Reproduce

1. Activate this theme.
2. Open any file with multiple lines.
3. Click on a line and look at the minimap.

Expected behavior: I expect the current line to be highlighted on the minimap.
Actual behavior: The current line is not highlighted on the minimap.

Versions

Ubuntu 16.04 LTS with Xfce4.12
Sublime 3143
Theme - One Dark v1.3.6

Media

Hi
Can't figure out why, but on my Mac the input fields for Command Palette, Find & Replace etc are dark text on white background, not the other way round as per the screenshots...
Any ideas why?
Cheers
James

It's not a bug, but I don't feel good. i like boxy theme folder style.

this is boxy theme

this is one-dark-theme