Giter Club home page Giter Club logo

salvagesmelter's People

Contributors

andrepl avatar di3mex avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

salvagesmelter's Issues

Ability to add items to config.

Requesting the ability to add items/returns to the config.

For example I want my players to be able to smelt Cauldrons and obtain the iron.

So perhaps I would add:

'380': IRON_INGOT: 7

Gold Equipment always returns full ammount.

I think I may have a bug for you.

I've tried armor damaged and undamaged, I've tried tools damaged and undamaged.
Gold armor and tools returns nuggets at full volume with no loss to damage, while the others work fine... I suppose I could try shifting this to Ingots instead of nuggets. I'll do that next. Just thought I should throw that out there for you.

Incorrect material in default config.yml?

In the file generated when installing the plugin:

  GOLD_CHESTPLATE: GOLD_INGOT:8
  GOLD_PICKAXE: GOLD_INGOT:27
  GOLD_SPADE: GOLD_INGOT:9

I'm assuming you intended to have (chestplate I changed material and quantity, pickaxe and spade I changed only the material):

  GOLD_CHESTPLATE: GOLD_NUGGET:72
  GOLD_PICKAXE: GOLD_NUGGET:27
  GOLD_SPADE: GOLD_NUGGET:9

New functions

Please give plugin ability to return only one piece of material after smelting.

Items without a damage value always return coal.

I'd like to be able to add recipes for items that do not have a damage value (for example iron bars, iron doors, rails, etc...) Unfortunately since they do not have a damage value coal is always returned.

22:34:36 [INFO] [SalvageSmelter] SmeltEvent::Source: ItemStack{RAILS x 1}
22:34:36 [INFO] [SalvageSmelter] SmeltEvent::Damage:ItemStack{RAILS x 1}
22:34:36 [INFO] [SalvageSmelter] getSalvage(RAILS, IRON_INGOT, NaN)
22:34:36 [INFO] [SalvageSmelter] getSalvage::Mathification:5 * NaN = 0

I realize I could "set always-yield-full-amount: true" to bypass this issue but that's not ideal and is ripe for abuse.

Thanks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.