Giter Club home page Giter Club logo

vega's People

Contributors

andreicuceu avatar dependabot[bot] avatar iprafols avatar pyup-bot avatar

Stargazers

avatar avatar avatar

Watchers

avatar avatar avatar

Forkers

frgerardi dkirkby

vega's Issues

L_binsize

  • Vega version:
  • Python version:
  • Operating System:

Description

Would be get to set L_binsize to CF grid size for default

What I Did

Paste the command(s) you ran and the output.
If there was a crash, please include the traceback here.

Config Tutorial Issue (per_exp_smooth)

In the Config Tutorial documentation, the description for per_exp_smooth says it is along the line of sight, but it should be across the line of sight.

build_config.py crashes when file is not in a git clone

build_config.py crashes at the line

git_hash = git.Repo(vega_path.parents[0]).head.object.hexsha

when the code is not from a git clone. This is the case when a tar file is downloaded instead from the list of tags. For instance

wget https://github.com/andreicuceu/vega/archive/refs/tags/v0.4.2.tar.gz

Update intro doc

Since git: URIs no longer work, the intro should specify:

git clone https://github.com/andreicuceu/vega.git

Also, the resulting package dir is vega, not Vega so the cd command should probably be updated.

Finally, if you would like to include instructions for a custom conda env, this worked for me:

conda create --name vega pip ipython jupyter jupyterlab ipykernel numpy scipy astropy numba h5py setuptools "iminuit>=2.0.0" cachetools matplotlib
conda activate vega
pip install mcfit

Cannot calculate single multiple with old fftlog

The following combination of INI parameters:

[model]
...
old_fftlog = True
single_multipole = 2

crashes with an array-indexing error:

File ~/DESI/code/vega/vega/pktoxi.py:199, in PktoXi.Pk2Mp(ar, k, pk, ell_vals, muk, dmuk, tform)
    197     xi_loc[-1] = 0
    198     spline = interpolate.splrep(np.log(r)-dr/2, np.real(xi_loc), k=3, s=0)
--> 199     xi[ell//2, :] = interpolate.splev(np.log(ar), spline)
    201 return xi

IndexError: index 1 is out of bounds for axis 0 with size 1

while setting old_fftlog = False works as expected.

It looks like this is a simple array size / indexing issue that should be easy to fix. Otherwise, if this combination is not worth supporting, perhaps check for it and print a useful message when it occurs?

Vega configuration files do not accept system variables

In the Vega config files I used environmental variables (as I used to do in fitter2), and I get the following error:

Traceback (most recent call last):
  File "/global/homes/i/iprafols/desi/git/vega/bin/run_vega_mpi.py", line 14, in <module>
    vega = VegaInterface(args.config)
  File "/global/homes/i/iprafols/.local/lib/python3.8/site-packages/vega/vega_interface.py", line 66, in __init__
    self.data[name] = data.Data(corr_item)
  File "/global/homes/i/iprafols/.local/lib/python3.8/site-packages/vega/data.py", line 36, in __init__
    rp_rt_grid, z_grid = self._read_data(data_path,
  File "/global/homes/i/iprafols/.local/lib/python3.8/site-packages/vega/data.py", line 133, in _read_data
    hdul = fits.open(find_file(data_path))
  File "/global/homes/i/iprafols/.local/lib/python3.8/site-packages/vega/utils.py", line 420, in find_file
    raise RuntimeError('The path/file does not exists: ', input_path)
RuntimeError: ('The path/file does not exists: ', PosixPath('$REDO_DR16/Correlation/cf_z_0_10-exp.fits'))

I think this is something useful to have

sampler installation instructions

I was trying to use the sampler with Andrea and found that the installation instructions are incomplete. If you just follow the instructions, then the libraries are not properly linked. You need to add the path to the libraries.

In my case I do export LD_LIBRARY_PATH=/global/homes/i/iprafols/desi/git/PolyChordLite/lib:${LD_LIBRARY_PATH}

This needs to be run in every terminal but can be added to the .bashrc (or .basrhc.ext) file for automatic running of the export.

It'd be good to add these few extra lines to the installation instructions

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.