andr1976 / hyddown Goto Github PK

The installation instructions in the README say to pip install hyddown, but the runtime dependencies are not included.

I was able to find the requirements.txt and install them manually, but I would suggest either setting up the distribution so pip can install the dependencies automatically, or include installing the dependencies in the installation instructions.

For review openjournals/joss-reviews#3695 :

I am running a fully updated Fedora 34 system with Python 3.9 (Python 2 deprecated).

I am unable to use pip to install the hyddown package per the instructions:

$ pip install hyddown
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Defaulting to user installation because normal site-packages is not writeable
ERROR: Could not find a version that satisfies the requirement hyddown (from versions: none)
ERROR: No matching distribution found for hyddown
$ pip install hyddown --user
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
ERROR: Could not find a version that satisfies the requirement hyddown (from versions: none)
ERROR: No matching distribution found for hyddown

While the manual provides additional information about where to find various main programs, some clarification in the README and comments in the code are strongly needed to make the software more intuitive
(Don't do anything yet, I am still working on the manual)

YOu need to install following three necessary for pyarrow or the install fails

pkg i libarrow-cpp libarrow-python libre2

Hello,

when I run the program, it does not complete the execution. You can see 1999/2000 in the console, but I do not know exactly what it means. See the image. Therefore I cannot extract values from it and use it how I wish. Any idea on how to solve this problem?

Running the input.yml at the root directory with the main.py script fails with the traceback:

{'calculation': [{'eta': ['unknown field']}]}
Traceback (most recent call last):
  File "main.py", line 21, in <module>
    hdown=HydDown(input)
  File "/Users/brandon/Projects/hyddown-rev/HydDown/src/hyddown/hdclass.py", line 31, in __init__
    self.validate_input()
  File "/Users/brandon/Projects/hyddown-rev/HydDown/src/hyddown/hdclass.py", line 47, in validate_input
    raise ValueError("Error in input file")
ValueError: Error in input file

Steps to reproduce:

1. Clone the HydDown repository
2. cd hyddown
3. pip install .
4. python src/main.py input.yml

I was able to run pytest from the main repo and run 33 tests in src/hyddown/test_all.py, however there were no instructions for running these and I'm not sure if I'm testing everything that was intended to be tested. The documentation could use a short statement on the correct procedure for running the automated tests.

For review openjournals/joss-reviews#3695 :

Other than the default github features (author identification, issue tracker, pull requests), there is no explicit mention in the README or elsewhere as to how one contributes to the software, reports, bugs (and requests enhancements) or asks for support.
Given the nature of the github interface, I do not think this is strictly required, but it would be beneficial to add text on this to the README file