andis-sprinkis / duckduckgo-lite-search Goto Github PK

I can't see words when using dark reader.

Sorry for the long report, but this need some background:

I use Firefox Multi-Account Containers. Individual containers have a setting called Limit to designated sites, which means any addresses not assigned to that container will open in a new, non-container tab (or the different container they're assigned to, if any).

For example, I have a GitHub container, that only allows github.com addresses. While on a GitHub container tab, if I click any links or type any address that isn't github.com, it will open in a new non-container tab. However, if I type a search term and search DDG Lite using this add-on from such a container, a new tab opens with the address https://lite.duckduckgo.com/lite/, but it seems like the search query isn't passed.

(This add-on works fine from containers where Limit to designated sites is disabled—the search would simply open in the current container tab.)

I believe this is mozilla/multi-account-containers#1886, but there is a possible workaround on the search add-on's side, which is why I'm opening an issue here.

Workaround

I only tested briefly, but it seems like putting the search terms in the URL instead of POST works in the above situation:

--- manifest.json
+++ manifest.json
@@ -14,8 +14,7 @@
     "chrome_settings_overrides": {
         "search_provider": {
             "name": "DuckDuckGo Lite",
-            "search_url": "https://lite.duckduckgo.com/lite/",
-            "search_url_post_params": "q={searchTerms}",
+            "search_url": "https://lite.duckduckgo.com/lite/?q={searchTerms}",
             "keyword": "ddg",
             "favicon_url": "https://duckduckgo.com/favicon.ico",
             "is_default": true,

The drawback is that search queries would be visible in the browser history, which might not be desirable to you or existing users.

If you're ok with it, I'll do a PR (after a bit more testing). Or if you have any other ideas on how to solve this problem. I'm not familiar with WebExtension so I might be missing something—maybe providing 2 different search options from one add-on is possible? one POST, one URL. Worst case, it could be a separate add-on.