amzhy / ped Goto Github PK

The user is able to add an invalid elderly name(i.e A name that has not been added to NurseryBook) to a task, as shown in the screenshot below.
Steps to reproduce:

1. addTask desc/check insulin date/2021-10-29 time/23:00 en/Notaneldery

Steps to reproduce:

1. addElderly en/John Doe a/40 g/M r/53 t/cancer t/diabetes t/friend
2. editElderly 10[index] t/family

editElderly command replaces all the tags with one tag - family. Perhaps the user only wanted to to edit one tag from 'friend' to 'family' but other tags are removed as well. Nurses should be able to specify which tag she would like to edit, instead of deleting existing tags which she might want to keep for that elderly.

The editElderly command restricts each elderly to 1 tag, while addTag allows users to add multiple tags to an elderly.

addElderly en/John a/0 g/m r/111 successfully adds an elderly, but 0 would be considered an invalid age for an elderly.

Steps to reproduce:

1. addElderly en/tom a/0 g/m r/100
2. remark 10 re/
   

There are no existing remarks for the elderly but the app misinforms the user that the remark has been removed for that elderly.

Steps to reproduce:

1. addElderly en/John a/80 g/M r/90
2. addTask en/John desc/washdate date/2021-09-25 time/23:22
3. editTask 2 en/NotanElderly

Using the editTask command, a user is able to change a valid name of an elderly(John) to an invalid name that does not exist in NurseyBook.

'Copy URL' button causes the link to the original user guide to be copied, redirecting a user to the wrong user guide instead of NurseyBook's user guide.

Steps to reproduce:

1. addElderly en/Matt a/0 g/M r/100 t/90
2. editElderly 11 nn/98989898

A user is able to specify the name of the next-of-kin using valid phone numbers if they use the wrong prefix nn/ instead of p/. Perhaps nn/ prefix should disallow only numbers as names as it is not the expected behaviour for a name prefix.

There is a long lag before the commands are visible on the 'help' window, as shown in the video. Switching to the Main window after the help command seems to help the 'help' window to be more responsive.

Screen Recording 2021-10-29 at 7.07.58 PM.mov

There are no screenshots in the user guide except in the quick start section. For a few commands, visual outputs might be important especially for new users.

steps to reproduce:

1. addElderly en/John Doe a/40 g/M r/53 nn/John Beckham rs/Father p/98765432 e/[email protected] t/friends t/owesMoney
2. addTask en/John Doe desc/wash date/2021-10-29 time/19:20
3. deleteElderly 1

The elderly is related to the task, assuming the task is meant to be completed for that elderly, but when the elderly is deleted, the tag with his name remains in the task as shown.

Although, 5 mins had elapsed since the time of the task #7 named 'wash sheets', the overdue tag is not added for the task. Only tasks that are initially created with overdue times actually have the overdue tags.

A task that is yet to be completed by the time specified would be expected to be tagged with overdue by users. Perhaps the expected behaviour for which tasks should have the overdue tag can be included in the user guide.

If the user changes the recurrence type from daily to weekly, would the user expect the updated date to be a week from the day that he edits the task or a week from the initial date of the task? This is unclear as it is not specified in the user guide. For example:

Date: 2021-10-29

1. addTask desc/give medicine date/2021-10-29 time/12:30 recur/daily

Date: 2021-10-31 (User realises that the task should be weekly and not a daily task)

2. editTask 1 recur/week

Would the date of the task be updated to 2021-11-07 or 2021-11-05?

If the recurrence of a task is changed from monthly to weekly, only the text indicating the type is changed, the date remains unchanged, even though the user would expect the date to be changed to a much earlier date. For example:

Date: 2021-10-29

1. addTask desc/give medicine date/2021-10-29 time/12:30 recur/monthly

Date: 2021-10-31 (User realises that the task should be weekly and not a monthly task)
2. editTask 1 recur/week

The date should be changed to 2021-11-05 which is a week from the initial date of the task, but it remains unchanged at 2021-10-29 (another bug which does not update date automatically to a month ahead).

steps to reproduce:

1. addElderly en/John Doe a/40 g/M r/53 nn/John Beckham rs/Father p/98765432 e/[email protected] t/friends t/owesMoney
2. addTask en/John Doe desc/wash date/2021-10-29 time/19:20
3. editElderly 1 en/Joe

The elderly is related to the task, assuming the task is meant to be completed for that elderly, but when the elderly's name is edited, the tag with his initial name:John Doe still remains in the task as shown.

Steps to reproduce:

1. addTask desc/run date/2021-10-29 time/19:30 recur/none

Based on the user guide and error message shown for recurrence in the app, only - day, week and month are valid arguments for the parameter /recur. But, the above mentioned command allows 'none' an invalid argument to be used successfully for /recur.

Steps to reproduce:

1. addElderly en/Matt a/0 g/M r/100 t/90
2. editElderly 11 t/90

editElderly command does not check if the updated fields differ from the existing values. For example, Matt already has the tag '90', but editing the tag to be '90' could inform the user that the elderly's details are already up-to-date, because his edit is not as meaningful since the original values will not be overwritten.

'NOK' abbreviation was not explained clearly in the glossary or anywhere else in the user guide, as a first-time user I had to guess or Google what it meant before I could use the commands. Perhaps it could be defined clearly in the beginning before using the abbreviation for the rest of the user guide.

editElderly command includes the functionality of addNok, (i.e Not only does it overwrite existing values, it also adds next-of-kin details that are absent for a particular elderly).

Although, there is a deleteNok command, there seems to be no addNok function which is actually being combined with the edit functionality under the editElderly command.

Perhaps it would be better to distinguish editing existing details of elderly from adding new NOK details, as new users would expect an addNok command(absent in user guide) if a deleteNok command is given in the user guide.

The dates are not updated automatically for the tasks as expected, after a few mins had elapsed since the time of the task. In the example shown in the screenshot, the date is expected to be updated to 2021-11-26 but the date shown remains as 2021-10-29. Similar outputs were observed for recurring daily and weekly tasks.

The app has to be restarted in order for the date to be updated correctly to 2021-11-26.