ampas / aces-docs Goto Github PK

The index link to the CLF implementation guide points to the CLF spec instead.

https://github.com/ampas/aces-docs/blob/dev/mkdocs/docs/specifications/clf/index.md

This document appears to include many instances of hyphens in the middle of words for no reason. I suspect this is a remnant of words being hyphenated across a line break in prior hard-wrapping. But since Mkdocs re-wraps at different line lengths depending on the current browser, these hyphenated words now appear in the middle of lines.

Hi,

As I was trying to follow the CLF Specification, in the Log section, in the sample code and the formula to compute logSideBreak, logSideSlope is used but not mentioned in the list of attributes of LogParams.
My guess and a quick look at the OpenColorIO code seems to confirm that it's mostly like linSideBreak (optional with a default value of 1), but having it explicitly mentioned in the spec would be nice.

(also note that in that box with details about the logSideBreak computation, some LaTeX is not rendered properly: \(\text{logSideBreak|\))

Thanks

As I'm trying to implement the spec, I've been running my parsing code on the CLF File Test Suite mentioned in the Implementation Guide.

In that test suite, in cdl_missing_style.clf, ASC_CDL has no style attribute and the description says Missing style defaults to "Fwd". However, the ASC_CDL section of the spec says that style is required without any mention of a default value.

If the test suite is correct, it seems to me that ASC_CDL's style should be marked as optional with the default value mentioned, as is the case for Range's style.

Also some minor thoughts I had reading the spec:

• Substititues should be Substitutes (6. section title)
• when nit should be when it (Matrix section)
• color com- ponents should be color components (LUT3D section)
• style (required has a missing closing bracket and should be style (required) (Log section)
• not a typo, but formatting-wise, maxOutValue (optional) should probably be followed by new line to be like the other elements of Range (Range section)
• what is called scale factor in the Bit Depth section is used with a different name SIZE in the formulas of the Range section. I thought calling it scaleFactor in those formulas would make it clearer they are the same.
• Among all process node substitutes sections, only the Exponent section explicitly mentions the Description element (with a link to ProcessNode). I think you could remove Description from the Exponent section for consistency.
• In the Range section, at the end of the description you are told that values must be set such that maxOutValue = maxInValue × bitDepthScale. From the context you can understand that if only the minimum value pair is provided, it is minOutValue = minInValue × bitDepthScale, but that I thought that maybe could be explicit, or written something like OutValue = InValue × bitDepthScale

Thanks

https://github.com/ampas/aces-docs/blob/dev/mkdocs/docs/specifications/clf/index.md#L1082

and

https://github.com/ampas/aces-docs/blob/dev/mkdocs/docs/specifications/clf/index.md#L1085

The text following !!! note is not indented, so appears below rather than within the text box. I assume this is an error.