alxpettit / akasha Goto Github PK

Tests on Windows show a crash when running akasha rec.

Err on a machine with dual microphone streams, on Windows.

InvalidAudioBlockChannelCount { expected: 1, actual: 2 }

Looks like upstream code expects an array of arrays of blocks, with one audio block per channel. For some reason, I expected the samples would just alternate, and I'd just need to recalculate the sample rate to get the same fidelity -- but it looks like I will need to dynamically build an array of arrays of blocks, and pass that around, which will require significant refactoring and rethinking of the asynchronous stream approach.

Edit:

Wow, good catch, me! Do you wanna just pass around a Vec<Vec<f32>> or something? The heap allocation isn't great, but it probably won't affect performance much, and earlier benchmarking suggested Vec was actually more performant than less heap-y alternatives, at least, without some ergonomic memory recycling.

Note: building a stream of a fixed size block, from an unknown size will require some slightly nontrivial logic to do efficiently. On the plus side, though, this might slightly reduce the overhead of whatever state machine nonsense async streams are doing behind the scenes. :D

Alternatively, we could just interleave the channels, but if the stream ever got interrupted we would have to make sure there was no ambiguity about which sample goes to which channel.

Edit 2: looks like maybe CPAL itself uses the interleaved format?

Also, I forgot this, but apparently I was already using Chunk objects, which are a wrapper around Vec<f32> if I remember rightly.

So, I'm going to have to un-interleave them. :/

It would be useful when recording from multiple devices, for some use cases, to be able to combine all the files into one directory -- but there is a risk of file name collision. It would be ideal to have the file name terminate with a %HOSTNAME in the format string or somesuch.

Probe commands were added after signal hooks, and the signal hooks feature no longer takes place at a sensible part of the execution flow.

Just curious...

pls implement

Does not list output devices