altlab / liquid-feedback-docker Goto Github PK

Thank you very much for your work!
This is just great!

I just build an image and get this on startup:

Starting PostgreSQL 9.4 database server: main.
Starting web server: lighttpd.
Lua 5.1.5  Copyright (C) 1994-2012 Lua.org, PUC-Rio
> Event:send_notifications_loop()
> 
(error object is not a string)

and on accessing the webpage:

Database error of class SyntaxErrorOrAccessRuleViolation occured:
permission denied for relation session

Stack trace follows:
[C]: in function 'escalate'
../lib/mondelefant.lua:1180: in function 'save'
/opt/lf/frontend/model/session.lua:24: in function 'new'
/opt/lf/frontend/app/main/_filter/20_session.lua:5: in function 'func'
../env/execute/file_path.lua:24: in function 'file_path'
../env/execute/_add_filters_by_path.lua:17: in function 'wrapper_func'
../env/execute/wrapped.lua:21: in function <../env/execute/wrapped.lua:11>
(tail call): ?
(tail call): ?
../env/execute/filtered_view.lua:28: in function 'filtered_view'
webmcp.lua:382: in function <webmcp.lua:257>
[C]: in function 'xpcall'
webmcp.lua:256: in main chunk
[C]: in function 'pcall'
/opt/lf/webmcp/cgi-bin/webmcp-wrapper.lua:7: in main chunk
[C]: ?

It seems to be a permission problem and in your TODO file you first point is:
fix db table permissions issue

Also:
I couldnt find any log files... are there somewhere?

Currently waiting for Frontend v4 to be released, leaving this issue as a reminder.

root@j314465:~/liquid-feedback-docker# docker run -i -t e328d9cff81d
[ ok ] Starting PostgreSQL 9.4 database server: main.
No directory, logging in with HOME=/
2017-07-18 13:02:11 UTC: Starting moonbridge server
2017-07-18 13:02:11 UTC: Loading "/opt/lf/webmcp/bin/mcp.lua"
No directory, logging in with HOME=/
No directory, logging in with HOME=/
2017-07-18 13:02:11 UTC: Creating pool
2017-07-18 13:02:11 UTC: Adding TCP listener on interface "0.0.0.0", port 8080
2017-07-18 13:02:11 UTC: Pool #1 created
2017-07-18 13:02:11 UTC: Creating pool
2017-07-18 13:02:11 UTC: Adding interval listener "send_pending_notifications"
2017-07-18 13:02:11 UTC: Pool #2 created
No directory, logging in with HOME=/
No directory, logging in with HOME=/
No directory, logging in with HOME=/
No directory, logging in with HOME=/
No directory, logging in with HOME=/
No directory, logging in with HOME=/
No directory, logging in with HOME=/
No directory, logging in with HOME=/
No directory, logging in with HOME=/

Currently the resulting image with Debian Buster is around 640mb.

Some ideas to help trim the image size:

• try using alpine as base
• use an intermediate build container (with all the build deps) and copy artifacts to final container
• further cleanup (package lists, locales, try running cruft)

This will make it easier to debug and upgrade each component individually, and eventually allow to run these images in production settings. Initial plan is to split into backend and frontend, and to base of available official images (e.g. postgresq).

An external postgresql database would allow managing the data separately, have it running in a volume outside docker, have backups ... You should consider allowing docker linking to a postgresql database.

Over the lifetime of this project there have been several fixes and enhancements made by downstream forks that might be worthwhile to pull into this repository.

Here's how to help out:

• look for a downstream fork that has made changes to this codebase
• go over the fork's commits and check if the changes made are still valid upstream
• create a branch from "altlab/liquid-feedback-docker" at the revision the downstream commits are based on
• cherry-pick the downstream commits (to maintain original authorship)
• rebase to upstream
• test it, making any necessary changes to get it working
• make a pull request