Giter Club home page Giter Club logo

notifications-ruby-client's Introduction

notifications-ruby-client's People

Contributors

bandesz avatar benlovell avatar benthorner avatar blesseddev avatar colinbruce avatar crystalpea avatar dazahern avatar digitalronin avatar emmabeynon avatar frankieroberto avatar h-lame avatar idavidmcdonald avatar jonathanglassman avatar karlchillmaid avatar kentsanggds avatar kevindew avatar klssmith avatar leohemsted avatar macool avatar matthewford avatar minglis avatar quis avatar saimaghafoor avatar samuelhwilliams avatar servingupaces avatar thomasleese avatar tijmenb avatar timblair avatar tuzz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

notifications-ruby-client's Issues

Simplify handling for transient network errors

In the GOV.UK email system, we've had to add our own error handling around calls to .send_email for unactionable / transient network errors, so we don't get notified about them (vs. other, fixable errors):

  • Net::OpenTimeout
  • Net::ReadTimeout
  • SocketError (getaddrinfo: Name or service not known)

Would it be possible to wrap these exceptions and expose one or two custom exceptions we could handle instead? This means we can decouple our code from the low-level request implementation.

(Note that we don't want to ignore these errors generally on GOV.UK, since they might indicate a real issue e.g. if we don't have a robust retry mechanism. In this case, we retry sending email many times.)

LoadError when using gem

Hi,

I get a load error when attempting to use the notifications-ruby-client gem:

$ irb
>> require 'notifications-ruby-client'
LoadError: cannot load such file -- notifications-ruby-client
    from /usr/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /usr/lib/ruby/site_ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from (irb):1
    from /usr/bin/irb:11:in `<main>'

Operating systems: CentOS 7, macOS Sierra 10.12
Ruby versions: ruby 2.4.0preview1 (2016-06-20 trunk 55466) [x86_64-linux], ruby 2.0.0p648 (2015-12-16 revision 53162) [universal.x86_64-darwin16]

README needs updating

The instruction say:
client = Notifications::Client.new(api_key)

But this returns:
ArgumentError: wrong number of arguments (given 1, expected 2..3)

The Speaker class expects a service_id and an api_secret. Can you clarify that the api_secret is the same as the API key that can be configured through the Notify admin console?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.