almmechanics / azskutils Goto Github PK

Describe the bug
The interface changes for Pester 5 have broken the usage of AzSKUtils, as the parameters are now obsolete

To Reproduce
Steps to reproduce the behavior:

1. Install-Module Pester -MinimumVersion 5.0.0
2. Import-Module Pester
3. Execute the AzSkUtils task

NOTE: Steps 1 & 2 are also replicated by using a newer build agent from Azure DevOps, as Pester 5 is now pre-installed on them.

Expected behavior
Update AzSk to make use of Pester5 style and interface.

Describe the bug
Using the task azsk-nunit-task@1 outputs a warning in the build logs.

To Reproduce
Added the following step to a yaml build pipeline:

• task: azsk-nunit-task@1
  displayName: 'Convert AzSK to NUnit output'
  inputs:
  OutputVariable: 'AZSK.NUnit.OutputPath'

Build logs output:
##[warning]Task 'azsk-nunit-task' (1.0.0) is using deprecated task execution handler. The task should use the supported task-lib: https://aka.ms/tasklib

Expected behavior
No warnings when using the task.

NUnit conversion for ARM analysis seems to work fine.

But for SVT analysis I'm getting an error as an NUnit test fail for every control in the SVT analysis even if the control passes...or am I doing something wrong?

RuntimeException: The variable '$ResourceName' cannot be retrieved because it has not been set.

Is your feature request related to a problem? Please describe.
When adding the build/release variable TreatAsPassed: 'Verify,Manual' the NUNit test result should reflect this in the expected output.

Describe the solution you'd like
When the the variable TreatAsPassed is defined, then the values (comma-seperated) list, is treated as expected values in the test result, so the test does not show as being failed since they by default expected Passed as the outcome of a test.

Additional context
TreatAsPassed is described in details in this article: https://azsk.azurewebsites.net/03-Security-In-CICD/Readme.html#azsk-arm-template-checker (search for TreatAsPassed on page)

Describe the bug
is not filled out in SVT test case. A substitution is missing.

To Reproduce
Just run a testrun. You will see lines like this in the Test results list of the test run:
azsk-svt. '[Medium AppService] 'Always On' should be configured for App Service' with in resource group XYZ

Expected behavior
azsk-svt. '[Medium AppService] 'Always On' should be configured for App Service' with myappservice in resource group XYZ