Giter Club home page Giter Club logo

allennlp-bert-qa-wrapper's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

allennlp-bert-qa-wrapper's Issues

Support pytorch-transformers

Very helpful repo. Could this be updated to use pytorch-transformers (the new version of pytorch-pretrained-bert)? That would be great!

Model not meant for training?

Hi,

Thanks for this wrapper,
I've been trying to use it for a different AI2 effort. I've noticed that in the forward :

    if self.training:
        loss = torch.sum(start_logits) * 0.0
        output_dict["loss"] = loss

Is this model not intended for training?

thanks!
Alon

when start_index == end_index for an entry, the predictor crashes instead of giving NO_ANSWER

Hi,

playing around and found this issue.

data to reproduce:

question: "does it have a pool"
passage: "in-room services provided/allowed,Refrigerator fee: USD 20.00 per night,breakfast provided/allowed,Breakfast fee: between USD 18.99 and USD 18.99 for adults, USD 12.99 and USD 12.99 for children (approximately),internet provided/allowed,Fee for in-room wireless Internet: USD 32.68 per night (rates may vary),extra_bed provided/allowed,Crib (infant bed) fee: USD 20.0 per night,Rollaway bed fee: USD 20.00 per night,parking provided/allowed,Valet parking fee: USD 16.00 per day (in/out privileges), Property Location \nWith a stay at Circus Circus Hotel, Casino & Theme Park in Las Vegas (Las Vegas Strip), you'll be within a 5-minute drive of Fashion Show Mall and Las Vegas Convention Center. This family-friendly resort is 3 mi (4.9 km) from T-Mobile Arena and 3.1 mi (4.9 km) from Las Vegas North Premium Outlets.\nRooms \nMake yourself at home in one of the 3773 air-conditioned guestrooms. Wireless Internet access (surcharge) keeps you connected, and cable programming is available for your entertainment. Private bathrooms with shower/tub combinations feature complimentary toiletries and hair dryers. Conveniences include phones, as well as safes and irons/ironing boards.\nAmenities \nDip into one of the 2 outdoor swimming pools or 2 spa tubs and enjoy other recreational amenities, which include a waterslide. This resort also features concierge services, gift shops/newsstands, and a hair salon.\nDining \nGrab a bite at Vince Neil, one of the resort's 5 restaurants, or stay in and take advantage of the room service (during limited hours). Snacks are also available at the coffee shop/café. Relax with a refreshing drink from the poolside bar or one of the 6 bars/lounges. Buffet breakfasts are available daily from 7:00 AM to 1:00 PM for a fee.\nBusiness, Other Amenities \nFeatured amenities include a 24-hour business center, express check-in, and express check-out. Free self parking is available onsite. "

there is only one n_best_info:

"nbest_info": [
            {
                "end_logit": -6.898498058319092,
                "probability": 1,
                "start_logit": -5.291764259338379,
                "text": ""
            }
        ],

but doesnt contain any text. because the start & end indexes are the same.

on model.py:241, best_non_null_entry will not be assigned because of the gated logic.
it will preceed to crash when trying to access this variable after.

my work around is to check if best_non_null_entry actually being non-null before continuing, and set predictions to be NO ANSWER.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.