A way to pass subscription options/metadata about pubsub HOT 12 CLOSED

I'll have a look as soon as I can! Depending on what we change, we might have breaking changes if we modify types.

from pubsub.

Oops 🤭 We just moved from CircleCI to Github Actions and it looks like we still have an issue with the publish workflow...

Thank you for letting me know!

from pubsub.

Just a dummy issue from my part: forgot to run the TypeScript build before publishing it to npm...

Version 4.4.1 should fix this now 😉

from pubsub.

Great 😄 You're welcome, and thank you also for your feedback!

from pubsub.

Hi @Shiroh1ge,

Thank you for your positive feedback 😄

Indeed, with the current version, we use topic.subscription:

We can only set:

• Subscriber options
• GetSubscription options

Unfortunately, I don't think there is a workaround in the current version. We cannot provide CreateSubscriptionOptions with the subscription.get method and the autoCreate flag set to true 😕

I've found an opened issue in the official lib: googleapis/nodejs-pubsub#1196

We could apply the workaround suggested just below.

from pubsub.

Hey @ccoeurderoy , thanks for the quick response! I also found the issue and came to the same conclusion, that we'd have to manually check if the subscription exists and create it with the CreateSubscriptionOptions. If you can make this change that would be awesome, I'm also willing to help you with that if you want.

from pubsub.

I don't mind the breaking changes, thanks very much for the help, very much appreciated!

from pubsub.

🎉 This issue has been resolved in version 4.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from pubsub.

@Shiroh1ge it should be ok now 😉

I hope Google will consider the previous issue! Feel free to re-open this issue if it does not work

from pubsub.

@ccoeurderoy I tried the latest 4.4.0 version, but for some reason I have no dist folder after installing it, I only see the package.json and README.md. Any idea why this can happen? I also tried removing the Nest packages, but it didn't help. 4.3.1 works fine

from pubsub.

No worries! I checked the package.json and it could be because of this:

  "files": [
    "dist/src/"
  ],

Probably has to be just dist/, but I'm not familiar with the project, so just a suggestion :D

from pubsub.

@ccoeurderoy this has also happened to me 😆 , I just tested it and it works perfectly. Thanks again for the quick update!

from pubsub.