Giter Club home page Giter Club logo

Comments (7)

sahal avatar sahal commented on August 16, 2024 9

Not sure why we're removing the package lock and yarn lock in the PKGBUILD. I'm no JS developer, but I think those are important to pin versions so these types of build issues don't occur.

If I modify the PKGBUILD included in this repo to comment out the removal of the package-lock.json and yarn.lock, Joplin builds correctly.

$ git diff | cat
diff --git a/PKGBUILD b/PKGBUILD
index 2b43429..2451e38 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -63,7 +63,7 @@ prepare() {
   fi
 
   msg2 "Deleting all package-locks.json"
-  find "${srcdir}/joplin-${pkgver}" -type f -name package-lock.json -delete
+#  find "${srcdir}/joplin-${pkgver}" -type f -name package-lock.json -delete
   msg2 "Appliying patches..."
 
   msg2 "Tweaking .yarnrc"
@@ -88,7 +88,7 @@ prepare() {
   cat "$desktop_package_json" | grep "electron-rebuild"
 
   msg2 "Removing yarn.lock"
-  rm "${srcdir}/joplin-${pkgver}/yarn.lock"
+#  rm "${srcdir}/joplin-${pkgver}/yarn.lock"
 }

from arch-pkgbuilds.

cuihaoleo avatar cuihaoleo commented on August 16, 2024 3

I don't know how to fix the PKGBUILD so I wrote a new one from scratch for archlinuxcn repo:
https://github.com/archlinuxcn/repo/blob/69b44e1cf576ca261a4868906d5ab9f238570839/archlinuxcn/joplin/PKGBUILD
It built successfully on my Arch PC and inside a clean chroot (extra-x86_64-build).

from arch-pkgbuilds.

alfredopalhares avatar alfredopalhares commented on August 16, 2024

Hello,

Can you show your electron dependencies versions and the versions of the makedepends ?

from arch-pkgbuilds.

alfredopalhares avatar alfredopalhares commented on August 16, 2024

@sahal good catch.

I intruduced them there while was trying to package joplin when it changed to yarn 3, i needed to some custumizations. I will remove this and do a release.

from arch-pkgbuilds.

JPFrancoia avatar JPFrancoia commented on August 16, 2024

I confirm that @sahal fix works.

from arch-pkgbuilds.

kentahikaru avatar kentahikaru commented on August 16, 2024

commenting out those "removing of lock" lines worked for me too.

from arch-pkgbuilds.

alfredopalhares avatar alfredopalhares commented on August 16, 2024

This has been fixed,reopen if necessary.

from arch-pkgbuilds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.