Comments (7)
Not sure why we're removing the package lock and yarn lock in the PKGBUILD
. I'm no JS developer, but I think those are important to pin versions so these types of build issues don't occur.
If I modify the PKGBUILD
included in this repo to comment out the removal of the package-lock.json
and yarn.lock
, Joplin builds correctly.
$ git diff | cat
diff --git a/PKGBUILD b/PKGBUILD
index 2b43429..2451e38 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -63,7 +63,7 @@ prepare() {
fi
msg2 "Deleting all package-locks.json"
- find "${srcdir}/joplin-${pkgver}" -type f -name package-lock.json -delete
+# find "${srcdir}/joplin-${pkgver}" -type f -name package-lock.json -delete
msg2 "Appliying patches..."
msg2 "Tweaking .yarnrc"
@@ -88,7 +88,7 @@ prepare() {
cat "$desktop_package_json" | grep "electron-rebuild"
msg2 "Removing yarn.lock"
- rm "${srcdir}/joplin-${pkgver}/yarn.lock"
+# rm "${srcdir}/joplin-${pkgver}/yarn.lock"
}
from arch-pkgbuilds.
I don't know how to fix the PKGBUILD so I wrote a new one from scratch for archlinuxcn repo:
https://github.com/archlinuxcn/repo/blob/69b44e1cf576ca261a4868906d5ab9f238570839/archlinuxcn/joplin/PKGBUILD
It built successfully on my Arch PC and inside a clean chroot (extra-x86_64-build
).
from arch-pkgbuilds.
Hello,
Can you show your electron dependencies versions and the versions of the makedepends ?
from arch-pkgbuilds.
@sahal good catch.
I intruduced them there while was trying to package joplin when it changed to yarn 3, i needed to some custumizations. I will remove this and do a release.
from arch-pkgbuilds.
I confirm that @sahal fix works.
from arch-pkgbuilds.
commenting out those "removing of lock" lines worked for me too.
from arch-pkgbuilds.
This has been fixed,reopen if necessary.
from arch-pkgbuilds.
Related Issues (20)
- joplin-desktop build fails in clean chroot HOT 3
- joplin-desktop build is not working anymore HOT 1
- Build fails on version 2.7.15 HOT 1
- Build Error joplin-2.7.15 HOT 2
- Build fails on version 2.8.8 HOT 1
- Release Joplin version 2.9.17
- Issue with yay AUR build of joplin-desktop - failure occurs HOT 3
- Error in building Joplin 2.10.19 HOT 3
- Joplin-cli and Joplin-desktop don't share data? HOT 2
- Build error 2.12.15-1 keytar@npm:7.9.0 HOT 2
- Joplin CLI crashes at startup HOT 2
- Joplin: Add support for MimeTypes
- Cannot find /usr/share/joplin/node_modules/joplin/app/ HOT 5
- joplin does not build HOT 3
- Cannot Build Joplin Release 2.14.17 HOT 2
- Status of joplin packages HOT 2
- Joplin sync error HOT 5
- 2.14.20-1 doesn't build, canvas@npm:2.11.2 couldn't be built successfully HOT 4
- Installing joplin-3.0.13 fails
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arch-pkgbuilds.