Giter Club home page Giter Club logo

Comments (9)

alfredodeza avatar alfredodeza commented on July 30, 2024

mind grabbing a screenshot so I can have a better idea of what you are experiencing? Thanks!

from coveragepy.vim.

merwok avatar merwok commented on July 30, 2024

With these two files:

screenshot

No matter where I run :Coveragepy report, it’s always the first split that gets the annotations (the big green/red margin), never the one on the right side.

With :Coveragepy show, it seems like there is a global toggle rather than a per-file option. If the left file is annotated and I move to the right one, the first show will turn off the annotations on the left file, and a second show will finally annotate the right-side file.

I’ve tried five coverage-vim plugins today and none of them is simple to install, simple to use and nice to see. This one is the closest! The desirable behaviour for me is: one command to annotate all files (i.e. report), one command to turn on/off in one file (show).

(Also a style that doesn’t overwrite my git gutter and is more pleasant → #16, and a pony :)

from coveragepy.vim.

alfredodeza avatar alfredodeza commented on July 30, 2024

@merwok good catch, thank you for providing the screenshot. You are right that the plugin is failing to use a per-file setting. Will try to address this soon.

from coveragepy.vim.

alfredodeza avatar alfredodeza commented on July 30, 2024

@merwok thank you so much for taking the time to report this, and for being patient :)

This particular issue is fixed with e479a93

Could you try that commit out and see how that works for you? I tested it out and respected the sign placement per buffer. Once you verify I'll push that to master.

Thanks!

from coveragepy.vim.

merwok avatar merwok commented on July 30, 2024

Issues with that version:

  • When I run :Coveragepy show in one buffer (in a split), other buffers get a huge green bar (it seems to be the «neutral» sign, so this could be resolved by #16 if we get a way to show nothing for covered lines). In the screenshot, I ran my coverage command then coveragepy on the right-hand sign split, and the screenshot is from another split, you can see the new code with the + signs from git-gutter and the existing code gets the flashy green. If I run coveragepy show in that file, the new code gets the red signs.
    screen1

  • The report and show commands take a very long time because they try to annotate all modules in my active virtualenv, ignoring the config I have in my tox.ini file.

  • Coverage signs are incorrect.

from coveragepy.vim.

alfredodeza avatar alfredodeza commented on July 30, 2024

Let's take it step by step though, not sure that your items are strictly related to this issue.

For this issue: in a split screen with more than one buffer: Do you get control of show per buffer? That is: is the reported (incorrect) behavior of always using the first pane solved by commit e479a93 ?

I am working on fixing the green block, but lets try to get this issue addressed first.

from coveragepy.vim.

alfredodeza avatar alfredodeza commented on July 30, 2024

Sign column blocks are now removed with 3187805 you can try that on top of e479a93

from coveragepy.vim.

alfredodeza avatar alfredodeza commented on July 30, 2024

These changes have been merged to master. This issue (signs always placed in first pane) is resolved there, with commit a6c2f6f

from coveragepy.vim.

merwok avatar merwok commented on July 30, 2024

Thanks a lot! I’ll be able to test soon.

from coveragepy.vim.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.