Giter Club home page Giter Club logo

themeengine's Introduction

ThemeEngine

App for OS X Yosemite to edit .car files which allows for the possibility of theming.

V.2 Branch is for 10.11+

themeengine's People

Contributors

alexzielenski avatar justin0a0 avatar mbert avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

themeengine's Issues

Cannot add rendition or element

No matter what I do, "Add Rendition" and "Add Element" in the menu bar are always grayed out. If I click the + button in the window, it either does nothing or freezes the app. Will this be fixed? Or is it not supported? Thanks.

A possible window swap for better font looks? See image.

I would like to hear if it's at all possible to swap two window styles when the font color isn't behaving?

I'm uncertain if ThemeEngine should handle this or an Opee extension? I just thought I'd hear here first.

It's related to ThemeEngine in a way. I've tried each and every color combination within ThemeEngine with no luck.

The App Store application on El Capitan is one other app that has this weird style to its active window.

systempreferenceswindowswap

unreliable content preview

The content preview of the images is very unreliable sometimes "objects" only contain empty images. If I reopen the file multiple times more and more content appears to be visible.

Here's a screenshot of some examples with empty images:
bildschirmfoto 2017-02-14 um 13 11 09

I'm using macOS 10.12.3 and ThemeEngine 1.0.0 (111).

Gradients works very funky - almost impossible to add multiple stops.

So with my Unity 2016 theme I just today wanted to add multiple stops to the gradient for the highlighted menu item - this seems impossible to do because the color stops seem to take over one another and move around - clinching together as one tries to add a color stop.

This is my experience and I've messed plenty with ThemeEngine these past days eventually to leaving the two color stop method.

Does not compile on Yosemite

2015-07-14 12:56:55.406 ibtoold[15017:1872999] Exception raised while unarchiving document objects - IBDocumentMissingCapabilityException
/* com.apple.ibtool.errors */
/Users/dmaclach/Downloads/ThemeEngine-2/ThemeEngine/ThemeEngine/Controllers/TEInspectorController.xib: error: The document "(null)" requires Mac OS 10.11 or later.
Recovery Suggestion: This version does not support stacking Non-gravity area distributions on NSStackView. Open this document with Mac OS 10.11 or later.

Certain items cannot be sent to or received from Photoshop

Certain items cannot be sent to Photoshop, or received from Photoshop. Most work, but maybe 10% of them don't, either via the Actions menu or drag and drop.

The items I've had trouble with so far are:
Menu_MenuBar (both items)
Menu_MenuItemHighlighted
WindowFrame_Background_Active (and same name@2x)
WindowFrame_Background_Inactive (and same name@2x)
WindowFrame_WindowBottomBar_Active@2x

There is no way to differentiate between some assets

For example, in the WindowFrame_WindowControlButtons Element group in the GraphiteAppearance.car file, there is no way to determine if you are working with the close, minimize, maximize, fullscreen, etc. traffic light elements in that group. You can only determine if they are active, inactive, activemain, etc. (unless I'm missing something obvious). Thanks.

screen shot 2015-11-21 at 7 22 17 pm

Beach ball icon

Enhancement request: Can ThemeEngine be used to edit/replace the rainbow wheel "waiting" cursor icon?

Can't edit CAAR files' color

In the "Raw Data" section of ThemeEngine, .CAAR files are present and, despite it being visible and having options to change orientation and blending mode, provides no way of editing their color.

Edit with applications other than photoshop

It would be really nice if the Send to editor and Receive from editor commands would work with other image editors such as GIMP, or failing that just expose the image files themselves so that I can open them with whatever application I like. At the moment I don't have Photoshop so it doesn't seem possible to edit anything other than basic gradients.

Looking through the source it seems like the integration occurs inside TEPhotoshopController which is basically hardcoded to use certain applications. If there is a way I could assist in the refactoring of that, or the development of this feature then let me know, as I have written OS X apps before.

9 part elements

For some reason, if you change the value of the bottom edge slice of a 9 part element, the value doesn't save with the file and sets to 0. Restarting ThemeEngine doesn't fix the issue. It appears that it's an everlasting issue no matter what.

screen shot 2017-10-29 at 2 53 33 am

Drag/drop

Dragging and dropping existing images into ThemeEngine does not work.
The + sign appears as you drag your image over an existing one, but nothing happens upon release of the click.

Using the Framework leads to corrupted .car file

Hi,

as mentioned in issue #19 , I am trying to build a simple CLI Tool for ThemeKit to automatically replace assets in a .car file after compiling an iOS app (to customize several apps without doing the whole compilation every time).

When I do the "replace Assets" step using the GUI, the iOS app starts and everything is fine, when I use my CLI the app crashes.

Here is what I do in my Swift file (very early prototype 😉, just a PoC for now). Argument 1 is the path to the .car file, argument 2 is a folder, that contains the images to replace (I match them by name).
When I open the .car file modified by my tool with the GUI tool, I can see my modifications, so I guess it is just one little detail I am missing.

import Foundation
import ThemeKit

let assetPath = Process.arguments[1]
let sourcePath = Process.arguments[2]

print(assetPath)
print(sourcePath)

var assetStorage = TKMutableAssetStorage(path: assetPath)

sleep(5) // avoid waiting for the notification in the PoC

func importRenditions(assetStorage : TKMutableAssetStorage) {
    var files : [String] = []
    do {
        // read files in the source folder
        files = try NSFileManager.defaultManager().contentsOfDirectoryAtPath(sourcePath)

        for rendition in assetStorage.allRenditions() {
            // if the name of the rendition matches one of the file names, replace it
            if(files.contains(rendition.name)) {
                print("Will import \(rendition.name)")
                let imageRendition = rendition as! TKBitmapRendition
                if  let data = NSData(contentsOfFile: "\(sourcePath)/\(rendition.name)"),
                    let imageRep : NSBitmapImageRep = NSBitmapImageRep(data: data) {
                        imageRendition.image = imageRep
                }
            }
        }
    } catch let error as NSError {
        print("\(error.localizedDescription)")
    }    
    assetStorage.writeToDiskUpdatingChangeCounts(false) // true did not work, also
}

importRenditions(assetStorage)

File size grows without bound

I noticed this recently when modifying my GraphiteAppearance.car, which has become larger than 4MB. This doesn't make any sense as all of the images I have added have been /smaller/ than the originals that they are replacing.

To reproduce: open a clean *.car file (try it with the Graphite one, I know for a fact this bug works for that one), save it, and watch as the file size grows by about 90kb each time you save (for extra fun, spam command+s). This is kind of sad since, unless there is an easy fix (remove all of the stuff that is added in the diff perhaps), most of the work I have done on my theme will need to be re-done in a new file when the bug is fixed.

System is OS X 10.11.2 using ThemeEngine 1.0.0 (109) v2.

diff contains the difference between the default 10.11.2 GraphiteAppearance.car file and a version that is opened and immediately saved.

extra.diff.txt

couple things....

When editing an image from pop-up the document doesn't become dirty

No tooltips for buttons in pop-ups

clicking on the color button in pop-up doesn't open color picker

Asset files don't open

I'm running 10.11.1 on a Mid-2010 MacBook.

Asset files stopped opening a while ago for me. A few hours ago I magically got one to open but ever since that I couldn't get it to work anymore. They just don't open.

Curious about the status of ThemeEngine?

Don't bother answering... you were active on the 30th of March this year and you couldn't bother to either close or just respond to this query -- you lost my respect as a developer giving zero fucks.

Inactive to active state of window switching will move button glyphs down one pixel

Recently I began updating my Leopard-esque theme for High Sierra and found that when either buttons or window frames are changed the inactive to active state of window will move button glyphs down one pixel. Eventually they disappear out of frame down below the graphics of the button. The glyphs only move downward and never upwards

This happens for Finder - back and forward. And the four glyphs; View, Column etc.

System Preferences' new look for All Settings and its glyph is also one of those moving.

I don't know how to fix that one with just graphics. I think, only think - that is has to do with the TouchBar interface. Many of the Touch .car files have been removed from Sierra up to High Sierra only having one Assets.car with all TouchBar elements in them. Right now, I'm standing still.

Aliasing images

When recieving a custom image from Photoshop, any pixel that is semi-transparent will turn either completely transparent or completely opaque.
For example, a perfectly smooth round vector ends up looking like this:
jagged
instead of:
smooth

Weird issues in MacOS 10.15 beta

I know it's pretty new, but when i try to open it in the beta preview of macOS 10.15 Catalina, i get this weird purple window and some UI elements are broken.

Screen Shot 2019-06-04 at 5 25 07 PM

Namely, as you can see, the left bar isn't displaying any assets i can select.

It works on Macos10.15+ and returns an error

xcode logs:

ThemeEngine[13764:1010470] Found 2361 facets
[/BuildRoot/Library/Caches/com.apple.xbs/Sources/Bom/Bom-219.2/Storage/BOMStorage.c:1066] BOMStorageCopyFromBlockRange: !data

ThemeEngine corrupts my .car files?

I've been working on a theme today and previous days using, I admit, the latest Public Beta of 10.11.4 and using the latest ThemeEngine release.

Now I'm faced with an issue that renders the whole theme useless.

The attached image is of the SystemAppearance CAR and I've only been working on the Retina components of the theme.

You will notice empty spots where there should be graphics to be changed. And I have changed some but now such things as sliderbuttons - textfields and searchfields are missing from the applied theme.

There are many many files that are gone now.

Recently before all this I change many font colors in an attempt to work around some OS related issues with dark Finder buttons and also Push Puttons - that didn't end well as you can see.

I'm about to start on a fresh slate and hope this issue does not occur in the future. I don't know if all the saving to the car files eventually makes it corrupt? I save 1000 times a day in order to see changes using Opee and extensions to Opee to see my changes almost as they are changed and saved to disk.

missinggraphics

missing textfield graphics

Unable to Add Element or Add Rendition

Hello! I've realized that DarkAppearance.car is missing some assets compared to SystemAppearance.car, but clicking the Add Element or Add Rendition buttons doesn't seem to do anything. I feel like this is something you're aware of, but I didn't see it in the closed issues list.
screen shot 2016-01-17 at 1 07 24 am

Does anyone know how to edit the rounded window corners?

I've tried a lot of the files in both Assets.car and SystemAppearance.car but nothing I change affects the rounded corners on Finder and other applications. I can change the drawers to square edges, or modal boxes but not the actual main window itself.

Does anyone know which file control window top and bottom left and right rounded corners?

Unable to open "ProThemeBits.car"

This .car file from the ProKit.framework at
/System/Library/PrivateFrameworks/ProKit.framework/Resources/ProThemeBits.car

The log is -

ThemeEngine[3526]: CoreUI: Can't increment old version of CAR.
ThemeEngine[3526]: This is not a valid car file

Transparent window bottom corners

I have changed WindowShapeEdges so that rounded window corners should be removed.
But the bottom corners seems transparent on the dark background thus still rounded. Still on light background they seem to be ok (squared as intented)

Please see the screenshot:

image

0.0.4 is actually 0.0.3

Downloaded 0.0.4 from the Releases page. This actually still downloads 0.0.3. Either that, or 0.0.4 is still identified as 0.0.3 (maybe your Info.plist didn't get updated).

Menu_MenuBar

Either I misunderstand what the files in this category do, or changes made to them do not get applied. If I am correct, these two files are the ones that should be changed to alter the OS X menu bar at the top of the screen. However, after applying changes to those, moving the .car file to the proper location, and rebooting, no changes are visible. If I am wrong, which file is used for the menu bar?

CLI

Hi,

is there any kind of CLI available for ThemeEngine?
If not, how would I start this one? Is there more documentation on ThemeKit then just the headers and it's use in the app?

My goal is to have a CLI that is able to replace Images in a .car file.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.