Giter Club home page Giter Club logo

jammming's Introduction

This project was bootstrapped with Create React App.

Available Scripts

In the project directory, you can run:

npm start

Runs the app in the development mode.
Open http://localhost:3000 to view it in the browser.

The page will reload if you make edits.
You will also see any lint errors in the console.

npm test

Launches the test runner in the interactive watch mode.
See the section about running tests for more information.

npm run build

Builds the app for production to the build folder.
It correctly bundles React in production mode and optimizes the build for the best performance.

The build is minified and the filenames include the hashes.
Your app is ready to be deployed!

See the section about deployment for more information.

npm run eject

Note: this is a one-way operation. Once you eject, you can’t go back!

If you aren’t satisfied with the build tool and configuration choices, you can eject at any time. This command will remove the single build dependency from your project.

Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except eject will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own.

You don’t have to ever use eject. The curated feature set is suitable for small and middle deployments, and you shouldn’t feel obligated to use this feature. However we understand that this tool wouldn’t be useful if you couldn’t customize it when you are ready for it.

Learn More

You can learn more in the Create React App documentation.

To learn React, check out the React documentation.

Code Splitting

This section has moved here: https://facebook.github.io/create-react-app/docs/code-splitting

Analyzing the Bundle Size

This section has moved here: https://facebook.github.io/create-react-app/docs/analyzing-the-bundle-size

Making a Progressive Web App

This section has moved here: https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app

Advanced Configuration

This section has moved here: https://facebook.github.io/create-react-app/docs/advanced-configuration

Deployment

This section has moved here: https://facebook.github.io/create-react-app/docs/deployment

npm run build fails to minify

This section has moved here: https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify

jammming's People

Watchers

James Cloos avatar Alex Padilla avatar  avatar

jammming's Issues

Feature Request Summary

Rubric Score

Criteria 1: Objective

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): Your objective is a great one. The enter to search is a feature that should be standard on every form. You even went above and beyond what most users do by inserting the features for only displaying tracks not added to the playlist as well as a preview feature. Nice work thinking of this!

Criteria 2: Background

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): Your background section is good. It provides a detailed explanation of the main points these features are addressing. You also gave a good summary of the overall functionality of the features within the app.

Criteria 3: Technical Design

  • Score Level: 3/4 (Meets Expectations)
  • Comment(s): You did well with your technical design section. You described how you would implement the enter to search function. However, you should have written a few code examples with some snippets, just a formatting issues if you use `` instead of throwing methods in the text. Great explanations in describing what components of the app would need to be modified in order to accommodate this new feature. Good work!

Criteria 4: Caveats

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You did a good job thinking about the potential caveats of this feature. Yes the correct way or best way to implement how you will track which songs are in the playlist and should not show up in the search results is difficult. The tag feature is probably the best, comparing the ID's of tracks and if there is a match it is pushed out of the array. One key to note is to delay the load until it is finished checking, it looks a little more professional to use the loading circle and not have things appear for split seconds and then be removed. Good job on your caveats.

Overall Score: 15/16

Overall, you did a great job with this feature request. You chose features that would improve the app and explained the necessity for these features clearly and concisely. You also did well in detailing the specific aspects of the technical implementation and what caveats you might encounter with your initial implementation. Nicely done!

Project Review

Rubric Score

Criteria 1: App Creation, Folder Structure, and File Paths

  • Score Level: 4/4
  • Comment(s): Folder structure and file paths, including imports/exports throughout all look solid ✔️

Criteria 2: Correct Implementation of User Flows (e.g. Searching, Token Generation, Save Playlist, etc.)

  • Score Level: 4/4
  • Comment(s): Functionality throughout the app works perfectly. I'm able to search, add/remove tracks, and successfully save to Spotify without a hiccup. Track previews was an added bonus as well ✔️

Criteria 3: Proper JavaScript and JSX Syntax and Formatting

  • Score Level: 4/4
  • Comment(s): I didn't see any glaring issues with the formatting of your JS/JSX throughout the app. I think it's awesome that you took advantage of multiple different language features that keep the code concise, as well as used constants throughout the app where necessary. Nice work! ✔️

Criteria 4: Implementation Adheres to DRY Principles

  • Score Level: 4/4
  • Comment(s): I didn't see any unnecessary/repeated code throughout the project. ✔️

Overall Score: 16/16

Awesome work!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.