Giter Club home page Giter Club logo

Comments (5)

pppery avatar pppery commented on June 29, 2024 1

FYI I personally think the bug you are exploiting in the "Overriding onExit" example is that you are allowed to close the startLevel function and run top level code at all, and not that you can then do nefarious things outside that function, but it's very unclear how much creativity of that sort should be allowed (this is a game focused on hacking the world after all) and how much should be forbidden.

from untrusted.

pppery avatar pppery commented on June 29, 2024

Overriding onExit
Should be fixed by #464 (which I wrote before seeing this issue, on general security grounds.)

from untrusted.

Alan-Liang avatar Alan-Liang commented on June 29, 2024

Overriding onExit
Should be fixed by #464 (which I wrote before seeing this issue, on general security grounds.)

Not really... it still works: https://gist.github.com/Untrusted-Game/455bb325f49ddeb5c7dccda77f2709fd

from untrusted.

pppery avatar pppery commented on June 29, 2024

#464 hasn't been merged yet. I'm unable to reproduce the "Overriding onExit" trick if I apply that patch locally and test your code (note that it silently fails: the game doesn't produce a validation error of any sort, but the onExit override doesn't do anything and you still need to have the computer to exit the level.)

from untrusted.

Alan-Liang avatar Alan-Liang commented on June 29, 2024

from untrusted.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.