alexnisnevich / untrusted Goto Github PK

getAdjacentEmptyCells as an api method seems less useful than just a getAdjacentCells, and letting the player filter by getObjectTypeAt, since as documented things like barriers are technically not empty, but passable, forcing me to have to code some special logic in case I'm on the last step in something like an acyclic depth-first search.
Another api method that would make code less hacky is to give a function for "object.positionAtDirection(direction)" which returns an x,y pair corresponding to the box at the specified direction. Much easier than the alternative of "testing" an adjacent square, which is tedious vector mapping.

[Feedback from Philip]

Feedback from Gilbert:

If I place an object that generates an exit after map generation, I can use the exit to get to the next level even though the map validation complains at me.

It's silly that we don't do this already. Will allow players to look back at old solutions and facilitate sharing and stuff.

e.g. Game.prototype.addToInventory ....

Maybe wrap everything in an anonymous function?

[Feedback from Devin]

http://daftontap.com/post/29091548990/seal-and-freeze-in-javascript

Maybe dump them into Map?

e.g. robotMaze, pointers

[Feedback from everyone re: pointers and Devin re: robotMaze]

That would enable people to share solutions and stuff. It'll be great.

another interesting thing! just moved ahead to level 21, but then went back to 20 to look at some code, and because it now reloads whatever your last code was it did that just fine... but because the original code only had 1 black editable line it loaded the rest of my code in the red zone so it's no longer editable... - Jordan

[Feedback from Devin]

Once we push live the solution-saving feature, we need to be able to override saved levels when we modify the level itself. A simple versioning system (clear localStorage for a given level if the current level file's version differs from the version saved in localStorage) ought to suffice.

(Feedback from Stephen.)

This should both help organization and provide a sipmle solution to preventing players from accessing verboten methods.

[Feedback from Alexander]

Dangerous functions (e.g. moveToNextLevel()) should not be able to execute while user code is being run (either on level execution or on callback).

The bad news: CC-ND only permits you to use up to 30 sec samples of music as "fair use". We need to ask permission to use all of the CC-ND songs we have right now.

The good news: There are >18,000 electronic CC songs available at http://freemusicarchive.org/genre/Electronic/?sort=track_interest and most of them are not ND. We can look through it and see what works.

And I think Dmitry's working on music too.

Ideas for the Game in General

• API Reference - constantly growing
• Decide what errors are "exploitable" and which are just errors (example: river.jsx)
• Make validators execute on every frame + make this an exploitable mechanic

Ideas for Levels

• Introduce a simplified sandboxed "DOM" at the very end of the game
• Make monster.js actually interesting (i.e. make game entities objects with a hierarchy)
• Puzzle where you have to use == vs ===
• "Interconnected maze" where you can just call a limited set of functions
• "Robot Friend" mechanic: a level where the player cannot move, but there is a robot, so you have to come up with an algorithm for the robot to move through the maze
• Level where the game suddenly becomes side-scrolling - need to implement jump to complete it

More Minor Things

• "Meta" inventory distinct from actual item inventory (per-level)
• Add something to editor object to keep track of last good executed version of code and swap it out whenever there is a successful execution and use it to replace what's in the editor on a syntax error. Also, have it flash static for a couple of seconds

This is really three issues in one:

• there's no protection against infinite loops happening, and when they do, the whole page freezes
• when syntax errors occur, no line numbers are given to the player
• Enter doesn't work, which makes adding lines to the middle of a 30-line block very tedious

Oh god, did I really just write that?

This should hopefully prevent madness like window['ev' + 'al'].

[Based on feedback from Ryan]

[Suggestion from Jordan]

Commit that causes this: 6a5c7cf

This is just a note to myself to at some point go through the code and clean up formatting and perhaps stylistic things

First off, I really enjoyed your game!

There is protection against the input block containing eval, but it's not that hard to work around. I found it was as simple as calling new Function on some string to run, but there are some other ways I found by just googling "eval without eval."

For example, on level 14 (crispsContest.js), the user-defined string can be defined like:

player.removeItem(''+new Function(prompt()).apply(map)+'');

and then at the textbox you just paste in the code:

this.placeObject(20, 10, 'theAlgorithm');
return 'greenKey';

which is too long to put by itself in the user-entered code area.

(As another issue, maybe validation on level 14 should include counts on theAlgorithm?)

(As another issue, maybe you want to forbid prompt and confirm? Keeping alert is nice for debugging without resorting to the browser inspector.)

[Suggestion from Jordan]

Should Probably Do

• Allow multi-line deletion, and handle it intelligently

Would Be Cool

• Mouseover help for known functions

Possibly Too Much Work

• Switch from CodeMirror to Ace editor (http://ace.c9.io/), which has live syntax checking support (!!!)
  • OR take a look at how Ace does it (https://github.com/ajaxorg/ace/wiki/Syntax-validation) and see if we can mimic it

and maybe even automatically make a gist with their solution or something

[Suggestion from Jordan]

Feedback from Yuval:

found a bug on level 10 (I've been taking breaks between levels lol), there was a drone on top of the goal but I just rushed the goal and the screen said I was killed but the goal still triggered and I moved on to the next level

[Feedback from essentially everybody]

well, we could do something like
overlay (real?) HTML elements over the game area canvas
and then present as the sekeleton code
just html
with a script tag
so there's the clue that DOM manipulation is what needs to happen
or maybe
for the last level
we abandon the roguelike environment altogether
and it's just the player
moving around on a html page
I'm thinking, like, build an obvious parody of facebook or google or some other popular website
with a lot of complexity in the dom
like, visual complexity, lots of differnet things happening on the page
and you have to move through it like a maze

• @neunenak

[Feedback from Conrad.]

[Suggestion from Jordan]

Chapter One. Prison Break

• blocks.jsx
• levelThree.jsx
• theReturnOfBlocks.jsx
• multiplicity.jsx
• traps.jsx
• introduction to monsters - drones 101!
• colors.jsx

Chapter Two. Search for the Artifacts

• forest.jsx
• "Interconnected maze" where you can just call a limited set of functions
• monster.jsx
  • Idea: Multiple groups of monsters where your only control over them is who they chase. Goal is to get them to chase each other in such a way that a path to the exit opens up.
• Monsters with weapons
• river.jsx
• Introduction to robot
• Simple navigation with robot
• robot.jsx - the dreaded maze level
• some sort of level where you give the three Artifacts to the Mysterious Benefactor

Chapter Three. Betrayal

• backToTheRiver.jsx (having to throw a certain exception)
• Platformer level
  • Idea: Make the player have to implement jump()
• Teleporters and canvas manipulation - it's safe to just modify
• DOM manipulation
• FINAL BOSS FIGHT - your own editor turns against you!
  - sometimes lines turn red, and when they turn fully red they erase

Fin

• Scrolling credits level?

Other playability feedback: The naive check for return is frustrating. Not being able to use lambdas or helper functions, say for mapping the result of getAdjacentEmptyCells sucks. Potentially only error out if you see a return that is NOT in the primary match of /function(^))^{{(^})*}/

[Feedback from Philip]

• Bullets should pass through each other
• Bullets shouldn't be able to destroy the Algorithm
• Should bullets be able to pass through blocks?
• Also, check victory conditions

Idea: maybe do a separate preprocessing step that converts Allman style indentation to K&R style indentation.

[Feedback from Philip]

I tried to solve the previous level in a way which allowed me to walk out with theAlgorithm, and it crashed on trying to load the next one. I tried reloading a couple of times, and discovered my character could still move, so I moved over the exit again and it incremented again. Doesn't look like it goes beyond that, but regardless, I can't seem to progress the level any further. I've tried refreshing the page and redoing level 15 as well as loading 16 separately and they all break with the same error.

I'm playing on Chrome Version 31.0.1650.63 m on Windows 8.1.

Should be fun to write, and will simplify the code for Crisp's Contest a fair bit.

[as per conversation with Ryan F]