Giter Club home page Giter Club logo

prj-rev-bwfs-dasmoto's People

Contributors

alexmicas avatar

prj-rev-bwfs-dasmoto's Issues

Indentation

Your indentation is off in your HTML. Try highlighting your code, right clicking and selecting format. If your text edit doesn’t have that feature try install a prettifier plugin. Also, most production standards is 2 spaces.

HTML

Your HTML looks really good. You use all the right elements. Another thing is that you wrap your code segments with divs. One suggestion is to make sure you wrap your h1 on line 9 with a div too. Also, even though it’s a very small code base, sprinkle in some comments as it is a good habit to get into.

Summary - Meets Expectations

Overall you did a good job on your project. You used the right HTML elements and you wrapped most of your code segments with divs. Make sure to get your indentation fixed and try to add some comments. Your CSS was really good as well. Just make sure you set font-family only once. All in all, nice work.

CSS

Your CSS is on point. You use all the right classes and your end product looks a lot like our solution. One thing I noticed is that you assign font-family to a lot of elements. Try just setting it to body and all of your child elements will inherit it. That way you set it only once. Lastly, when you use background-image make sure you wrap the url with quotes.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.