alexmicas / colmar-academy Goto Github PK

Summary Grade: Exceeds Expectations

Good job with your code! I really liked the way you clearly organized your code with whitespace, indentation, and comments. It makes your code really easy to navigate and read, as well as visually pleasing. Also, I really like the way you used classes and ids to group your sections together. As your code grows in size, this will help organize and manage your website. You also gave tremendous effort into your mobile resizing. Great start to the Ready program!

There really isn’t much to say though since you did very well. You did an exceptional job with your mobile resizing. Your website looks good at all sizes! In the future, you can consider helpers and libraries like Bootstrap (http://getbootstrap.com/) to help you build a responsive website. This library does a lot of pre-arranging and adjusting so that you don't have to write such detailed css.

Your lines are a bit long right now. Try splitting this into new lines so it's easier to read on one screen without scrolling. Convention is usually ~79 characters per line. It’s an issue of code density. Programmers like to have a lot of context when reading code. It is much, much quicker to glance up and down a window than it is to scroll. If you have very long lines, you also tend to have lines that vary in length a lot, leading to a lot of wasted screen real estate and being able to fit less code on screen at a given time overall. Don’t always rely on auto-wrapping since that’s not present in all text editors.

https://github.com/AlexMicas/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L192

Great incorporation of mobile resizing! Though it may seem tedious, it is an incredibly important concept since screen sizes vary tremendously today and it’s important that you website looks exactly as you design it to. Great job!

https://github.com/AlexMicas/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/resources/css/style.css#L420

Great decisions on the classes and ids name. It makes it very clear what its purpose is and makes grouping your sections very effective. These organizational skills come in handy as you expand your code since you can modify entire sections at once. You also chose very clear and concise names for them. It pays off to spend time thinking of good names for classes, ids, and variables.

https://github.com/AlexMicas/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L61

Don’t forget the semi-colon at the end of the special character. So it should be & or ©

https://github.com/AlexMicas/f1-3-c2p1-colmar-academy/blob/master/ColmarAcademy/index.html#L220