Hi,

I'm wondering if it's a good idea to transform the entire application to use the wmi package instead of executing Powershell commands via subprocess.

It's an implementation of the WMI API using pywintypes, accommodated for Python's internal types, of course. I believe it is far more efficient, in its entirety, compared to running Powershell via subprocess.

For example, the current method to obtain the CPU goes as follows:

    @property
    def cpu(self):
        """ Get the current CPU you got """
        ps = self.powershell("Get-WmiObject -Class Win32_Processor -ComputerName. | Select-Object -Property name")
        find_cpu = re.compile(r"\rname\r[-]{1,}\r(.*?)\r").search(ps)
        return find_cpu.group(1) if find_cpu else "Not found...??"

By using the WMI module, we could possibly simplify it to:

    # Where:
    #    import wmi
    #        ...
    #        self.wmi = wmi.WMI()
    @property
    def cpu(self):
        """ Get the current CPU """
        # Obtain the first CPU identity
        try:
            # The CPU model
            return self.wmi.instances("Win32_Processor")[0].wmi_property("Name").value
        except Exception:
            return "Not found...??"

Oops, I have to come up with a new ISSUE ...
This also shows that there is an error:sob:
Here's another mistake.
This error only appears on GIT BASH
OvO $ neofetch OSTraceback (most recent call last): File "C:\Users\Administrator\AppData\Local\Programs\Python\Python37-32\Scripts\neofetch-script.py", line 11, in <module> load_entry_point('neofetch-win==1.1.0', 'console_scripts', 'neofetch')() File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\neofetch_win\main.py", line 59, in main shell() File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\neofetch_win\main.py", line 54, in shell print(nf.pretty_print(), file=nf.stream) File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\colorama\ansitowin32.py", line 41, in write self.__convertor.write(text) File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\colorama\ansitowin32.py", line 162, in write self.write_and_convert(text) File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\colorama\ansitowin32.py", line 187, in write_and_convert self.write_plain_text(text, cursor, start) File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\colorama\ansitowin32.py", line 195, in write_plain_text self.wrapped.write(text[start:end]) UnicodeEncodeError: 'gbk' codec can't encode character '\ucf62' in position 12: illegal multibyte sequence
But works fine on CMD

C:\Windows\system32>python -V
Python 3.6.5 :: Anaconda, Inc.

C:\Windows\system32>neofetch
Traceback (most recent call last):
File "d:\program\anaconda3\lib\runpy.py", line 193, in _run_module_as_main
"main", mod_spec)
File "d:\program\anaconda3\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "D:\program\Anaconda3\Scripts\neofetch.exe_main.py", line 7, in
File "d:\program\anaconda3\lib\site-packages\neofetch_win\main.py", line 63, in main
shell()
File "d:\program\anaconda3\lib\site-packages\neofetch_win\main.py", line 56, in shell
nf.pretty_print(ignore_list=args.ignore),
File "d:\program\anaconda3\lib\site-packages\neofetch_win\neofetch.py", line 236, in pretty_print
components.append(*more_disk)
TypeError: append() takes exactly one argument (9 given)

For USA people they are always going to type color / artcolor as the on the long version of the commands.

So for them I would include those aliases.

I have my system with an RTX 3080 (as shown in the screenshot below). It is connected to a thunderbolt dock with support for DisplayLink, but I have disabled the DisplayLink functionality of the device. Still, every time I try to run neofetch-win on the latest version, it only shows the disabled DIsplayLink device.

Any ideas?

I running Neofetch-win Has Some Error.

Traceback (most recent call last): File "C:\Users\Administrator\AppData\Local\Programs\Python\Python37-32\Scripts\neofetch-script.py", line 11, in <module> load_entry_point('neofetch-win==1.0.9', 'console_scripts', 'neofetch')() File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\neofetch_win\main.py", line 59, in main shell() File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\neofetch_win\main.py", line 54, in shell print(nf.pretty_print(), file=nf.stream) File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\neofetch_win\neofetch.py", line 209, in pretty_print f"{self.colourize('OS')}: {self.os}", File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\neofetch_win\neofetch.py", line 121, in os lines = self.wmic("wmic os get Caption") File "c:\users\administrator\appdata\local\programs\python\python37-32\lib\site-packages\neofetch_win\neofetch.py", line 75, in wmic output = stdout.decode('UTF-8') UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc6 in position 51: invalid continuation byte
????:dog:

The IP address can be sensitive at times, if possible please provide a flag or dont print IP address.
Another suggestion would be to have flags to skip/include specific information.

neofetch-win relies on wmic in order to get the system info. Now, however, wmic has been removed from the dev branch of Windows 11, rendering neofetch-win unusable in the dev branch, and potentially unusable in future versions. How can this be fixed?

Installed using pip3.6 install neofetch-win

getting error:

Traceback (most recent call last):
  File "C:\Users\Mackan\AppData\Local\Programs\Python\Python36\Scripts\neofetch-script.py", line 11, in <module>
    load_entry_point('neofetch-win==1.0.3', 'console_scripts', 'neofetch')()
  File "c:\users\mackan\appdata\local\programs\python\python36\lib\site-packages\pkg_resources\__init__.py", line 565, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "c:\users\mackan\appdata\local\programs\python\python36\lib\site-packages\pkg_resources\__init__.py", line 2631, in load_entry_point
    return ep.load()
  File "c:\users\mackan\appdata\local\programs\python\python36\lib\site-packages\pkg_resources\__init__.py", line 2291, in load
    return self.resolve()
  File "c:\users\mackan\appdata\local\programs\python\python36\lib\site-packages\pkg_resources\__init__.py", line 2297, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "c:\users\mackan\appdata\local\programs\python\python36\lib\site-packages\neofetch_win\__init__.py", line 1, in <module>
    from .neofetch import Neofetch
  File "c:\users\mackan\appdata\local\programs\python\python36\lib\site-packages\neofetch_win\neofetch.py", line 1, in <module>
    import colorama
ModuleNotFoundError: No module named 'colorama'

################   ################      phoen@Lonely
################   ################      ------------
################   ################      OS: Windows 11 Home Insider Preview Single Language
################   ################      Uptime: 2 hours, 31 minutes and 9 seconds
################   ################      Local IP: 192.168.1.45
################   ################      Motherboard: ASUSTeK COMPUTER INC. (X513IA)
################   ################      CPU: Not found...??
                                         GPU: AMD Radeon(TM) Graphics
################   ################      Memory: 5.5GiB / 7.4GiB (74.75%)
################   ################      Disk: C: 127.8GiB / 237.2GiB (53.88%)
################   ################            D: 69.2GiB / 931.5GiB (7.43%)
################   ################
################   ################
################   ################
################   ################

CPU Not Found!
I own a Ryzen 7 4700u

OS: Windows Server 2012 R2

C:\Users\Administrator>neofetch
没有可用实例。
没有可用实例。
Traceback (most recent call last):
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python38-32\Scripts
\neofetch-script.py", line 11, in <module>
    load_entry_point('neofetch-win==1.1.1', 'console_scripts', 'neofetch')()
  File "c:\users\administrator\appdata\local\programs\python\python38-32\lib\sit
e-packages\neofetch_win\main.py", line 59, in main
    shell()
  File "c:\users\administrator\appdata\local\programs\python\python38-32\lib\sit
e-packages\neofetch_win\main.py", line 54, in shell
    print(nf.pretty_print(), file=nf.stream)
  File "c:\users\administrator\appdata\local\programs\python\python38-32\lib\sit
e-packages\neofetch_win\neofetch.py", line 212, in pretty_print
    f"{self.colourize('Motherboard')}: {self.motherboard}",
  File "c:\users\administrator\appdata\local\programs\python\python38-32\lib\sit
e-packages\neofetch_win\neofetch.py", line 170, in motherboard
    return f"{mboard_name[-1]} ({mboard_module[-1]})"
IndexError: list index out of range