Comments (7)
Same as before, just limited the allowed symbols within the generated secret key
from arkade.
/assign: me
from arkade.
Derek add label: help wanted, skill/beginner, good first issue
from arkade.
While working on this, I've found an issue in the code. If the user doesn't supply access and secret keys, they get generated with:
password.Generate()
Then we pass such keys within the overrides
parameter to helm3Upgrade
and in there, we parse them and use them as Args
in execute.ExecTask
.
The problem is that the key contains a "," the task execution will fail because it will be unable to parse the arguments.
Example (I've added code to print all the arguments passed to the task):
./arkade install minio
Using kubeconfig: /home/kaderno/.kube/config
Using helm3
Client: x86_64, Linux
2020/03/08 18:06:54 User dir established as: /home/kaderno/.arkade/
"stable" has been added to your repositories
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "openfaas" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈ Happy Helming!⎈
Access Key not provided, one will be generated for you
Secret Key not provided, one will be generated for you
VALUES values.yaml
upgrade
--install
minio
stable/minio
--namespace
default
--values
/tmp/charts/minio/values.yaml
--set
accessKey=6v5l4b854Zh483OmNya7
--set
secretKey=gwZ7BEspAO761P@qRjIX7&W[9UW8TJ53J,gH8V\r
--set
persistence.enabled=false
Command: /home/kaderno/.arkade/bin/helm3/helm [upgrade --install minio stable/minio --namespace default --values /tmp/charts/minio/values.yaml --set accessKey=6v5l4b854Zh483OmNya7 --set secretKey=gwZ7BEspAO761P@qRjIX7&W[9UW8TJ53J,gH8V\r --set persistence.enabled=false]
Error: failed parsing --set data: key "gH8Vr" has no value
Error: exit code 1, stderr: Error: failed parsing --set data: key "gH8Vr" has no value
from arkade.
Can the keys be quoted? Will that fix the problem?
from arkade.
@Waterdrips got it fixed! Sometimes reading the documentation helps :)
from arkade.
Are the values being sent via Command or Args?
from arkade.
Related Issues (20)
- arkade get helm downloads an old version HOT 5
- Defective edge case with Prometheus and Helm chart upgrade HOT 1
- krew broken HOT 2
- Add syft/grype CLIs from anchore HOT 5
- Use a separate Tempdir for arkade downloads HOT 1
- Arkade Install Kafka fails HOT 8
- Add links to projects in the Catalog of CLIs section of the README HOT 2
- Add Support for croc HOT 2
- Add support to install CloudNativePG and it's plugin HOT 1
- Improve output when arkade get gives a 404 HOT 1
- Fix viddy tool HOT 3
- Willing to include cmctl? HOT 5
- May need a default version upgrade for `arkade install linkerd` HOT 6
- Minor typo in README - installing containerd HOT 1
- [Tool] Add actuated-cli to arkade
- [Tool] actions-usage CLI
- Output of "arkade get" is too wide for a normal terminal HOT 3
- Add CNCF habor registry as an app HOT 4
- Add download for SeaweedFS HOT 4
- Add download for "slice" HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from arkade.